From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 -next] drm/komeda: remove set but not used variable 'old' Date: Tue, 23 Jul 2019 11:12:00 +0200 Message-ID: <20190723091200.GV15868@phenom.ffwll.local> References: <20190709135808.56388-1-yuehaibing@huawei.com> <20190722055627.38008-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190722055627.38008-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: james.qian.wang@arm.com, liviu.dudau@arm.com, brian.starkey@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch List-Id: dri-devel@lists.freedesktop.org On Mon, Jul 22, 2019 at 01:56:27PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/arm/display/komeda/komeda_plane.c: > In function komeda_plane_atomic_duplicate_state: > drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35: > warning: variable old set but not used [-Wunused-but-set-variable > > It is not used since commit 990dee3aa456 ("drm/komeda: > Computing image enhancer internally") > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > v2: fix compile err Ok this one worked, applied. Thanks, Daniel > --- > drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > index c095af1..98e915e 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > @@ -158,7 +158,7 @@ static void komeda_plane_reset(struct drm_plane *plane) > static struct drm_plane_state * > komeda_plane_atomic_duplicate_state(struct drm_plane *plane) > { > - struct komeda_plane_state *new, *old; > + struct komeda_plane_state *new; > > if (WARN_ON(!plane->state)) > return NULL; > @@ -169,8 +169,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane) > > __drm_atomic_helper_plane_duplicate_state(plane, &new->base); > > - old = to_kplane_st(plane->state); > - > return &new->base; > } > > -- > 2.7.4 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch