From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*() Date: Tue, 23 Jul 2019 09:47:07 -0300 Message-ID: <20190723124707.GB15357@ziepe.ca> References: <20190722223415.13269-1-jhubbard@nvidia.com> <20190722223415.13269-4-jhubbard@nvidia.com> <20190723002534.GA10284@iweiny-DESK2.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Ira Weiny , john.hubbard@gmail.com, Andrew Morton , Alexander Viro , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Boaz Harrosh , Christoph Hellwig , Daniel Vetter , Dan Williams , Dave Chinner , David Airlie , "David S . Miller" , Ilya Dryomov , Jan Kara , Jens Axboe , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Johannes Thumshirn , Magnus Karlsson , Matthew Wilcox , Miklos Szeredi List-Id: dri-devel@lists.freedesktop.org On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote: > * The leading underscores are often used for the more elaborate form of the > call (as oppposed to decorating the core function name with "_flags", for > example). IMHO usually the __ version of a public symbol means something like 'why are you using this? you probably should not' Often because the __ version has no locking or some other dangerous configuration like that. Jason