dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Ralph Campbell <rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: hmm_range_fault related fixes and legacy API removal v2
Date: Tue, 23 Jul 2019 15:20:20 +0000	[thread overview]
Message-ID: <20190723152015.GN15331@mellanox.com> (raw)
In-Reply-To: <7e1f33d4-4d3b-7927-38d1-b98b22ed4d78-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On Mon, Jul 22, 2019 at 06:11:04PM -0700, Ralph Campbell wrote:
> 
> On 7/22/19 2:44 AM, Christoph Hellwig wrote:
> > Hi Jérôme, Ben and Jason,
> > 
> > below is a series against the hmm tree which fixes up the mmap_sem
> > locking in nouveau and while at it also removes leftover legacy HMM APIs
> > only used by nouveau.
> > 
> > The first 4 patches are a bug fix for nouveau, which I suspect should
> > go into this merge window even if the code is marked as staging, just
> > to avoid people copying the breakage.
> > 
> > Changes since v1:
> >   - don't return the valid state from hmm_range_unregister
> >   - additional nouveau cleanups
> > 
> 
> I ran some OpenCL tests from Jerome with nouveau and this series,
> 5.3.0-rc1, and my two HMM fixes:
> ("mm/hmm: fix ZONE_DEVICE anon page mapping reuse")
> ("mm/hmm: Fix bad subpage pointer in try_to_unmap_one")
> 
> You can add for the series:
> Tested-by: Ralph Campbell <rcampbell@nvidia.com>

Thanks, would you also rebase and resend the patch deleting 
struct hmm_update ?

Jason
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2019-07-23 15:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22  9:44 hmm_range_fault related fixes and legacy API removal v2 Christoph Hellwig
     [not found] ` <20190722094426.18563-1-hch-jcswGhMUV9g@public.gmane.org>
2019-07-22  9:44   ` [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault, snapshot} Christoph Hellwig
     [not found]     ` <20190722094426.18563-2-hch-jcswGhMUV9g@public.gmane.org>
2019-07-22 14:37       ` Souptick Joarder
2019-07-23 14:54         ` [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault,snapshot} Jason Gunthorpe
     [not found]           ` <20190723145441.GI15331-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-07-23 16:19             ` [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault, snapshot} Christoph Hellwig
2019-07-23 17:18               ` [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault,snapshot} Jason Gunthorpe
2019-07-23  1:11   ` hmm_range_fault related fixes and legacy API removal v2 Ralph Campbell
     [not found]     ` <7e1f33d4-4d3b-7927-38d1-b98b22ed4d78-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-07-23 15:20       ` Jason Gunthorpe [this message]
2019-07-22  9:44 ` [PATCH 2/6] mm: move hmm_vma_range_done and hmm_vma_fault to nouveau Christoph Hellwig
2019-07-23 14:55   ` Jason Gunthorpe
2019-07-22  9:44 ` [PATCH 3/6] nouveau: remove the block parameter to nouveau_range_fault Christoph Hellwig
     [not found]   ` <20190722094426.18563-4-hch-jcswGhMUV9g@public.gmane.org>
2019-07-23 14:56     ` Jason Gunthorpe
2019-07-23 16:23       ` Christoph Hellwig
2019-07-22  9:44 ` [PATCH 4/6] nouveau: unlock mmap_sem on all errors from nouveau_range_fault Christoph Hellwig
2019-07-23 15:18   ` Jason Gunthorpe
2019-07-23 16:30     ` Christoph Hellwig
2019-07-23 17:17       ` Jason Gunthorpe
2019-07-23 17:23         ` Christoph Hellwig
2019-07-23 17:30           ` Jason Gunthorpe
2019-07-22  9:44 ` [PATCH 5/6] nouveau: return -EBUSY when hmm_range_wait_until_valid fails Christoph Hellwig
2019-07-23 15:18   ` Jason Gunthorpe
2019-07-22  9:44 ` [PATCH 6/6] mm: remove the legacy hmm_pfn_* APIs Christoph Hellwig
2019-07-23 15:27 ` hmm_range_fault related fixes and legacy API removal v2 Jason Gunthorpe
2019-07-23 16:32   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2019-07-03 22:02 Christoph Hellwig
2019-07-04 16:42 ` Jason Gunthorpe
2019-07-08 17:30   ` Ralph Campbell
     [not found]     ` <41dbb308-fc9e-d730-ffb0-6ce051dff1e1-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-07-08 17:32       ` Jason Gunthorpe
2019-07-05 12:33 ` Jason Gunthorpe
2019-07-09 14:30   ` Christoph Hellwig
     [not found]     ` <20190709143038.GA3092-jcswGhMUV9g@public.gmane.org>
2019-07-09 19:33       ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723152015.GN15331@mellanox.com \
    --to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox