From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Campbell Subject: [PATCH v2 2/7] mm/hmm: a few more C style and comment clean ups Date: Thu, 25 Jul 2019 17:56:45 -0700 Message-ID: <20190726005650.2566-3-rcampbell@nvidia.com> References: <20190726005650.2566-1-rcampbell@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190726005650.2566-1-rcampbell@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-mm@kvack.org Cc: Ralph Campbell , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Jason Gunthorpe , amd-gfx@lists.freedesktop.org, Christoph Hellwig List-Id: dri-devel@lists.freedesktop.org QSBmZXcgbW9yZSBjb21tZW50cyBhbmQgbWlub3IgcHJvZ3JhbW1pbmcgc3R5bGUgY2xlYW4gdXBz LgpUaGVyZSBzaG91bGQgYmUgbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgoKU2lnbmVkLW9mZi1ieTog UmFscGggQ2FtcGJlbGwgPHJjYW1wYmVsbEBudmlkaWEuY29tPgpDYzogIkrDqXLDtG1lIEdsaXNz ZSIgPGpnbGlzc2VAcmVkaGF0LmNvbT4KQ2M6IEphc29uIEd1bnRob3JwZSA8amdnQG1lbGxhbm94 LmNvbT4KQ2M6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPgotLS0KIG1tL2htbS5jIHwg MzkgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTcgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbW0vaG1t LmMgYi9tbS9obW0uYwppbmRleCA0MDQwYjQ0Mjc2MzUuLjM2Mjk0NGIwZmJjYSAxMDA2NDQKLS0t IGEvbW0vaG1tLmMKKysrIGIvbW0vaG1tLmMKQEAgLTMyLDcgKzMyLDcgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBtbXVfbm90aWZpZXJfb3BzIGhtbV9tbXVfbm90aWZpZXJfb3BzOwogICogaG1tX2dl dF9vcl9jcmVhdGUgLSByZWdpc3RlciBITU0gYWdhaW5zdCBhbiBtbSAoSE1NIGludGVybmFsKQog ICoKICAqIEBtbTogbW0gc3RydWN0IHRvIGF0dGFjaCB0bwotICogUmV0dXJuczogcmV0dXJucyBh biBITU0gb2JqZWN0LCBlaXRoZXIgYnkgcmVmZXJlbmNpbmcgdGhlIGV4aXN0aW5nCisgKiBSZXR1 cm46IGFuIEhNTSBvYmplY3QsIGVpdGhlciBieSByZWZlcmVuY2luZyB0aGUgZXhpc3RpbmcKICAq ICAgICAgICAgIChwZXItcHJvY2Vzcykgb2JqZWN0LCBvciBieSBjcmVhdGluZyBhIG5ldyBvbmUu CiAgKgogICogVGhpcyBpcyBub3QgaW50ZW5kZWQgdG8gYmUgdXNlZCBkaXJlY3RseSBieSBkZXZp Y2UgZHJpdmVycy4gSWYgbW0gYWxyZWFkeQpAQCAtMzI1LDggKzMyNSw4IEBAIHN0YXRpYyBpbnQg aG1tX3BmbnNfYmFkKHVuc2lnbmVkIGxvbmcgYWRkciwKIH0KIAogLyoKLSAqIGhtbV92bWFfd2Fs a19ob2xlKCkgLSBoYW5kbGUgYSByYW5nZSBsYWNraW5nIHZhbGlkIHBtZCBvciBwdGUocykKLSAq IEBzdGFydDogcmFuZ2UgdmlydHVhbCBzdGFydCBhZGRyZXNzIChpbmNsdXNpdmUpCisgKiBobW1f dm1hX3dhbGtfaG9sZV8oKSAtIGhhbmRsZSBhIHJhbmdlIGxhY2tpbmcgdmFsaWQgcG1kIG9yIHB0 ZShzKQorICogQGFkZHI6IHJhbmdlIHZpcnR1YWwgc3RhcnQgYWRkcmVzcyAoaW5jbHVzaXZlKQog ICogQGVuZDogcmFuZ2UgdmlydHVhbCBlbmQgYWRkcmVzcyAoZXhjbHVzaXZlKQogICogQGZhdWx0 OiBzaG91bGQgd2UgZmF1bHQgb3Igbm90ID8KICAqIEB3cml0ZV9mYXVsdDogd3JpdGUgZmF1bHQg PwpAQCAtMzc2LDkgKzM3Niw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBobW1fcHRlX25lZWRfZmF1 bHQoY29uc3Qgc3RydWN0IGhtbV92bWFfd2FsayAqaG1tX3ZtYV93YWxrLAogCS8qCiAJICogU28g d2Ugbm90IG9ubHkgY29uc2lkZXIgdGhlIGluZGl2aWR1YWwgcGVyIHBhZ2UgcmVxdWVzdCB3ZSBh bHNvCiAJICogY29uc2lkZXIgdGhlIGRlZmF1bHQgZmxhZ3MgcmVxdWVzdGVkIGZvciB0aGUgcmFu Z2UuIFRoZSBBUEkgY2FuCi0JICogYmUgdXNlIGluIDIgZmFzaGlvbnMuIFRoZSBmaXJzdCBvbmUg d2hlcmUgdGhlIEhNTSB1c2VyIGNvYWxlc2NlCi0JICogbXVsdGlwbGUgcGFnZSBmYXVsdCBpbnRv IG9uZSByZXF1ZXN0IGFuZCBzZXQgZmxhZ3MgcGVyIHBmbnMgZm9yCi0JICogb2YgdGhvc2UgZmF1 bHRzLiBUaGUgc2Vjb25kIG9uZSB3aGVyZSB0aGUgSE1NIHVzZXIgd2FudCB0byBwcmUtCisJICog YmUgdXNlZCAyIHdheXMuIFRoZSBmaXJzdCBvbmUgd2hlcmUgdGhlIEhNTSB1c2VyIGNvYWxlc2Nl cworCSAqIG11bHRpcGxlIHBhZ2UgZmF1bHRzIGludG8gb25lIHJlcXVlc3QgYW5kIHNldHMgZmxh Z3MgcGVyIHBmbiBmb3IKKwkgKiB0aG9zZSBmYXVsdHMuIFRoZSBzZWNvbmQgb25lIHdoZXJlIHRo ZSBITU0gdXNlciB3YW50cyB0byBwcmUtCiAJICogZmF1bHQgYSByYW5nZSB3aXRoIHNwZWNpZmlj IGZsYWdzLiBGb3IgdGhlIGxhdHRlciBvbmUgaXQgaXMgYQogCSAqIHdhc3RlIHRvIGhhdmUgdGhl IHVzZXIgcHJlLWZpbGwgdGhlIHBmbiBhcnJheXMgd2l0aCBhIGRlZmF1bHQKIAkgKiBmbGFncyB2 YWx1ZS4KQEAgLTM4OCw3ICszODgsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaG1tX3B0ZV9uZWVk X2ZhdWx0KGNvbnN0IHN0cnVjdCBobW1fdm1hX3dhbGsgKmhtbV92bWFfd2FsaywKIAkvKiBXZSBh cmVuJ3QgYXNrIHRvIGRvIGFueXRoaW5nIC4uLiAqLwogCWlmICghKHBmbnMgJiByYW5nZS0+Zmxh Z3NbSE1NX1BGTl9WQUxJRF0pKQogCQlyZXR1cm47Ci0JLyogSWYgdGhpcyBpcyBkZXZpY2UgbWVt b3J5IHRoYW4gb25seSBmYXVsdCBpZiBleHBsaWNpdGx5IHJlcXVlc3RlZCAqLworCS8qIElmIHRo aXMgaXMgZGV2aWNlIG1lbW9yeSB0aGVuIG9ubHkgZmF1bHQgaWYgZXhwbGljaXRseSByZXF1ZXN0 ZWQgKi8KIAlpZiAoKGNwdV9mbGFncyAmIHJhbmdlLT5mbGFnc1tITU1fUEZOX0RFVklDRV9QUklW QVRFXSkpIHsKIAkJLyogRG8gd2UgZmF1bHQgb24gZGV2aWNlIG1lbW9yeSA/ICovCiAJCWlmIChw Zm5zICYgcmFuZ2UtPmZsYWdzW0hNTV9QRk5fREVWSUNFX1BSSVZBVEVdKSB7CkBAIC01MDIsNyAr NTAyLDcgQEAgc3RhdGljIGludCBobW1fdm1hX2hhbmRsZV9wbWQoc3RydWN0IG1tX3dhbGsgKndh bGssCiAJaG1tX3ZtYV93YWxrLT5sYXN0ID0gZW5kOwogCXJldHVybiAwOwogI2Vsc2UKLQkvKiBJ ZiBUSFAgaXMgbm90IGVuYWJsZWQgdGhlbiB3ZSBzaG91bGQgbmV2ZXIgcmVhY2ggdGhhdCBjb2Rl ICEgKi8KKwkvKiBJZiBUSFAgaXMgbm90IGVuYWJsZWQgdGhlbiB3ZSBzaG91bGQgbmV2ZXIgcmVh Y2ggdGhpcyBjb2RlICEgKi8KIAlyZXR1cm4gLUVJTlZBTDsKICNlbmRpZgogfQpAQCAtNTIyLDcg KzUyMiw2IEBAIHN0YXRpYyBpbnQgaG1tX3ZtYV9oYW5kbGVfcHRlKHN0cnVjdCBtbV93YWxrICp3 YWxrLCB1bnNpZ25lZCBsb25nIGFkZHIsCiB7CiAJc3RydWN0IGhtbV92bWFfd2FsayAqaG1tX3Zt YV93YWxrID0gd2Fsay0+cHJpdmF0ZTsKIAlzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZSA9IGhtbV92 bWFfd2Fsay0+cmFuZ2U7Ci0Jc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEgPSB3YWxrLT52bWE7 CiAJYm9vbCBmYXVsdCwgd3JpdGVfZmF1bHQ7CiAJdWludDY0X3QgY3B1X2ZsYWdzOwogCXB0ZV90 IHB0ZSA9ICpwdGVwOwpAQCAtNTcxLDggKzU3MCw3IEBAIHN0YXRpYyBpbnQgaG1tX3ZtYV9oYW5k bGVfcHRlKHN0cnVjdCBtbV93YWxrICp3YWxrLCB1bnNpZ25lZCBsb25nIGFkZHIsCiAJCQlpZiAo ZmF1bHQgfHwgd3JpdGVfZmF1bHQpIHsKIAkJCQlwdGVfdW5tYXAocHRlcCk7CiAJCQkJaG1tX3Zt YV93YWxrLT5sYXN0ID0gYWRkcjsKLQkJCQltaWdyYXRpb25fZW50cnlfd2FpdCh2bWEtPnZtX21t LAotCQkJCQkJICAgICBwbWRwLCBhZGRyKTsKKwkJCQltaWdyYXRpb25fZW50cnlfd2FpdCh3YWxr LT5tbSwgcG1kcCwgYWRkcik7CiAJCQkJcmV0dXJuIC1FQlVTWTsKIAkJCX0KIAkJCXJldHVybiAw OwpAQCAtNjIwLDEzICs2MTgsMTEgQEAgc3RhdGljIGludCBobW1fdm1hX3dhbGtfcG1kKHBtZF90 ICpwbWRwLAogewogCXN0cnVjdCBobW1fdm1hX3dhbGsgKmhtbV92bWFfd2FsayA9IHdhbGstPnBy aXZhdGU7CiAJc3RydWN0IGhtbV9yYW5nZSAqcmFuZ2UgPSBobW1fdm1hX3dhbGstPnJhbmdlOwot CXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hID0gd2Fsay0+dm1hOwogCXVpbnQ2NF90ICpwZm5z ID0gcmFuZ2UtPnBmbnM7CiAJdW5zaWduZWQgbG9uZyBhZGRyID0gc3RhcnQsIGk7CiAJcHRlX3Qg KnB0ZXA7CiAJcG1kX3QgcG1kOwogCi0KIGFnYWluOgogCXBtZCA9IFJFQURfT05DRSgqcG1kcCk7 CiAJaWYgKHBtZF9ub25lKHBtZCkpCkBAIC02NDgsNyArNjQ0LDcgQEAgc3RhdGljIGludCBobW1f dm1hX3dhbGtfcG1kKHBtZF90ICpwbWRwLAogCQkJCSAgICAgMCwgJmZhdWx0LCAmd3JpdGVfZmF1 bHQpOwogCQlpZiAoZmF1bHQgfHwgd3JpdGVfZmF1bHQpIHsKIAkJCWhtbV92bWFfd2Fsay0+bGFz dCA9IGFkZHI7Ci0JCQlwbWRfbWlncmF0aW9uX2VudHJ5X3dhaXQodm1hLT52bV9tbSwgcG1kcCk7 CisJCQlwbWRfbWlncmF0aW9uX2VudHJ5X3dhaXQod2Fsay0+bW0sIHBtZHApOwogCQkJcmV0dXJu IC1FQlVTWTsKIAkJfQogCQlyZXR1cm4gMDsKQEAgLTY1NywxMSArNjUzLDExIEBAIHN0YXRpYyBp bnQgaG1tX3ZtYV93YWxrX3BtZChwbWRfdCAqcG1kcCwKIAogCWlmIChwbWRfZGV2bWFwKHBtZCkg fHwgcG1kX3RyYW5zX2h1Z2UocG1kKSkgewogCQkvKgotCQkgKiBObyBuZWVkIHRvIHRha2UgcG1k X2xvY2sgaGVyZSwgZXZlbiBpZiBzb21lIG90aGVyIHRocmVhZHMKKwkJICogTm8gbmVlZCB0byB0 YWtlIHBtZF9sb2NrIGhlcmUsIGV2ZW4gaWYgc29tZSBvdGhlciB0aHJlYWQKIAkJICogaXMgc3Bs aXR0aW5nIHRoZSBodWdlIHBtZCB3ZSB3aWxsIGdldCB0aGF0IGV2ZW50IHRocm91Z2gKIAkJICog bW11X25vdGlmaWVyIGNhbGxiYWNrLgogCQkgKgotCQkgKiBTbyBqdXN0IHJlYWQgcG1kIHZhbHVl IGFuZCBjaGVjayBhZ2FpbiBpdHMgYSB0cmFuc3BhcmVudAorCQkgKiBTbyBqdXN0IHJlYWQgcG1k IHZhbHVlIGFuZCBjaGVjayBhZ2FpbiBpdCdzIGEgdHJhbnNwYXJlbnQKIAkJICogaHVnZSBvciBk ZXZpY2UgbWFwcGluZyBvbmUgYW5kIGNvbXB1dGUgY29ycmVzcG9uZGluZyBwZm4KIAkJICogdmFs dWVzLgogCQkgKi8KQEAgLTY3NSw3ICs2NzEsNyBAQCBzdGF0aWMgaW50IGhtbV92bWFfd2Fsa19w bWQocG1kX3QgKnBtZHAsCiAJfQogCiAJLyoKLQkgKiBXZSBoYXZlIGhhbmRsZWQgYWxsIHRoZSB2 YWxpZCBjYXNlIGFib3ZlIGllIGVpdGhlciBub25lLCBtaWdyYXRpb24sCisJICogV2UgaGF2ZSBo YW5kbGVkIGFsbCB0aGUgdmFsaWQgY2FzZXMgYWJvdmUgaWUgZWl0aGVyIG5vbmUsIG1pZ3JhdGlv biwKIAkgKiBodWdlIG9yIHRyYW5zcGFyZW50IGh1Z2UuIEF0IHRoaXMgcG9pbnQgZWl0aGVyIGl0 IGlzIGEgdmFsaWQgcG1kCiAJICogZW50cnkgcG9pbnRpbmcgdG8gcHRlIGRpcmVjdG9yeSBvciBp dCBpcyBhIGJhZCBwbWQgdGhhdCB3aWxsIG5vdAogCSAqIHJlY292ZXIuCkBAIC03OTUsMTAgKzc5 MSwxMCBAQCBzdGF0aWMgaW50IGhtbV92bWFfd2Fsa19odWdldGxiX2VudHJ5KHB0ZV90ICpwdGUs IHVuc2lnbmVkIGxvbmcgaG1hc2ssCiAJcHRlX3QgZW50cnk7CiAJaW50IHJldCA9IDA7CiAKLQlz aXplID0gMVVMIDw8IGh1Z2VfcGFnZV9zaGlmdChoKTsKKwlzaXplID0gaHVnZV9wYWdlX3NpemUo aCk7CiAJbWFzayA9IHNpemUgLSAxOwogCWlmIChyYW5nZS0+cGFnZV9zaGlmdCAhPSBQQUdFX1NI SUZUKSB7Ci0JCS8qIE1ha2Ugc3VyZSB3ZSBhcmUgbG9va2luZyBhdCBmdWxsIHBhZ2UuICovCisJ CS8qIE1ha2Ugc3VyZSB3ZSBhcmUgbG9va2luZyBhdCBhIGZ1bGwgcGFnZS4gKi8KIAkJaWYgKHN0 YXJ0ICYgbWFzaykKIAkJCXJldHVybiAtRUlOVkFMOwogCQlpZiAoZW5kIDwgKHN0YXJ0ICsgc2l6 ZSkpCkBAIC04MDksOCArODA1LDcgQEAgc3RhdGljIGludCBobW1fdm1hX3dhbGtfaHVnZXRsYl9l bnRyeShwdGVfdCAqcHRlLCB1bnNpZ25lZCBsb25nIGhtYXNrLAogCQlzaXplID0gUEFHRV9TSVpF OwogCX0KIAotCi0JcHRsID0gaHVnZV9wdGVfbG9jayhoc3RhdGVfdm1hKHdhbGstPnZtYSksIHdh bGstPm1tLCBwdGUpOworCXB0bCA9IGh1Z2VfcHRlX2xvY2soaHN0YXRlX3ZtYSh2bWEpLCB3YWxr LT5tbSwgcHRlKTsKIAllbnRyeSA9IGh1Z2VfcHRlcF9nZXQocHRlKTsKIAogCWkgPSAoc3RhcnQg LSByYW5nZS0+c3RhcnQpID4+IHJhbmdlLT5wYWdlX3NoaWZ0OwpAQCAtODU5LDcgKzg1NCw3IEBA IHN0YXRpYyB2b2lkIGhtbV9wZm5zX2NsZWFyKHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLAogICog QHN0YXJ0OiBzdGFydCB2aXJ0dWFsIGFkZHJlc3MgKGluY2x1c2l2ZSkKICAqIEBlbmQ6IGVuZCB2 aXJ0dWFsIGFkZHJlc3MgKGV4Y2x1c2l2ZSkKICAqIEBwYWdlX3NoaWZ0OiBleHBlY3QgcGFnZSBz aGlmdCBmb3IgdGhlIHJhbmdlCi0gKiBSZXR1cm5zIDAgb24gc3VjY2VzcywgLUVGQVVMVCBpZiB0 aGUgYWRkcmVzcyBzcGFjZSBpcyBubyBsb25nZXIgdmFsaWQKKyAqIFJldHVybjogMCBvbiBzdWNj ZXNzLCAtRUZBVUxUIGlmIHRoZSBhZGRyZXNzIHNwYWNlIGlzIG5vIGxvbmdlciB2YWxpZAogICoK ICAqIFRyYWNrIHVwZGF0ZXMgdG8gdGhlIENQVSBwYWdlIHRhYmxlIHNlZSBpbmNsdWRlL2xpbnV4 L2htbS5oCiAgKi8KLS0gCjIuMjAuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs