From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 5/7] mm/hmm: make full use of walk_page_range() Date: Fri, 26 Jul 2019 15:12:27 +0000 Message-ID: <20190726151222.GA12280@mellanox.com> References: <20190726005650.2566-1-rcampbell@nvidia.com> <20190726005650.2566-6-rcampbell@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190726005650.2566-6-rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ralph Campbell Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Christoph Hellwig List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMjUsIDIwMTkgYXQgMDU6NTY6NDhQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwg d3JvdGU6DQo+IGhtbV9yYW5nZV9mYXVsdCgpIGNhbGxzIGZpbmRfdm1hKCkgYW5kIHdhbGtfcGFn ZV9yYW5nZSgpIGluIGEgbG9vcC4NCj4gVGhpcyBpcyB1bm5lY2Vzc2FyeSBkdXBsaWNhdGlvbiBz aW5jZSB3YWxrX3BhZ2VfcmFuZ2UoKSBjYWxscyBmaW5kX3ZtYSgpDQo+IGluIGEgbG9vcCBhbHJl YWR5Lg0KPiBTaW1wbGlmeSBobW1fcmFuZ2VfZmF1bHQoKSBieSBkZWZpbmluZyBhIHdhbGtfdGVz dCgpIGNhbGxiYWNrIGZ1bmN0aW9uDQo+IHRvIGZpbHRlciB1bmhhbmRsZWQgdm1hcy4NCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IFJhbHBoIENhbXBiZWxsIDxyY2FtcGJlbGxAbnZpZGlhLmNvbT4NCj4g Q2M6ICJKw6lyw7RtZSBHbGlzc2UiIDxqZ2xpc3NlQHJlZGhhdC5jb20+DQo+IENjOiBKYXNvbiBH dW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+DQo+IENjOiBDaHJpc3RvcGggSGVsbHdpZyA8aGNo QGxzdC5kZT4NCj4gIG1tL2htbS5jIHwgMTMwICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCA1NyBpbnNlcnRp b25zKCspLCA3MyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9tbS9obW0uYyBiL21t L2htbS5jDQo+IGluZGV4IDFiYzAxNGNkZGQ3OC4uODM4Y2QxZDUwNDk3IDEwMDY0NA0KPiArKysg Yi9tbS9obW0uYw0KPiBAQCAtODQwLDEzICs4NDAsNDQgQEAgc3RhdGljIGludCBobW1fdm1hX3dh bGtfaHVnZXRsYl9lbnRyeShwdGVfdCAqcHRlLCB1bnNpZ25lZCBsb25nIGhtYXNrLA0KPiAgI2Vu ZGlmDQo+ICB9DQo+ICANCj4gLXN0YXRpYyB2b2lkIGhtbV9wZm5zX2NsZWFyKHN0cnVjdCBobW1f cmFuZ2UgKnJhbmdlLA0KPiAtCQkJICAgdWludDY0X3QgKnBmbnMsDQo+IC0JCQkgICB1bnNpZ25l ZCBsb25nIGFkZHIsDQo+IC0JCQkgICB1bnNpZ25lZCBsb25nIGVuZCkNCj4gK3N0YXRpYyBpbnQg aG1tX3ZtYV93YWxrX3Rlc3QodW5zaWduZWQgbG9uZyBzdGFydCwNCj4gKwkJCSAgICAgdW5zaWdu ZWQgbG9uZyBlbmQsDQo+ICsJCQkgICAgIHN0cnVjdCBtbV93YWxrICp3YWxrKQ0KPiAgew0KPiAt CWZvciAoOyBhZGRyIDwgZW5kOyBhZGRyICs9IFBBR0VfU0laRSwgcGZucysrKQ0KPiAtCQkqcGZu cyA9IHJhbmdlLT52YWx1ZXNbSE1NX1BGTl9OT05FXTsNCj4gKwlzdHJ1Y3QgaG1tX3ZtYV93YWxr ICpobW1fdm1hX3dhbGsgPSB3YWxrLT5wcml2YXRlOw0KPiArCXN0cnVjdCBobW1fcmFuZ2UgKnJh bmdlID0gaG1tX3ZtYV93YWxrLT5yYW5nZTsNCj4gKwlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZt YSA9IHdhbGstPnZtYTsNCj4gKw0KPiArCS8qIElmIHJhbmdlIGlzIG5vIGxvbmdlciB2YWxpZCwg Zm9yY2UgcmV0cnkuICovDQo+ICsJaWYgKCFyYW5nZS0+dmFsaWQpDQo+ICsJCXJldHVybiAtRUJV U1k7DQo+ICsNCj4gKwkvKg0KPiArCSAqIFNraXAgdm1hIHJhbmdlcyB0aGF0IGRvbid0IGhhdmUg c3RydWN0IHBhZ2UgYmFja2luZyB0aGVtIG9yDQo+ICsJICogbWFwIEkvTyBkZXZpY2VzIGRpcmVj dGx5Lg0KPiArCSAqIFRPRE86IGhhbmRsZSBwZWVyLXRvLXBlZXIgZGV2aWNlIG1hcHBpbmdzLg0K PiArCSAqLw0KPiArCWlmICh2bWEtPnZtX2ZsYWdzICYgKFZNX0lPIHwgVk1fUEZOTUFQIHwgVk1f TUlYRURNQVApKQ0KPiArCQlyZXR1cm4gLUVGQVVMVDsNCj4gKw0KPiArCWlmIChpc192bV9odWdl dGxiX3BhZ2Uodm1hKSkgew0KPiArCQlpZiAoaHVnZV9wYWdlX3NoaWZ0KGhzdGF0ZV92bWEodm1h KSkgIT0gcmFuZ2UtPnBhZ2Vfc2hpZnQgJiYNCj4gKwkJICAgIHJhbmdlLT5wYWdlX3NoaWZ0ICE9 IFBBR0VfU0hJRlQpDQo+ICsJCQlyZXR1cm4gLUVJTlZBTDsNCj4gKwl9IGVsc2Ugew0KPiArCQlp ZiAocmFuZ2UtPnBhZ2Vfc2hpZnQgIT0gUEFHRV9TSElGVCkNCj4gKwkJCXJldHVybiAtRUlOVkFM Ow0KPiArCX0NCj4gKw0KPiArCS8qDQo+ICsJICogSWYgdm1hIGRvZXMgbm90IGFsbG93IHJlYWQg YWNjZXNzLCB0aGVuIGFzc3VtZSB0aGF0IGl0IGRvZXMgbm90DQo+ICsJICogYWxsb3cgd3JpdGUg YWNjZXNzLCBlaXRoZXIuIEhNTSBkb2VzIG5vdCBzdXBwb3J0IGFyY2hpdGVjdHVyZXMNCj4gKwkg KiB0aGF0IGFsbG93IHdyaXRlIHdpdGhvdXQgcmVhZC4NCj4gKwkgKi8NCj4gKwlpZiAoISh2bWEt PnZtX2ZsYWdzICYgVk1fUkVBRCkpDQo+ICsJCXJldHVybiAtRVBFUk07DQo+ICsNCj4gKwlyZXR1 cm4gMDsNCj4gIH0NCj4gIA0KPiAgLyoNCj4gQEAgLTk2NSw4MiArOTk2LDM1IEBAIEVYUE9SVF9T WU1CT0woaG1tX3JhbmdlX3VucmVnaXN0ZXIpOw0KPiAgICovDQo+ICBsb25nIGhtbV9yYW5nZV9m YXVsdChzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZSwgdW5zaWduZWQgaW50IGZsYWdzKQ0KPiAgew0K PiAtCWNvbnN0IHVuc2lnbmVkIGxvbmcgZGV2aWNlX3ZtYSA9IFZNX0lPIHwgVk1fUEZOTUFQIHwg Vk1fTUlYRURNQVA7DQo+IC0JdW5zaWduZWQgbG9uZyBzdGFydCA9IHJhbmdlLT5zdGFydCwgZW5k Ow0KPiAtCXN0cnVjdCBobW1fdm1hX3dhbGsgaG1tX3ZtYV93YWxrOw0KPiArCXVuc2lnbmVkIGxv bmcgc3RhcnQgPSByYW5nZS0+c3RhcnQ7DQo+ICsJc3RydWN0IGhtbV92bWFfd2FsayBobW1fdm1h X3dhbGsgPSB7fTsNCj4gIAlzdHJ1Y3QgaG1tICpobW0gPSByYW5nZS0+aG1tOw0KPiAtCXN0cnVj dCB2bV9hcmVhX3N0cnVjdCAqdm1hOw0KPiAtCXN0cnVjdCBtbV93YWxrIG1tX3dhbGs7DQo+ICsJ c3RydWN0IG1tX3dhbGsgbW1fd2FsayA9IHt9Ow0KPiAgCWludCByZXQ7DQo+ICANCj4gIAlsb2Nr ZGVwX2Fzc2VydF9oZWxkKCZobW0tPm1tLT5tbWFwX3NlbSk7DQo+ICANCj4gLQlkbyB7DQo+IC0J CS8qIElmIHJhbmdlIGlzIG5vIGxvbmdlciB2YWxpZCBmb3JjZSByZXRyeS4gKi8NCj4gLQkJaWYg KCFyYW5nZS0+dmFsaWQpDQo+IC0JCQlyZXR1cm4gLUVCVVNZOw0KPiArCWhtbV92bWFfd2Fsay5y YW5nZSA9IHJhbmdlOw0KPiArCWhtbV92bWFfd2Fsay5sYXN0ID0gc3RhcnQ7DQo+ICsJaG1tX3Zt YV93YWxrLmZsYWdzID0gZmxhZ3M7DQo+ICsJbW1fd2Fsay5wcml2YXRlID0gJmhtbV92bWFfd2Fs azsNCj4gIA0KPiAtCQl2bWEgPSBmaW5kX3ZtYShobW0tPm1tLCBzdGFydCk7DQo+IC0JCWlmICh2 bWEgPT0gTlVMTCB8fCAodm1hLT52bV9mbGFncyAmIGRldmljZV92bWEpKQ0KPiAtCQkJcmV0dXJu IC1FRkFVTFQ7DQoNCkl0IGlzIGhhcmQgdG8gdGVsbCB3aGF0IGlzIGEgY29uZnVzZWQvd3Jvbmcg YW5kIHdoYXQgaXMgZGVsaWJlcmF0ZSBpbg0KdGhpcyBjb2RlLi4uDQoNCkN1cnJlbnRseSB0aGUg aG1tX3JhbmdlX2ZhdWx0IGludm9rZXMgd2Fsa19wYWdlX3JhbmdlIG9uIGEgVk1BIGJ5IFZNQQ0K YmFzaXMsIGFuZCB0aGUgYWJvdmUgcHJldmVudHMgc29tZSBjYXNlcyBvZiB3YWxrLT52bWEgYmVj b21pbmcNCk5VTEwsIGJ1dCBub3QgYWxsIC0gZm9yIGluc3RhbmNlIGl0IGRvZXNuJ3QgY2hlY2sg Zm9yIHN0YXJ0IDwgdm1hLT52bV9zdGFydC4NCg0KSG93ZXZlciwgY2hlY2tpbmcgaWYgaXQgY2Fu IGFjdHVhbGx5IHRvbGVyYXRlIHRoZSB3YWxrLT52bWEgPT0gTlVMTCBpdA0KbG9va3MgbGlrZSBu bzoNCg0KIHdhbGtfcGFnZV9yYW5nZQ0KICBmaW5kX3ZtYSA9PSBOVUxMIHx8IHN0YXJ0IDwgdm1f c3RhcnQgLT4gd2Fsay0+dm1hID09IE5VTEwNCiAgX193YWxrX3BhZ2VfcmFuZ2UNCiAgICB3YWxr X3BnZF9yYW5nZQ0KICAgICAgcHRlX2hvbGUgLyBobW1fdm1hX3dhbGtfaG9sZQ0KICAgICAgICBo bW1fdm1hX3dhbGtfaG9sZV8NCiAgICAgICAgIGhtbV92bWFfZG9fZmF1bHQNCiAgICAgICAgICAg IGhhbmRsZV9tbV9mYXVsdCh3YWxrLT52bWEsIGFkZHIsIGZsYWdzKQ0KICAgICAgICAgICAgICB2 bWEtPnZtX21tIDwtLSBPT1BTDQoNCldoaWNoIGtpbmQgb2Ygc3VnZ2VzdHMgdGhlIGZpbmRfdm1h IGFib3ZlIHdhcyBhYm91dCBwcmV2ZW50aW5nDQp3YWxrLT52bWEgPT0gTlVMTD8gRG9lcyBzb21l dGhpbmcgZWxzZSB0cmlja3kgcHJldmVudCB0aGlzPw0KDQpUaGlzIHBhdGNoIGFsc28gY2hhbmdl cyBiZWhhdmlvciBzbyB0aGF0IG1pc3NpbmcgVk1BcyBkb24ndCBhbHdheXMNCnRyaWdnZXIgRUZB VUxUICh3aGljaCBpcyBhIGdvb2QgdGhpbmcsIGJ1dCBuZWVkcyB0byBiZSBpbiB0aGUgY29tbWl0 DQptZXNzYWdlKQ0KDQpJIHN0cm9uZ2x5IGJlbGlldmUgdGhpcyBpcyB0aGUgY29ycmVjdCBkaXJl Y3Rpb24gdG8gZ28gaW4sIGFuZCB0aGUgZmFjdA0KdGhhdCB0aGlzIGZ1bmN0aW9uIHJldHVybnMg RUZBVUxUIGlmIHRoZXJlIGlzIG5vIFZNQS9pbmNvbXBhdGlibGUgVk1BDQppcyBhY3R1YWxseSBh IHNlbWFudGljIGJ1ZyB3ZSBuZWVkIHRvIGZpeCBiZWZvcmUgaXQgaXMgYSB1c2FibGUgQVBJLg0K DQpJZSBjb25zaWRlciB0aGUgdXNlciBkb2VzIHNvbWV0aGluZyBsaWtlDQogIHB0ciA9IG1tYXAo MCwgUEFHRV9TSVpFIC4uKQ0KICBtciA9IGliX3JlZ19tcihwdHIgLSBQQUdFX1NJWkUsIHB0ciAr IDMqUEFHRV9TSVpFLCBJQlZfQUNDRVNTX09OX0RFTUFORCkNCg0KVGhlbiBpbiB0aGUga2VybmVs IEkgd2FudCB0byBkbyBobW1fcmFuZ2VfZmF1bHQoSE1NX0ZBVUxUX1NOQVBTSE9UKQ0KYWNyb3Nz IHRoZSBNUiBWQSBhbmQgZ2V0IGEgcGZucyBhcnJheSB0aGF0IHNheXMgUEFHRSAwIGlzIEZBVUxU LCBQQUdFDQoxIGlzIFIvVywgUEFHRSAyIGlzIEZBVUxULg0KDQpJbnN0ZWFkIHRoZSBlbnRpcmUg Y2FsbCBmYWlscyBiZWNhdXNlIHRoZXJlIGlzIG5vIFZNQSBhdCB0aGUgc3RhcnRpbmcNCm9mZnNl dCwgb3IgdGhlIFZNQSBoYWQgdGhlIHdyb25nIGZsYWdzLCBvciBzb21ldGhpbmcuDQoNCldoYXQg aXQgc2hvdWxkIGRvIGlzIHBvcHVsYXRlIHRoZSByZXN1bHQgd2l0aCBGQVVMVCBmb3IgdGhlIGdh cCBwYXJ0DQpvZiB0aGUgVkEgcmFuZ2UgYW5kIGNvbnRpbnVlIHRvIHRoZSBuZXh0IFZNQS4NCg0K VGhlIHNhbWUgY29tbWVudCBhcHBsaWVzIHRvIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgd2Fs a2VyIHRlc3QNCmZ1bmN0aW9uLCBpdCBzaG91bGQgcmV0dXJuIDEgdG8gc2tpcCB0aGUgVk1BIGFu ZCBmaWxsIFBGTlMgd2l0aCBGQVVMVA0Kd2hlbiB0aGVyZSBpcyBhIG1pc21hdGNoIFZNQSwgbm90 IGZhaWwgZW50aXJlbHkuDQoNClBlcmhhcHMgdGhlcmUgd2FzIHNvbWUgdGhvdWdodCB0aGF0IHRo ZSBmYXVsdCB2ZXJzaW9uIHNob3VsZCBmYWlsIHRvDQp0ZWxsIHRoZSBwYWdlZmF1bHQgaGFuZGxl ciB0aGVyZSBpcyBub3RoaW5nIHRvIERNQSwgYnV0IGV2ZW4gdGhhdCBpcw0Kbm90IGVudGlyZWx5 IGRlc2lyYWJsZSwgSSdkIGxpa2UgdG8gaGF2ZSAnZmF1bHQgYXJvdW5kJyBzZW1hbnRpY3MsIGlm DQp3ZSBhcmUgZ29pbmcgdG8gYWxsIHRoZSB3b3JrIG9mIGRvaW5nIGEgZmV3IFBURXMsIGxldHMg ZG8gYSBjaHVuay4gSQ0Kb25seSBjYXJlIGlmIHRoZSBjcml0aWNhbCBwYWdlKHMpIHRyaWdnZXJp bmcgdGhlIGZhdWx0IGNvdWxkbid0IGJlDQpmYXVsdGVkIGluLCB0aGUgb3RoZXJzIGNhbiByZW1h aW4gYXMgcGZuIEZBVUxULg0KDQpUbyBwcm9jZWVkIHdpdGggdGhpcyBwYXRjaCB3ZSBuZWVkIHRv IGNvbmZpcm0vZGVueSB0aGUgYWJvdmUgdHJhY2UuIEkNCnRoaW5rIGl0IHByb2JhYmx5IGNhbiBi ZSBmaXhlZCBlYXNpbHkgKGFzIGFub3RoZXIgcGF0Y2gpIGJ5IGNoZWNraW5nDQpmb3Igd2Fsay0+ dm1hID09IE5VTEwgaW4gdGhlIHJpZ2h0IHBsYWNlcy4NCg0KSSByZWFsbHkgd291bGQgbGlrZSB0 byBzZWUgYSB0ZXN0IGZvciB0aGlzIGZ1bmN0aW9uIHRvbyA6KCBJdCBoYXMgbG90cw0KYW5kIGxv dHMgb2YgZWRnZSBjYXNlcyB0aGF0IG5lZWQgdGhlIGJlIGNvbXByZWhlbnNpdmVseSBleHBsb3Jl ZA0KYmVmb3JlIHdlIGNhbiBjYWxsIHRoaXMgd29ya2luZy4uDQoNCkphc29uDQpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlz dApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXU=