From mboxrd@z Thu Jan 1 00:00:00 1970 From: Torsten Duwe Subject: Re: [PATCH v3 6a/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Date: Mon, 29 Jul 2019 16:22:58 +0200 Message-ID: <20190729142258.GB7946@lst.de> References: <20190722150414.9F97668B20@verein.lst.de> <20190725151829.DC20968B02@verein.lst.de> <20190726163601.o32bxqew5xavjgyi@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190726163601.o32bxqew5xavjgyi@flea> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Maxime Ripard Cc: Chen-Yu Tsai , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Fri, Jul 26, 2019 at 06:36:01PM +0200, Maxime Ripard wrote: > > + > > + dvdd12-supply: > > + maxItems: 1 > > + description: Regulator for 1.2V digital core power. > > + $ref: /schemas/types.yaml#/definitions/phandle > > + > > + dvdd25-supply: > > + maxItems: 1 > > + description: Regulator for 2.5V digital core power. > > + $ref: /schemas/types.yaml#/definitions/phandle > > There's no need to specify the type here, all the properties ending in > -supply are already checked for that type Ok, thanks for the hint. > > + ports: > > + type: object > > + minItems: 1 > > + maxItems: 2 > > + description: | > > + Video port 0 for LVTTL input, > > + Video port 1 for eDP output (panel or connector) > > + using the DT bindings defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt > > You should probably describe the port@0 and port@1 nodes here as > well. It would allow you to express that the port 0 is mandatory and > the port 1 optional, which got dropped in the conversion. I would have liked to, but have not discovered yet a comprehensive source of information about recommended syntax and semantics of the YAML schemes. Is there some central reference for these types of issues? I mean not the "here is a git repo with the meta-schemes" but sort of a cookbook? Torsten