From: Sam Ravnborg <sam@ravnborg.org>
To: Brian Welty <brian.welty@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 1/3] drm: introduce new struct drm_mem_region
Date: Mon, 29 Jul 2019 19:55:06 +0200 [thread overview]
Message-ID: <20190729175506.GC1753@ravnborg.org> (raw)
In-Reply-To: <20190729165457.18500-2-brian.welty@intel.com>
Hi Brian.
Small nit below - did not try to understand your patch.
Sam
> diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
> index 2c3bbb43c7d1..3d123eb10d62 100644
> --- a/include/drm/drm_mm.h
> +++ b/include/drm/drm_mm.h
> @@ -43,6 +43,8 @@
> #include <linux/mm_types.h>
> #include <linux/list.h>
> #include <linux/spinlock.h>
> +#include <linux/dma-fence.h>
> +#include <linux/io-mapping.h>
Keep include files sorted.
> #ifdef CONFIG_DRM_DEBUG_MM
> #include <linux/stackdepot.h>
> #endif
> @@ -54,6 +56,31 @@
> #define DRM_MM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr)
> #endif
>
> +struct drm_device;
> +struct drm_mm;
Likewise forwards. But they are good here.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-29 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:54 [RFC PATCH 0/3] Propose new struct drm_mem_region Brian Welty
2019-07-29 16:54 ` [RFC PATCH 1/3] drm: introduce " Brian Welty
2019-07-29 17:55 ` Sam Ravnborg [this message]
2019-07-29 16:54 ` [RFC PATCH 2/3] drm: Introduce DRM_MEM defines for specifying type of drm_mem_region Brian Welty
2019-07-29 16:54 ` [RFC PATCH 3/3] drm/i915: Update intel_memory_region to use nested drm_mem_region Brian Welty
-- strict thread matches above, loose matches on Subject: below --
2019-07-30 0:32 [RFC PATCH 0/3] Propose new struct drm_mem_region Brian Welty
[not found] ` <20190730003225.322-1-brian.welty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-07-30 0:32 ` [RFC PATCH 1/3] drm: introduce " Brian Welty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729175506.GC1753@ravnborg.org \
--to=sam@ravnborg.org \
--cc=brian.welty@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox