From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i810: Use CONFIG_PREEMPTION
Date: Wed, 31 Jul 2019 17:05:35 +0200 [thread overview]
Message-ID: <20190731150535.GJ7444@phenom.ffwll.local> (raw)
In-Reply-To: <alpine.DEB.2.21.1907262223280.1791@nanos.tec.linutronix.de>
On Fri, Jul 26, 2019 at 10:25:20PM +0200, Thomas Gleixner wrote:
> CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by
> CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same
> functionality which today depends on CONFIG_PREEMPT.
>
> Change the Kconfig dependency of i810 to !CONFIG_PREEMPTION so the driver
> is not accidentally built on a RT kernel.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Queued up, should land in -rc3 or so.
Thanks, Daniel
> ---
> drivers/gpu/drm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -394,7 +394,7 @@ config DRM_R128
> config DRM_I810
> tristate "Intel I810"
> # !PREEMPT because of missing ioctl locking
> - depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN)
> + depends on DRM && AGP && AGP_INTEL && (!PREEMPTION || BROKEN)
> help
> Choose this option if you have an Intel I810 graphics card. If M is
> selected, the module will be called i810. AGP support is required
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-07-31 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 20:25 [PATCH] drm/i810: Use CONFIG_PREEMPTION Thomas Gleixner
2019-07-26 22:07 ` Daniel Vetter
2019-07-26 22:52 ` Thomas Gleixner
2019-07-31 15:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731150535.GJ7444@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox