From: Sam Ravnborg <sam@ravnborg.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups
Date: Thu, 1 Aug 2019 16:59:22 +0200 [thread overview]
Message-ID: <20190801145922.GA30758@ravnborg.org> (raw)
In-Reply-To: <20190730133857.30778-1-hdegoede@redhat.com>
Hi Hans.
On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote:
> 3 small cleanups:
>
> 1) Drop unused DRIVER_PATCHLEVEL
> 2) We do not set mode_config.preferred_depth, so instead of passing the
> unset mode_config.preferred_depth to drm_fbdev_generic_setup
> simply pass 0
> 3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend /
> resume functions
>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Suggested-by: Sam Ravnborg <sam@ravnborg.org>
If you add:
Suggested-by: Noralf Trønnes <noralf@tronnes.org>
And adjust to the new location.
Then this is:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-01 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 13:38 [PATCH 1/2] drm: gm12u320: Some minor cleanups Hans de Goede
2019-07-30 13:38 ` [PATCH 2/2] drm: gm12u320: Use DRM_DEV_ERROR everywhere Hans de Goede
2019-08-01 14:59 ` Sam Ravnborg
2019-08-01 14:59 ` Sam Ravnborg [this message]
2019-08-11 13:47 ` [PATCH 1/2] drm: gm12u320: Some minor cleanups Hans de Goede
2019-08-12 19:33 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801145922.GA30758@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=maxime.ripard@bootlin.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox