From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v3 1/1] drm/vblank: drop use of DRM_WAIT_ON() Date: Sat, 3 Aug 2019 16:33:40 +0200 Message-ID: <20190803143340.GA21315@ravnborg.org> References: <20190726210658.GA6299@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190726210658.GA6299@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: Maxime Ripard , David Airlie , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgYWxsLgoKT24gRnJpLCBKdWwgMjYsIDIwMTkgYXQgMTE6MDY6NThQTSArMDIwMCwgU2FtIFJh dm5ib3JnIHdyb3RlOgo+IERSTV9XQUlUX09OKCkgaXMgZnJvbSB0aGUgZGVwcmVjYXRlZCBkcm1f b3NfbGludXggaGVhZGVyIGFuZAo+IHRoZSBtb2Rlcm4gcmVwbGFjZW1lbnQgaXMgdGhlIHdhaXRf ZXZlbnRfKi4KPiAKPiBUaGUgcmV0dXJuIHZhbHVlcyBkaWZmZXIsIHNvIGEgY29udmVyc2lvbiBp cyBuZWVkZWQgdG8KPiBrZWVwIHRoZSBvcmlnaW5hbCBpbnRlcmZhY2UgdG93YXJkcyB1c2Vyc3Bh Y2UuCj4gSW50cm9kdWNlZCBhIHN3aXRjaC9jYXNlIHRvIG1ha2UgY29kZSBvYnZpb3VzLgoKUGF0 Y2ggcGFzc2VzIGlndCB0ZXN0aW5nLCBhbmQgTWljaGVsIHdhcyBoYXBweSB3aXRoIGl0LgpJdCBp cyBub3cgYXBwbGllZCB0byBkcm0tbWlzYy1uZXh0IGFuZCBwdXNoZWQgb3V0LgoKV2l0aCB0aGlz IHdlIGhhdmUgb25lIGxlc3MgdXNlciBvZiBkcm1fb3NfbGludXguaAoob25seSB2ZXJ5IGZldyBy ZW1haW5zKQoKQW5kIG9uZSBsZXNzIGNyeXB0aWMgbWFjcm8gdXNlLgoKCVNhbQoKPiAKPiBBbmFs eXNpcyBmcm9tIE1pY2hlbCBEw6RuemVyOgo+IAo+IFRoZSB3YWl0aW5nIGNvbmRpdGlvbiByZWx5 IG9uIGFsbCByZWxldmFudCBwbGFjZXMgd2hlcmUgdmJsYW5rX2NvdW50Cj4gaXMgbW9kaWZpZWQg Y2FsbHMgd2FrZV91cCgmdmJsYW5rLT5xdWV1ZSkuCj4gCj4gZHJtX2hhbmRsZV92YmxhbmsoKToK PiAtIENhbGxzIHdha2VfdXAoJnZibGFuay0+cXVldWUpCj4gCj4gZHJtX3ZibGFua19lbmFibGUo KToKPiAtIFRoZXJlIGlzIG5vIG5lZWQgaGVyZSBiZWNhdXNlIHRoZXJlIGNhbiBiZSBubyBzbGVl cGluZyB3YWl0ZXJzCj4gICBpbiB0aGUgcXVldWUsIGJlY2F1c2UgdmJsYW5rLT5lbmFibGVkID09 IGZhbHNlIGltbWVkaWF0ZWx5Cj4gICB0ZXJtaW5hdGVzIGFueSB3YWl0cy4KPiAKPiBkcm1fY3J0 Y19hY2N1cmF0ZV92YmxhbmtfY291bnQoKToKPiAtIFRoaXMgaXMgY2FsbGVkIGZyb20gaW50ZXJy dXB0IGhhbmRsZXJzLCBhdCBsZWFzdCBmcm9tCj4gICBhbWRncHVfZG0uYzpkbV9wZmxpcF9oaWdo X2lycSgpLiBOb3Qgc3VyZSBpdCBuZWVkcyB0byB3YWtlIHVwCj4gICB0aGUgcXVldWUgdGhvdWdo LCB0aGUgZHJpdmVyIHNob3VsZCBjYWxsCj4gICBkcm1fKGNydGNfKV9oYW5kbGVfdmJsYW5rIGFu eXdheS4KPiAKPiBkcm1fdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoKToKPiAtIEl0IGNhbiBiZSBj YWxsZWQgZnJvbSBhbiBpbnRlcnJ1cHQsIHZpYSBkcm1faGFuZGxlX3ZibGFuayAtPgo+ICAgdmJs YW5rX2Rpc2FibGVfZm4uIEhvd2V2ZXIsIHRoZSBvbmx5IHBsYWNlIHdoZXJlCj4gICBkcm1fdmJs YW5rX2Rpc2FibGVfYW5kX3NhdmUgY2FuIGJlIGNhbGxlZCB3aXRoIHNsZWVwaW5nIHdhaXRlcnMK PiAgIGluIHRoZSBxdWV1ZSBpcyBpbiBkcm1fY3J0Y192Ymxhbmtfb2ZmLCB3aGljaCB3YWtlcyB1 cCB0aGUgcXVldWUKPiAgIGFmdGVyd2FyZHMgKHdoaWNoIHRlcm1pbmF0ZXMgYWxsIHdhaXRzLCBi ZWNhdXNlCj4gICB2YmxhbmstPmVuYWJsZWQgPT0gZmFsc2UgYXQgdGhpcyBwb2ludCkuCj4gCj4g djM6Cj4gLSBBZGRlZCBhbmFseXNpcyB0byBjaGFuZ2Vsb2cgZnJvbSBNaWNoZWwgRMOkbnplcgo+ IC0gTW92ZWQgcmV0dXJuIHJlc3VsdCBoYW5kbGluZyBpbnNpZGUgaWYgKHJlcV9zZXEgIT0gc2Vx KSAoRGFuaWVsIFYpCj4gLSBSZXVzZWQgbW9yZSBvZiB0aGUgZm9ybWVyIGxvZ2ljIC0gcmVzdWx0 aW5nIGluIHNpbXBsZXIgY29kZQo+IC0gRHJvcHBlZCBSZXZpZXdlZC1ieSBmcm9tIFNlYW4gUGF1 bCBhcyB0aGlzIGlzIGEgbmV3IGltcGxtZW50YXRpb24KPiAKPiB2MjoKPiAtIEZpeCBzbyB0aGUg Y2FzZSB3aGVyZSByZXFfc2VxIGVxdWFscyBzZXEgd2FzIGhhbmRsZWQgcHJvcGVybHkKPiAtIHF1 aWNrIGhhY2sgdG8gY2hlY2sgaWYgSUdUIGJlY2FtZSBoYXBweQo+IC0gT25seSBzZW50IHRvIGln dCwgbm90IHRvIGRyaS1kZXZlbAo+IAo+IFNpZ25lZC1vZmYtYnk6IFNhbSBSYXZuYm9yZyA8c2Ft QHJhdm5ib3JnLm9yZz4KPiBDYzogIk1pY2hlbCBEw6RuemVyIiA8bWljaGVsQGRhZW56ZXIubmV0 Pgo+IENjOiBTZWFuIFBhdWwgPHNlYW5AcG9vcmx5LnJ1bj4KPiBDYzogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF4aW1lIFJpcGFy ZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVk QGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gLS0tCj4g Cj4gVGhpcyBwYXRjaCBzdXJ2aXZlcyBteSB0ZXN0aW5nIGhlcmUuCj4gdmJsdGVzdCBzcGl0cyBv dXQgdGhlIHNhbWUgdmFsdWUgYXMgYmVmb3JlLCBhbmQgSSBjYW4gc2VlIHNvbWV0aGluZyBvbgo+ IHRoZSBzY3JlZW4uCj4gQWRkZWQgaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZywgYXMg SUdUIGhhdmUgaWRlbnRpZmllZCB0cm91Ymxlcwo+IHdpdGggdGhpcyBpbiB2MS4KPiAKPiAJU2Ft Cj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fdmJsYW5rLmMgfCAyNSArKysrKysrKysrKysrKysr KysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ZibGFuay5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV92YmxhbmsuYwo+IGluZGV4IDYwM2FiMTA1MTI1ZC4uZmQxZmJjNzc4 NzFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fdmJsYW5rLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX3ZibGFuay5jCj4gQEAgLTMxLDcgKzMxLDYgQEAKPiAgI2luY2x1 ZGUgPGRybS9kcm1fZHJ2Lmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2ZyYW1lYnVmZmVyLmg+Cj4g ICNpbmNsdWRlIDxkcm0vZHJtX3ByaW50Lmg+Cj4gLSNpbmNsdWRlIDxkcm0vZHJtX29zX2xpbnV4 Lmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX3ZibGFuay5oPgo+ICAKPiAgI2luY2x1ZGUgImRybV9p bnRlcm5hbC5oIgo+IEBAIC0xNjcwLDEyICsxNjY5LDI4IEBAIGludCBkcm1fd2FpdF92Ymxhbmtf aW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCX0KPiAgCj4gIAlp ZiAocmVxX3NlcSAhPSBzZXEpIHsKPiArCQlpbnQgd2FpdDsKPiArCj4gIAkJRFJNX0RFQlVHKCJ3 YWl0aW5nIG9uIHZibGFuayBjb3VudCAlbGx1LCBjcnRjICV1XG4iLAo+ICAJCQkgIHJlcV9zZXEs IHBpcGUpOwo+IC0JCURSTV9XQUlUX09OKHJldCwgdmJsYW5rLT5xdWV1ZSwgMyAqIEhaLAo+IC0J CQkgICAgdmJsYW5rX3Bhc3NlZChkcm1fdmJsYW5rX2NvdW50KGRldiwgcGlwZSksCj4gLQkJCQkJ ICByZXFfc2VxKSB8fAo+IC0JCQkgICAgIVJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpKTsKPiAr CQl3YWl0ID0gd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlX3RpbWVvdXQodmJsYW5rLT5xdWV1ZSwK PiArCQkJdmJsYW5rX3Bhc3NlZChkcm1fdmJsYW5rX2NvdW50KGRldiwgcGlwZSksIHJlcV9zZXEp IHx8Cj4gKwkJCQkgICAgICAhUkVBRF9PTkNFKHZibGFuay0+ZW5hYmxlZCksCj4gKwkJCW1zZWNz X3RvX2ppZmZpZXMoMzAwMCkpOwo+ICsKPiArCQlzd2l0Y2ggKHdhaXQpIHsKPiArCQljYXNlIDA6 Cj4gKwkJCS8qIHRpbWVvdXQgKi8KPiArCQkJcmV0ID0gLUVCVVNZOwo+ICsJCQlicmVhazsKPiAr CQljYXNlIC1FUkVTVEFSVFNZUzoKPiArCQkJLyogaW50ZXJydXB0ZWQgYnkgc2lnbmFsICovCj4g KwkJCXJldCA9IC1FSU5UUjsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJcmV0ID0g MDsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICAJfQo+ICAKPiAgCWlmIChyZXQgIT0gLUVJTlRSKSB7 Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeA==