From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCHv2 2/3] i915: convert to new mount API Date: Tue, 6 Aug 2019 10:20:27 +0900 Message-ID: <20190806012027.GA6149@jagdpanzerIV> References: <20190805160307.5418-1-sergey.senozhatsky@gmail.com> <20190805160307.5418-3-sergey.senozhatsky@gmail.com> <20190805181255.GH1131@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190805181255.GH1131@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Al Viro Cc: Sergey Senozhatsky , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Chris Wilson , David Howells , Christoph Hellwig , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On (08/05/19 19:12), Al Viro wrote: [..] > On Tue, Aug 06, 2019 at 01:03:06AM +0900, Sergey Senozhatsky wrote: > > tmpfs does not set ->remount_fs() anymore and its users need > > to be converted to new mount API. > > Could you explain why the devil do you bother with remount at all? I would redirect this question to i915 developers. As far as I know i915 performance suffers with huge pages enabled. > Why not pass the right options when mounting the damn thing? vfs_kern_mount()? It still requires struct file_system_type, which we need to get and put. -ss