From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Sean Paul <sean@poorly.run>, Maxime Ripard <mripard@kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH 2/2] Revert "drm/panfrost: Use drm_gem_map_offset()"
Date: Wed, 7 Aug 2019 22:59:52 +0200 [thread overview]
Message-ID: <20190807205952.GE7444@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo50K+Wy3HAmVud8+Rvotm86vaqen1yPaO6gsUjc3K5BwSg@mail.gmail.com>
On Wed, Aug 07, 2019 at 04:59:51PM +0100, Emil Velikov wrote:
> On Wed, 7 Aug 2019 at 15:53, Sean Paul <sean@poorly.run> wrote:
> >
> > From: Rob Herring <robh@kernel.org>
> >
> > This reverts commit 583bbf46133c726bae277e8f4e32bfba2a528c7f.
> >
> > Turns out we need mmap to work on imported BOs even if the current code
> > is buggy.
> >
> Personally I would have mentioned a use case where imported BOs are used.
>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Sean Paul <sean@poorly.run>
>
> Regardless of the above nitpick, with the patch order fixed the series is:
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
>
> ... in case you haven't picked it already.
Yeah a follow-up patch to add a comment here about why exactly this went
all kaboom, plus which userspace (since panfrost is moving fast) would be
real nice here.
Atm we need to hope someone does a git blame on this before the break this
again, which seems a bit hopeful ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-07 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 14:52 [PATCH 0/2] drm/panfrost: Revert drm_gem_map_offset changes Sean Paul
2019-08-07 14:52 ` [PATCH 1/2] Revert "drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset()" Sean Paul
2019-08-07 21:01 ` Daniel Vetter
2019-08-07 22:33 ` Rob Herring
2019-08-07 14:52 ` [PATCH 2/2] Revert "drm/panfrost: Use drm_gem_map_offset()" Sean Paul
2019-08-07 15:59 ` Emil Velikov
2019-08-07 20:59 ` Daniel Vetter [this message]
2019-08-07 14:54 ` [PATCH 0/2] drm/panfrost: Revert drm_gem_map_offset changes Sean Paul
2019-08-07 16:00 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807205952.GE7444@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=emil.velikov@collabora.com \
--cc=mripard@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox