Re: [PATCH v2 0/9] DRM panel drivers for omapdrm

Sam Ravnborg
2019-08-11T17:23:04Z

Hi Laurent.

On Sun, Aug 11, 2019 at 02:10:39AM +0300, Laurent Pinchart wrote:
> Hello everybody,
>
> These 9 patches have initially been posted as part of the larger "[PATCH
> 00/60] drm/omap: Replace custom display drivers with drm_bridge and
> drm_panel" series, hence the v2 in the subject prefix.
>
> I'm posting this second version separately per Sam's request as the rest
> of the original series is expected to take more time to process through
> review.
Thanks, make good sense (to me) that we process these now while waiting
for the dust to settel on the other more invasive patches.

>
> There's nothing very special here. The first three patches add DT vendor
> prefixes and DT bindings. Since v1 patch 3/9 has been converted from
> text to YAML, and as I'm not very familiar with YAML DT bindings, I'm
> eagerly waiting for reviews.
>
> The last six patches add new panel drivers. The code originates from the
> corresponding omapdrm-specific panel drivers, which explains why only
> one new DT binding is needed as most of them are already present.
>
> Please see individual patches for changelogs. Sam, I believe I've taken
> all your comments into account, I hope none fell through the cracks.
I have been through the patches - all looked good.
One generel comment about drm_panel_remove().

The DT for the NEC NL8048HL11 needs to be reviewed, and then we can
land all patches in one go.
Unless someone else put some review effort in and find something.

Sam

>
> The patches are based on top of drm-misc-next and can be found at
>
> git://linuxtv.org/pinchartl/media.git omapdrm/panels
>
> Laurent Pinchart (9):
> dt-bindings: Add vendor prefix for LG Display
> dt-bindings: Add legacy 'toppoly' vendor prefix
> dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
> drm/panel: Add driver for the LG Philips LB035Q02 panel
> drm/panel: Add driver for the NEC NL8048HL11 panel
> drm/panel: Add driver for the Sharp LS037V7DW01 panel
> drm/panel: Add driver for the Sony ACX565AKM panel
> drm/panel: Add driver for the Toppoly TD028TTEC1 panel
> drm/panel: Add driver for the Toppoly TD043MTEA1 panel
>
> .../display/panel/nec,nl8048hl11.yaml | 49 ++
> .../devicetree/bindings/vendor-prefixes.yaml | 5 +
> drivers/gpu/drm/panel/Kconfig | 46 ++
> drivers/gpu/drm/panel/Makefile | 6 +
> drivers/gpu/drm/panel/panel-lg-lb035q02.c | 237 ++++++
> drivers/gpu/drm/panel/panel-nec-nl8048hl11.c | 247 +++++++
> .../gpu/drm/panel/panel-sharp-ls037v7dw01.c | 226 ++++++
> drivers/gpu/drm/panel/panel-sony-acx565akm.c | 693 ++++++++++++++++++
> drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 381 ++++++++++
> drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 508 +++++++++++++
> 10 files changed, 2398 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> create mode 100644 drivers/gpu/drm/panel/panel-lg-lb035q02.c
> create mode 100644 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
> create mode 100644 drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> create mode 100644 drivers/gpu/drm/panel/panel-sony-acx565akm.c
> create mode 100644 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> create mode 100644 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
>
> --
> Regards,
>
> Laurent Pinchart