From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: daniel.vetter@ffwll.ch, emil.l.velikov@gmail.com,
josef@lusticky.cz, dri-devel@lists.freedesktop.org,
thierry.reding@gmail.com
Subject: Re: [PATCH 4/4] drm/panel/ili9341: Support DPI panels
Date: Mon, 12 Aug 2019 20:20:48 +0200 [thread overview]
Message-ID: <20190812182048.GA6607@ravnborg.org> (raw)
In-Reply-To: <20190812153542.GJ5006@pendragon.ideasonboard.com>
Hi Laurent/Noralf.
On Mon, Aug 12, 2019 at 06:35:42PM +0300, Laurent Pinchart wrote:
> On Mon, Aug 12, 2019 at 02:13:54PM +0200, Noralf Trønnes wrote:
> > Den 11.08.2019 18.41, skrev Sam Ravnborg:
> > > On Thu, Aug 01, 2019 at 03:52:49PM +0200, Noralf Trønnes wrote:
> > >> Add support for panels that use the DPI interface.
> > >> ILI9341 has onboard RAM so the assumption made here is that all such
> > >> panels support pixel upload over DBI.
> > >>
> > >> The presence/absense of the Device Tree 'port' node decides which
> > >> interface is used for pixel transfer.
> > >
> > > Have you consiered if the compatible could be used to determine the use
> > > of a panel? Then it is more explicit how the HW is described in DT.
> >
> > Is that common to use the compatible to tell which interface to use?
> > I don't know what best practice is here.
>
> Usually the compatible identifies the device, not the interface.
> Additional properties are preferred to describe the interface.
Thanks Laurent.
Then the ports idea as implmented by the patch seems to fly.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-12 18:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 13:52 [PATCH 0/4] drm/mipi-dbi: Support panel drivers Noralf Trønnes
2019-08-01 13:52 ` [PATCH 1/4] drm/mipi-dbi: Support command mode " Noralf Trønnes
2019-08-11 14:16 ` Sam Ravnborg
2019-08-12 12:05 ` Noralf Trønnes
2019-08-12 18:49 ` Sam Ravnborg
2019-08-13 16:24 ` Noralf Trønnes
2019-08-01 13:52 ` [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel Noralf Trønnes
2019-08-01 19:43 ` David Lechner
2019-08-02 14:19 ` Noralf Trønnes
2019-08-11 15:24 ` Sam Ravnborg
2019-08-12 12:11 ` Noralf Trønnes
2019-08-01 13:52 ` [PATCH 3/4] drm/tiny/mi0283qt: Move driver to panel-ilitek-ili9341 Noralf Trønnes
2019-08-01 19:13 ` David Lechner
2019-08-01 13:52 ` [PATCH 4/4] drm/panel/ili9341: Support DPI panels Noralf Trønnes
2019-08-01 19:10 ` [4/4] " David Lechner
2019-08-02 14:14 ` Noralf Trønnes
2019-08-11 16:41 ` [PATCH 4/4] " Sam Ravnborg
2019-08-12 12:13 ` Noralf Trønnes
2019-08-12 15:35 ` Laurent Pinchart
2019-08-12 18:20 ` Sam Ravnborg [this message]
2019-08-11 17:02 ` Sam Ravnborg
2019-08-12 12:18 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812182048.GA6607@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=josef@lusticky.cz \
--cc=laurent.pinchart@ideasonboard.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox