From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] nouveau/hmm: map pages after migration
Date: Fri, 16 Aug 2019 09:11:32 +0200 [thread overview]
Message-ID: <20190816071132.GA7513@lst.de> (raw)
In-Reply-To: <1a84e6b6-31e6-6955-509f-9883f4a7a322-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Mon, Aug 12, 2019 at 12:42:30PM -0700, Ralph Campbell wrote:
>
> On 8/10/19 4:13 AM, Christoph Hellwig wrote:
>> On something vaguely related to this patch:
>>
>> You use the NVIF_VMM_PFNMAP_V0_V* defines from nvif/if000c.h, which are
>> a little odd as we only ever set these bits, but they also don't seem
>> to appear to be in values that are directly fed to the hardware.
>>
>> On the other hand mmu/vmm.h defines a set of NVIF_VMM_PFNMAP_V0_*
>
> Yes, I see NVKM_VMM_PFN_*
>
>> constants with similar names and identical values, and those are used
>> in mmu/vmmgp100.c and what appears to finally do the low-level dma
>> mapping and talking to the hardware. Are these two sets of constants
>> supposed to be the same? Are the actual hardware values or just a
>> driver internal interface?
>
> It looks a bit odd to me too.
> I don't really know the structure/history of nouveau.
> Perhaps Ben Skeggs can shed more light on your question.
Ben, do you have any insights on these constants?
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2019-08-16 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 15:02 [PATCH] nouveau/hmm: map pages after migration Ralph Campbell
[not found] ` <20190807150214.3629-1-rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-08-08 7:07 ` Christoph Hellwig
[not found] ` <20190808070701.GC29382-jcswGhMUV9g@public.gmane.org>
2019-08-08 21:29 ` Ralph Campbell
[not found] ` <0b96a8d8-86b5-3ce0-db95-669963c1f8a7-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-08-10 11:13 ` Christoph Hellwig
2019-08-12 19:42 ` Ralph Campbell
[not found] ` <1a84e6b6-31e6-6955-509f-9883f4a7a322-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-08-16 7:11 ` Christoph Hellwig [this message]
[not found] ` <20190816071132.GA7513-jcswGhMUV9g@public.gmane.org>
2019-08-17 1:05 ` Ben Skeggs
[not found] ` <CABDvA=n4Y0QticHZowEWFOqiEB3p99nV71GvHAySYdkcgw-Aow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-17 6:11 ` Christoph Hellwig
2019-08-13 21:58 ` Jerome Glisse
[not found] ` <20190813215852.GA9823-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-08-15 17:43 ` [Nouveau] " Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816071132.GA7513@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox