From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 18/19] drm: rcar-du: crtc: Register GAMMA_LUT properties Date: Tue, 20 Aug 2019 21:02:05 +0300 Message-ID: <20190820180205.GL10820@pendragon.ideasonboard.com> References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-19-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190706140746.29132-19-jacopo+renesas@jmondi.org> Sender: linux-kernel-owner@vger.kernel.org To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Jacopo, Thank you for the patch. On Sat, Jul 06, 2019 at 04:07:45PM +0200, Jacopo Mondi wrote: > Enable the GAMMA_LUT KMS property using the framework helpers to > register the proeprty and the associated gamma table size maximum size. s/proeprty/property/ "and set the associated gamme table maximum size" ? > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > index 3dac605c3a67..222ccc20d6d8 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -1082,6 +1082,7 @@ static const struct drm_crtc_funcs crtc_funcs_gen3 = { > .set_crc_source = rcar_du_crtc_set_crc_source, > .verify_crc_source = rcar_du_crtc_verify_crc_source, > .get_crc_sources = rcar_du_crtc_get_crc_sources, > + .gamma_set = drm_atomic_helper_legacy_gamma_set, > }; > > /* ----------------------------------------------------------------------------- > @@ -1205,6 +1206,9 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex, > if (rcdu->cmms[swindex]) { > rcrtc->cmm = rcdu->cmms[swindex]; > rgrp->cmms_mask |= BIT(hwindex % 2); > + > + drm_mode_crtc_set_gamma_size(crtc, CMM_GAMMA_LUT_SIZE); > + drm_crtc_enable_color_mgmt(crtc, 0, false, CMM_GAMMA_LUT_SIZE); > } > > drm_crtc_helper_add(crtc, &crtc_helper_funcs); -- Regards, Laurent Pinchart