From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ayan Halder Subject: Re: [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584 Date: Thu, 22 Aug 2019 10:32:03 +0000 Message-ID: <20190822103203.GC29026@arm.com> References: <20190819080136.10190-1-james.qian.wang@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190819080136.10190-1-james.qian.wang@arm.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "james qian wang (Arm Technology China)" Cc: Liviu Dudau , "airlied@linux.ie" , Brian Starkey , "maarten.lankhorst@linux.intel.com" , "sean@poorly.run" , "dan.carpenter@oracle.com" , "Jonathan Chai (Arm Technology China)" , "Julien Yin (Arm Technology China)" , "Thomas Sun (Arm Technology China)" , "Lowry Li (Arm Technology China)" , "Tiannan Zhu (Arm Technology China)" , "Yiqi Kang (Arm Technology China)" , nd , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Mon, Aug 19, 2019 at 08:01:57AM +0000, james qian wang (Arm Technology C= hina) wrote: > The patch 5d51f6c0da1b: "drm/komeda: Add writeback support" from May > 23, 2019, leads to the following static checker warning: >=20 > drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c:151 kome= da_wb_connector_add() > error: not allocating enough data 1592 vs 1584 >=20 > This is a typo which misuse "wb_conn" but which should be "kwb_conn" to > allocate the memory. >=20 > Reported-by: Dan Carpenter > Signed-off-by: james qian wang (Arm Technology China) > --- > drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/d= rivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > index 617e1f7b8472..2851cac94d86 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > @@ -148,7 +148,7 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, > if (!kcrtc->master->wb_layer) > return 0; > =20 > - kwb_conn =3D kzalloc(sizeof(*wb_conn), GFP_KERNEL); > + kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); > if (!kwb_conn) > return -ENOMEM; > =20 > -- Reviewed-by: Ayan Kumar Halder =20 > 2.20.1