From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: [PATCH 1/2] drm/msm/dpu: remove some impossible error checking Date: Thu, 22 Aug 2019 21:00:10 -0700 Message-ID: <20190823040103.22289-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Fritz Koenig , David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jordan Crouse , Abhinav Kumar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bruce Wang , Rob Clark , Daniel Vetter , Jeykumar Sankaran , Sean Paul , Sravanthi Kollukuduru List-Id: dri-devel@lists.freedesktop.org RnJvbTogUm9iIENsYXJrIDxyb2JkY2xhcmtAY2hyb21pdW0ub3JnPgoKSSdtIHN1cmUgdGhlcmUg aXMgcGxlbnR5IG1vcmUgdG8gcmVtb3ZlLi4gdGhpcyBpcyBqdXN0IHNvbWUgb2YgdGhlIG9uZXMK SSBub3RpY2VkLgoKU2lnbmVkLW9mZi1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAY2hyb21pdW0u b3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMgICB8 IDE5IC0tLS0tLS0tLS0tLS0tLS0tLS0KIC4uLi9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rl cl9waHlzX2NtZC5jICB8ICAzIC0tLQogLi4uL2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVy X3BoeXNfdmlkLmMgIHwgIDUgLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV9od19jdGwuYyAgICB8ICAzIC0tLQogZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2ttcy5jICAgICAgIHwgIDUgLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV92YmlmLmMgICAgICB8IDEwIC0tLS0tLS0tLS0KIDYgZmlsZXMgY2hhbmdlZCwgNDUgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2Vu Y29kZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKaW5k ZXggMGUyZjc0MTYzYTE2Li5lZDY3N2NmMmUxYWYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9k aXNwL2RwdTEvZHB1X2VuY29kZXIuYwpAQCAtMTQyOCwxMiArMTQyOCw2IEBAIHN0YXRpYyB2b2lk IF9kcHVfZW5jb2Rlcl90cmlnZ2VyX2ZsdXNoKHN0cnVjdCBkcm1fZW5jb2RlciAqZHJtX2VuYywK IAlpbnQgcGVuZGluZ19raWNrb2ZmX2NudDsKIAl1MzIgcmV0ID0gVUlOVF9NQVg7CiAKLQlpZiAo IWRybV9lbmMgfHwgIXBoeXMpIHsKLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGFyZ3VtZW50KHMpLCBk cm1fZW5jICVkLCBwaHlzX2VuYyAlZFxuIiwKLQkJCQlkcm1fZW5jICE9IDAsIHBoeXMgIT0gMCk7 Ci0JCXJldHVybjsKLQl9Ci0KIAlpZiAoIXBoeXMtPmh3X3BwKSB7CiAJCURQVV9FUlJPUigiaW52 YWxpZCBwaW5ncG9uZyBod1xuIik7CiAJCXJldHVybjsKQEAgLTE1NjYsMTEgKzE1NjAsNiBAQCBz dGF0aWMgdm9pZCBfZHB1X2VuY29kZXJfa2lja29mZl9waHlzKHN0cnVjdCBkcHVfZW5jb2Rlcl92 aXJ0ICpkcHVfZW5jLAogCXVpbnQzMl90IGksIHBlbmRpbmdfZmx1c2g7CiAJdW5zaWduZWQgbG9u ZyBsb2NrX2ZsYWdzOwogCi0JaWYgKCFkcHVfZW5jKSB7Ci0JCURQVV9FUlJPUigiaW52YWxpZCBl bmNvZGVyXG4iKTsKLQkJcmV0dXJuOwotCX0KLQogCXBlbmRpbmdfZmx1c2ggPSAweDA7CiAKIAkv KiB1cGRhdGUgcGVuZGluZyBjb3VudHMgYW5kIHRyaWdnZXIga2lja29mZiBjdGwgZmx1c2ggYXRv bWljYWxseSAqLwpAQCAtMTc5OCwxMCArMTc4Nyw2IEBAIHZvaWQgZHB1X2VuY29kZXJfcHJlcGFy ZV9mb3Jfa2lja29mZihzdHJ1Y3QgZHJtX2VuY29kZXIgKmRybV9lbmMsIGJvb2wgYXN5bmMpCiAJ Ym9vbCBuZWVkc19od19yZXNldCA9IGZhbHNlOwogCXVuc2lnbmVkIGludCBpOwogCi0JaWYgKCFk cm1fZW5jKSB7Ci0JCURQVV9FUlJPUigiaW52YWxpZCBhcmdzXG4iKTsKLQkJcmV0dXJuOwotCX0K IAlkcHVfZW5jID0gdG9fZHB1X2VuY29kZXJfdmlydChkcm1fZW5jKTsKIAogCXRyYWNlX2RwdV9l bmNfcHJlcGFyZV9raWNrb2ZmKERSTUlEKGRybV9lbmMpKTsKQEAgLTE4MzcsMTAgKzE4MjIsNiBA QCB2b2lkIGRwdV9lbmNvZGVyX2tpY2tvZmYoc3RydWN0IGRybV9lbmNvZGVyICpkcm1fZW5jLCBi b29sIGFzeW5jKQogCWt0aW1lX3Qgd2FrZXVwX3RpbWU7CiAJdW5zaWduZWQgaW50IGk7CiAKLQlp ZiAoIWRybV9lbmMpIHsKLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGVuY29kZXJcbiIpOwotCQlyZXR1 cm47Ci0JfQogCURQVV9BVFJBQ0VfQkVHSU4oImVuY29kZXJfa2lja29mZiIpOwogCWRwdV9lbmMg PSB0b19kcHVfZW5jb2Rlcl92aXJ0KGRybV9lbmMpOwogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX2NtZC5jIGIvZHJpdmVycy9ncHUv ZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYwppbmRleCAxYjNhYjkwOWYz NjcuLjI5MjNiNjNkOTVmZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfZW5jb2Rlcl9waHlzX2NtZC5jCkBAIC03MjAsOSArNzIwLDYgQEAgc3RhdGljIGlu dCBkcHVfZW5jb2Rlcl9waHlzX2NtZF93YWl0X2Zvcl92YmxhbmsoCiBzdGF0aWMgdm9pZCBkcHVf ZW5jb2Rlcl9waHlzX2NtZF9oYW5kbGVfcG9zdF9raWNrb2ZmKAogCQlzdHJ1Y3QgZHB1X2VuY29k ZXJfcGh5cyAqcGh5c19lbmMpCiB7Ci0JaWYgKCFwaHlzX2VuYykKLQkJcmV0dXJuOwotCiAJLyoq CiAJICogcmUtZW5hYmxlIGV4dGVybmFsIFRFLCBlaXRoZXIgZm9yIHRoZSBmaXJzdCB0aW1lIGFm dGVyIGVuYWJsaW5nCiAJICogb3IgaWYgZGlzYWJsZWQgZm9yIEF1dG9yZWZyZXNoCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5j IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJfcGh5c192aWQuYwpp bmRleCA1MDU1YTVlZWM4NjkuLjczN2ZlOTYzYTQ5MCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUv ZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJfcGh5c192aWQuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jCkBAIC02MTIsMTEgKzYx Miw2IEBAIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVyX3BoeXNfdmlkX2hhbmRsZV9wb3N0X2tpY2tv ZmYoCiB7CiAJdW5zaWduZWQgbG9uZyBsb2NrX2ZsYWdzOwogCi0JaWYgKCFwaHlzX2VuYykgewot CQlEUFVfRVJST1IoImludmFsaWQgZW5jb2RlclxuIik7Ci0JCXJldHVybjsKLQl9Ci0KIAkvKgog CSAqIFZpZGVvIG1vZGUgbXVzdCBmbHVzaCBDVEwgYmVmb3JlIGVuYWJsaW5nIHRpbWluZyBlbmdp bmUKIAkgKiBWaWRlbyBlbmNvZGVycyBuZWVkIHRvIHR1cm4gb24gdGhlaXIgaW50ZXJmYWNlcyBu b3cKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9od19jdGwu YyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9od19jdGwuYwppbmRleCBiMmY3 YjBlODg2YjUuLjE3OWU4ZDUyY2FkYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9k aXNwL2RwdTEvZHB1X2h3X2N0bC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUx L2RwdV9od19jdGwuYwpAQCAtMTAyLDkgKzEwMiw2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBkcHVf aHdfY3RsX3VwZGF0ZV9wZW5kaW5nX2ZsdXNoKHN0cnVjdCBkcHVfaHdfY3RsICpjdHgsCiAKIHN0 YXRpYyB1MzIgZHB1X2h3X2N0bF9nZXRfcGVuZGluZ19mbHVzaChzdHJ1Y3QgZHB1X2h3X2N0bCAq Y3R4KQogewotCWlmICghY3R4KQotCQlyZXR1cm4gMHgwOwotCiAJcmV0dXJuIGN0eC0+cGVuZGlu Z19mbHVzaF9tYXNrOwogfQogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfa21zLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMK aW5kZXggNjgxOTU1ZWIyODZmLi5iOGQyNjRiZDE1ZGYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfa21zLmMKQEAgLTQ5MCwxMSArNDkwLDYgQEAgc3RhdGljIGludCBfZHB1X2tt c19kcm1fb2JqX2luaXQoc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMpCiAJaW50IHByaW1hcnlfcGxh bmVzX2lkeCA9IDAsIGN1cnNvcl9wbGFuZXNfaWR4ID0gMCwgaSwgcmV0OwogCWludCBtYXhfY3J0 Y19jb3VudDsKIAotCWlmICghZHB1X2ttcyB8fCAhZHB1X2ttcy0+ZGV2IHx8ICFkcHVfa21zLT5k ZXYtPmRldikgewotCQlEUFVfRVJST1IoImludmFsaWQgZHB1X2ttc1xuIik7Ci0JCXJldHVybiAt RUlOVkFMOwotCX0KLQogCWRldiA9IGRwdV9rbXMtPmRldjsKIAlwcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKIAljYXRhbG9nID0gZHB1X2ttcy0+Y2F0YWxvZzsKZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV92YmlmLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfdmJpZi5jCmluZGV4IDhiYzNhZWE3Y2Q4Ni4uZjk4YTg4MjMxOGQxIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfdmJpZi5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV92YmlmLmMKQEAgLTI2NCwxMSArMjY0LDYg QEAgdm9pZCBkcHVfdmJpZl9jbGVhcl9lcnJvcnMoc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMpCiAJ c3RydWN0IGRwdV9od192YmlmICp2YmlmOwogCXUzMiBpLCBwbmQsIHNyYzsKIAotCWlmICghZHB1 X2ttcykgewotCQlEUFVfRVJST1IoImludmFsaWQgYXJndW1lbnRcbiIpOwotCQlyZXR1cm47Ci0J fQotCiAJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZHB1X2ttcy0+aHdfdmJpZik7IGkrKykg ewogCQl2YmlmID0gZHB1X2ttcy0+aHdfdmJpZltpXTsKIAkJaWYgKHZiaWYgJiYgdmJpZi0+b3Bz LmNsZWFyX2Vycm9ycykgewpAQCAtMjg2LDExICsyODEsNiBAQCB2b2lkIGRwdV92YmlmX2luaXRf bWVtdHlwZXMoc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMpCiAJc3RydWN0IGRwdV9od192YmlmICp2 YmlmOwogCWludCBpLCBqOwogCi0JaWYgKCFkcHVfa21zKSB7Ci0JCURQVV9FUlJPUigiaW52YWxp ZCBhcmd1bWVudFxuIik7Ci0JCXJldHVybjsKLQl9Ci0KIAlmb3IgKGkgPSAwOyBpIDwgQVJSQVlf U0laRShkcHVfa21zLT5od192YmlmKTsgaSsrKSB7CiAJCXZiaWYgPSBkcHVfa21zLT5od192Ymlm W2ldOwogCQlpZiAodmJpZiAmJiB2YmlmLT5jYXAgJiYgdmJpZi0+b3BzLnNldF9tZW1fdHlwZSkg ewotLSAKMi4yMS4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJl bm8=