From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units Date: Tue, 27 Aug 2019 01:43:37 +0300 Message-ID: <20190826224337.GL5031@pendragon.ideasonboard.com> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-4-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190825135154.11488-4-jacopo+renesas@jmondi.org> Sender: linux-kernel-owner@vger.kernel.org To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org, horms@verge.net.au, uli@fpond.eu, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Jacopo, Thank you for the patch. Should you squash this with the patches that add CMM units to the other SoCs ? On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car M3-W device tree and reference them from > the Display Unit they are connected to. > > Signed-off-by: Jacopo Mondi Apart from the issue pointed out by Geert, Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > index 3dc9d73f589a..8d78e1f98a23 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -2613,6 +2613,30 @@ > renesas,fcp = <&fcpvi0>; > }; > > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea40000 0 0x1000>; > + clocks = <&cpg CPG_MOD 711>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 711>; > + }; > + > + cmm1: cmm@fea50000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea50000 0 0x1000>; > + clocks = <&cpg CPG_MOD 710>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 710>; > + }; > + > + cmm2: cmm@fea60000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea60000 0 0x1000>; > + clocks = <&cpg CPG_MOD 709>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 709>; > + }; > + > csi20: csi2@fea80000 { > compatible = "renesas,r8a7796-csi2"; > reg = <0 0xfea80000 0 0x10000>; > @@ -2766,6 +2790,7 @@ > status = "disabled"; > > vsps = <&vspd0 &vspd1 &vspd2>; > + cmms = <&cmm0 &cmm1 &cmm2>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart