From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 04/14] arm64: dts: renesas: r8a7795: Add CMM units Date: Tue, 27 Aug 2019 01:45:09 +0300 Message-ID: <20190826224509.GM5031@pendragon.ideasonboard.com> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-5-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190825135154.11488-5-jacopo+renesas@jmondi.org> Sender: linux-kernel-owner@vger.kernel.org To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org, horms@verge.net.au, uli@fpond.eu, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:44PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car H3 device tree and reference them from > the Display Unit they are connected to. > > While at it, re-sort the du device node properties to match the ordering > found in other SoCs. > > Signed-off-by: Jacopo Mondi Apart from the issue with compatible string as pointed out for patch 03/14, Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 36 +++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index 95deff66eeb6..21b4069f07e7 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -2909,6 +2909,38 @@ > iommus = <&ipmmu_vi1 10>; > }; > > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a7795"; > + reg = <0 0xfea40000 0 0x1000>; > + clocks = <&cpg CPG_MOD 711>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 711>; > + }; > + > + cmm1: cmm@fea50000 { > + compatible = "renesas,cmm-r8a7795"; > + reg = <0 0xfea50000 0 0x1000>; > + clocks = <&cpg CPG_MOD 710>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 710>; > + }; > + > + cmm2: cmm@fea60000 { > + compatible = "renesas,cmm-r8a7795"; > + reg = <0 0xfea60000 0 0x1000>; > + clocks = <&cpg CPG_MOD 709>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 709>; > + }; > + > + cmm3: cmm@fea70000 { > + compatible = "renesas,cmm-r8a7795"; > + reg = <0 0xfea70000 0 0x1000>; > + clocks = <&cpg CPG_MOD 708>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 708>; > + }; > + > csi20: csi2@fea80000 { > compatible = "renesas,r8a7795-csi2"; > reg = <0 0xfea80000 0 0x10000>; > @@ -3112,9 +3144,11 @@ > <&cpg CPG_MOD 722>, > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > - vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > status = "disabled"; > > + vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > + cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; -- Regards, Laurent Pinchart