From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 06/14] arm64: dts: renesas: r8a77990: Add CMM units Date: Tue, 27 Aug 2019 01:47:01 +0300 Message-ID: <20190826224701.GO5031@pendragon.ideasonboard.com> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-7-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190825135154.11488-7-jacopo+renesas@jmondi.org> Sender: linux-kernel-owner@vger.kernel.org To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org, horms@verge.net.au, uli@fpond.eu, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:46PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car E3 device tree and reference them from > the Display Unit they are connected to. > > While at it, re-sort the du device node properties to match the ordering > found in other SoCs. > > Signed-off-by: Jacopo Mondi Apart from the issue with compatible string as pointed out for patch 03/14, Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > index 455954c3d98e..89ebe6f565af 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -1727,6 +1727,22 @@ > iommus = <&ipmmu_vi0 9>; > }; > > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a77990"; > + reg = <0 0xfea40000 0 0x1000>; > + clocks = <&cpg CPG_MOD 711>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 711>; > + }; > + > + cmm1: cmm@fea50000 { > + compatible = "renesas,cmm-r8a77990"; > + reg = <0 0xfea50000 0 0x1000>; > + clocks = <&cpg CPG_MOD 710>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 710>; > + }; > + > csi40: csi2@feaa0000 { > compatible = "renesas,r8a77990-csi2"; > reg = <0 0xfeaa0000 0 0x10000>; > @@ -1768,9 +1784,11 @@ > clock-names = "du.0", "du.1"; > resets = <&cpg 724>; > reset-names = "du.0"; > - vsps = <&vspd0 0>, <&vspd1 0>; > status = "disabled"; > > + vsps = <&vspd0 0>, <&vspd1 0>; > + cmms = <&cmm0 &cmm1>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; -- Regards, Laurent Pinchart