From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] drm/modes: Make the whitelist more const Date: Fri, 6 Sep 2019 19:13:35 +0300 Message-ID: <20190906161335.2hqsnyfzswfc4lpy@flea> References: <20190906074614.30608-1-mripard@kernel.org> <87zhjh3lk5.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1107181105==" Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 976266E319 for ; Fri, 6 Sep 2019 16:13:39 +0000 (UTC) In-Reply-To: <87zhjh3lk5.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: David Airlie , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1107181105== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jmiirhy7oybexmnw" Content-Disposition: inline --jmiirhy7oybexmnw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 06, 2019 at 10:56:10AM +0300, Jani Nikula wrote: > On Fri, 06 Sep 2019, Maxime Ripard wrote: > > The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named > > modes") introduced a whitelist in the named modes lookup code in order to > > be a bit more robust. > > > > However, even though the char pointers were made const, the data they were > > pointing were not. Let's fix that. > > Or rather, the char pointers were const, and they pointed at const > string literals, but the array of pointers itself was not const. Right, I'm always confused with const in this case. I've updated the commit log, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --jmiirhy7oybexmnw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXXKFrwAKCRDj7w1vZxhR xcOoAP44pbB/jzJy2QWizuWhV5CmgaQYEyzenk/Ff5AffIuLowEA+safD2M6aD6I G79Do9Tfttw+3BhIKYFTS1BJ+fh1PAU= =hPwh -----END PGP SIGNATURE----- --jmiirhy7oybexmnw-- --===============1107181105== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1107181105==--