From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
Date: Tue, 10 Sep 2019 16:32:26 +0300 [thread overview]
Message-ID: <20190910133226.GD20699@kadam> (raw)
In-Reply-To: <20190908160428.GA20115@ravnborg.org>
On Sun, Sep 08, 2019 at 06:04:28PM +0200, Sam Ravnborg wrote:
> Hi Dan.
>
> On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> > The "lvds->backlight" pointer could be NULL in situations were
> > of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> > backlight_put() which already has a check for NULL built in.
> >
> > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> A much better fix would be to introduce use of devm_of_find_backlight().
> Then you do not have to worry about put().
>
> Care to respin a v3 that does this?
Sure. That does look nice. I will resend tomorrow.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-09-10 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:03 [PATCH] drm: panel-lvds: Potential Oops in probe error handling Dan Carpenter
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 12:57 ` Dan Carpenter
2019-09-04 18:55 ` [PATCH v2] " Dan Carpenter
2019-09-04 21:48 ` Laurent Pinchart
2019-09-08 16:04 ` Sam Ravnborg
2019-09-10 13:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910133226.GD20699@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox