From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: Steven Price <steven.price@arm.com>
Cc: dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] drm/panfrost: Allow passing extra information about BOs used by a job
Date: Mon, 16 Sep 2019 08:11:10 -0400 [thread overview]
Message-ID: <20190916121110.GA25942@rosenzweig.io> (raw)
In-Reply-To: <18586dc0-aa00-67e7-ec67-fdcded5a03eb@arm.com>
> > + /**
> > + * Pointer to a u32 array of &drm_panfrost_submit_bo_desc objects. This
> > + * field is meant to replace &drm_panfrost_submit.bo_handles which did
> > + * not provide enough information to relax synchronization between
> > + * jobs that only only read the BO they share. When both
> > + * &drm_panfrost_submit.bo_handles and &drm_panfrost_submit.bo_descs
> > + * are provided, drm_panfrost_submit.bo_handles is ignored.
> > + */
> > + __u64 bo_descs;
> > +
> > + /**
> > + * Number of BO descriptors passed in (size is that times
> > + * sizeof(drm_panfrost_submit_bo_desc)).
> > + */
> > + __u32 bo_desc_count;
>
> We don't really need another count field. bo_handle_count could be
> re-used. Indeed this could even be handled with just a flags field with
> a new flag specifying that bo_handles no longer points to handles but to
> bo_desc objects instead.
This seems like the cleaniest approach (also bumping the ABI version).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-16 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 11:17 [PATCH 1/2] drm/panfrost: Allow passing extra information about BOs used by a job Boris Brezillon
2019-09-13 11:17 ` [PATCH 2/2] drm/panfrost: Extend the bo_wait() ioctl Boris Brezillon
2019-09-13 13:46 ` Steven Price
2019-09-16 12:55 ` Boris Brezillon
2019-09-13 13:44 ` [PATCH 1/2] drm/panfrost: Allow passing extra information about BOs used by a job Steven Price
2019-09-16 12:11 ` Alyssa Rosenzweig [this message]
2019-09-16 13:11 ` Boris Brezillon
2019-09-16 22:28 ` Rob Herring
2019-09-16 22:20 ` Rob Herring
2019-09-17 7:15 ` Boris Brezillon
2019-09-23 13:41 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916121110.GA25942@rosenzweig.io \
--to=alyssa@rosenzweig.io \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox