From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 06/11] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Date: Mon, 23 Sep 2019 19:00:45 +0300 Message-ID: <20190923160045.GE5056@pendragon.ideasonboard.com> References: <20190911075215.78047-1-dmitry.torokhov@gmail.com> <20190911075215.78047-7-dmitry.torokhov@gmail.com> <20190920231228.GH12672@pendragon.ideasonboard.com> <20190923150333.GD16243@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190923150333.GD16243@kuha.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: Dmitry Torokhov , Linus Walleij , Andy Shevchenko , Mika Westerberg , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Heikki, On Mon, Sep 23, 2019 at 06:03:33PM +0300, Heikki Krogerus wrote: > On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote: > > Hi Dmitry, > > > > (CC'ing Heikki as the original author of software nodes support) > > > > Thank you for the patch. > > > > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > > > s/bit/but/ > > > > > works with arbitrary firmware node. > > > > > > Signed-off-by: Dmitry Torokhov > > > > Reviewed-by: Laurent Pinchart > > > > On a side note, as I'm not very familiar with software nodes, I tried to > > see how they are to be used, and it seems they are completely > > undocumented :-( Heikki, is this something that could be fixed ? > > OK. I'll start writing API documentation for it. That's great, thanks ! I'll do my best to review it if you CC me. -- Regards, Laurent Pinchart