From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: srinivasan.s@intel.com
Cc: manasi.d.navare@intel.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, lakshminarayana.vudum@intel.com
Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable
Date: Tue, 1 Oct 2019 15:01:02 +0300 [thread overview]
Message-ID: <20191001120102.GF1208@intel.com> (raw)
In-Reply-To: <1569371742-109402-1-git-send-email-srinivasan.s@intel.com>
On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasan.s@intel.com wrote:
> From: Srinivasan S <srinivasan.s@intel.com>
>
> This patch avoids DP MST payload error message in dmesg, as it is trying
> to update the payload to the disconnected DP MST device. After DP MST
> device is disconnected we should not be updating the payload and
> hence remove the error.
>
> v2: Removed the connector status check and converted from error to debug.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632
> Signed-off-by: Srinivasan S <srinivasan.s@intel.com>
Pushed to dinq. Thanks for the patch.
PS. Next time please use --in-reply-to when sending an updated patch
so that it's easier to keep track of the discussion.
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index eeeb3f933aa4..497a6ae0d2c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
>
> ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
> if (ret) {
> - DRM_ERROR("failed to update payload %d\n", ret);
> + DRM_DEBUG_KMS("failed to update payload %d\n", ret);
> }
> if (old_crtc_state->has_audio)
> intel_audio_codec_disable(encoder,
> --
> 2.7.4
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-01 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 0:35 [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable srinivasan.s
2019-10-01 12:01 ` Ville Syrjälä [this message]
2019-10-01 12:45 ` S, Srinivasan
-- strict thread matches above, loose matches on Subject: below --
2019-09-18 1:39 srinivasan.s
2019-09-18 17:50 ` Manasi Navare
2019-09-18 18:11 ` Ville Syrjälä
2019-09-18 18:25 ` Manasi Navare
2019-09-19 7:23 ` S, Srinivasan
2019-09-19 12:03 ` Ville Syrjälä
2019-09-19 13:52 ` S, Srinivasan
2019-09-25 15:02 ` S, Srinivasan
2019-09-30 20:06 ` S, Srinivasan
2019-09-19 12:18 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001120102.GF1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lakshminarayana.vudum@intel.com \
--cc=manasi.d.navare@intel.com \
--cc=srinivasan.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox