From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix comment doc for format_modifiers
Date: Wed, 2 Oct 2019 19:31:47 +0300 [thread overview]
Message-ID: <20191002163147.GB1208@intel.com> (raw)
In-Reply-To: <51583e96-6a2c-b945-5bc8-ff0dd5e33e4e@collabora.com>
On Wed, Oct 02, 2019 at 06:22:23PM +0200, Andrzej Pietrasiewicz wrote:
> Hi Ville,
>
> W dniu 02.10.2019 o 18:18, Ville Syrjälä pisze:
> > On Wed, Oct 02, 2019 at 05:43:49PM +0200, Andrzej Pietrasiewicz wrote:
> >> To human readers
> >>
> >> "array of struct drm_format modifiers" is almost indistinguishable from
> >> "array of struct drm_format_modifiers",
> >
> > Unless I'm blind those two *are* indistinguishable :P
> >
> >> especially given that
> >> struct drm_format_modifier does exist.
> >>
> >> And indeed the parameter passes an array of uint64_t rather than an array
> >> of structs, but the first words of the comment suggest that it passes
> >> an array of structs.
> >>
> >> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> >> ---
> >> drivers/gpu/drm/drm_plane.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> >> index d6ad60ab0d38..df05d8a0dd63 100644
> >> --- a/drivers/gpu/drm/drm_plane.c
> >> +++ b/drivers/gpu/drm/drm_plane.c
> >> @@ -160,7 +160,7 @@ static int create_in_format_blob(struct drm_device *dev, struct drm_plane *plane
> >
> > Looks like you have a broken version of git.
> >
> >> * @funcs: callbacks for the new plane
> >> * @formats: array of supported formats (DRM_FORMAT\_\*)
> >> * @format_count: number of elements in @formats
> >> - * @format_modifiers: array of struct drm_format modifiers terminated by
> >> + * @format_modifiers: array of modifiers of struct drm_format terminated by
> >
> > Now it seems to be saying it's passing in struct drm_format foo[].
> > That doesn't seem right either.
>
> Good point!
>
> array of modifiers applied to struct drm_format?
Not sure what this has to do with that struct?
I think I'd just make it "array of modifiers terminated by ..."
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-02 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 15:43 [PATCH] drm: Fix comment doc for format_modifiers Andrzej Pietrasiewicz
2019-10-02 16:18 ` Ville Syrjälä
2019-10-02 16:22 ` Andrzej Pietrasiewicz
2019-10-02 16:31 ` Ville Syrjälä [this message]
2019-10-02 18:30 ` Sam Ravnborg
2019-10-03 7:51 ` Andrzej Pietrasiewicz
2019-10-03 13:53 ` Ville Syrjälä
2019-10-04 19:08 ` Eric Engestrom
2019-10-04 19:28 ` Ville Syrjälä
2019-10-08 13:01 ` Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002163147.GB1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=andrzej.p@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox