From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put() Date: Thu, 3 Oct 2019 20:41:40 +0100 Message-ID: <20191003194140.GE6090@sirena.co.uk> References: <20191003082812.28491-1-jjhiblot@ti.com> <20191003082812.28491-3-jjhiblot@ti.com> <20191003104228.c5nho6eimwzqwxpt@earth.universe> <62591735-9082-1fd7-d791-07929ddaa223@gmail.com> <20191003183554.GA37096@sirena.co.uk> <25b9614f-d6be-9da5-0fe5-eb58c8c93850@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0331630497==" Return-path: Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13C9C6EA70 for ; Thu, 3 Oct 2019 19:41:45 +0000 (UTC) In-Reply-To: <25b9614f-d6be-9da5-0fe5-eb58c8c93850@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacek Anaszewski Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, Liam Girdwood , tomi.valkeinen@ti.com, Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, dmurphy@ti.com, pavel@ucw.cz, Jean-Jacques Hiblot , lee.jones@linaro.org, linux-leds@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============0331630497== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J4XPiPrVK1ev6Sgr" Content-Disposition: inline --J4XPiPrVK1ev6Sgr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 03, 2019 at 09:21:06PM +0200, Jacek Anaszewski wrote: > On 10/3/19 8:35 PM, Mark Brown wrote: > > On Thu, Oct 03, 2019 at 07:43:17PM +0200, Jacek Anaszewski wrote: > >> On 10/3/19 2:47 PM, Jean-Jacques Hiblot wrote: > >>> On 03/10/2019 12:42, Sebastian Reichel wrote: > >>>> On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote: > > This mail has nothing relevant in the subject line and pages of quotes > > before the question for me, it's kind of lucky I noticed it.... > Isn't it all about creating proper filters? My point there is that there's nothing obvious in the mail that suggests it should get past filters - just being CCed on a mail isn't super reliable, people often get pulled in due to things like checkpatch or someone copying a CC list from an earlier patch series where there were things were relevant. > >> I wonder if it wouldn't make sense to add support for fwnode > >> parsing to regulator core. Or maybe it is either somehow supported > >> or not supported on purpose? > > Anything attempting to use the regulator DT bindings in ACPI has very > > serious problems, ACPI has its own power model which isn't compatible > > with that used in DT. > We have a means for checking if fwnode refers to of_node: > is_of_node(const struct fwnode_handle *fwnode) > Couldn't it be employed for OF case? Why would we want to do that? We'd continue to support only DT systems, just with code that's less obviously DT only and would need to put checks in. I'm not seeing an upside here. --J4XPiPrVK1ev6Sgr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2WTvMACgkQJNaLcl1U h9Auugf+M/zn9qkTET9ib5D1e+yMi2/IZ7fTAai9T2B+PpfoT99g1OPogSJsmjH6 HFm1fxQ2S4yyqCMx65spqqfXAj4vYAaIJ16BrkPv0ykL+QFaH7SyMZyvdMgYDsME HmmjAAFt0Ljk6UMHcD6Vrcb9eqjkgioH3z/veVZaDY8M/fPzVTyIOEKCwnIB+3vo mXiO62YHBVozTQTPVGfqkny8R4gz21SCuCdEs5n7WEyrNz5Sea/EDJ0cqYElJbLP qPOeooxCrYZcTQXKiS4FnTZH4iAPT9Ly7zrmlxKT2V0PDhRof+X93bNuQ2p6iLQg hZP2riCEv2AXWMZUQy8Mv4/5N2O+Mw== =+gP7 -----END PGP SIGNATURE----- --J4XPiPrVK1ev6Sgr-- --===============0331630497== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0331630497==--