From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: Should regulator core support parsing OF based fwnode? Date: Fri, 4 Oct 2019 18:42:33 +0100 Message-ID: <20191004174233.GF4866@sirena.co.uk> References: <20191003183554.GA37096@sirena.co.uk> <25b9614f-d6be-9da5-0fe5-eb58c8c93850@gmail.com> <20191003194140.GE6090@sirena.co.uk> <20191004113942.GB4866@sirena.co.uk> <20191004144029.GC4866@sirena.co.uk> <6df68ecb-f92e-fd9c-7f55-f66fa463263a@ti.com> <20191004155838.GE4866@sirena.co.uk> <95a43632-57d0-2705-a2d3-d64827212692@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HCdXmnRlPgeNBad2" Return-path: Content-Disposition: inline In-Reply-To: <95a43632-57d0-2705-a2d3-d64827212692@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Jean-Jacques Hiblot Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, Liam Girdwood , tomi.valkeinen@ti.com, Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Jacek Anaszewski , pavel@ucw.cz, lee.jones@linaro.org, linux-leds@vger.kernel.org, dmurphy@ti.com List-Id: dri-devel@lists.freedesktop.org --HCdXmnRlPgeNBad2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 04, 2019 at 06:12:52PM +0200, Jean-Jacques Hiblot wrote: > On 04/10/2019 17:58, Mark Brown wrote: > > Regulator supplies are supposed to be defined at the chip level rather > > than subfunctions with names corresponding to the names on the chip. ... > > good chance that they come up with the same mapping. The supply_alias > > interface is there to allow mapping these through to subfunctions if > > needed, it looks like the LED framework should be using this. > In case of current-sink LED drivers, each LED can be powered by a different > regulator, because the driver is only a switch between the LED cathod and > the ground. Sure, it's common for devices to have supplies that are only needed by one part of the chip which is why we have the supply_alias interface for mapping things through. > > That said if you are doing the above and the LEDs are appearing as > > devices it's extremely surprising that their of_node might not be > > initialized. > That is because this is usually done by the platform core which is not > involved here. The surprise is more that it got instantiated from the DT without keeping the node around than how it happened. --HCdXmnRlPgeNBad2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2XhIgACgkQJNaLcl1U h9Ax0wf7BtlHwZ3DGTnXuJN85FVOLdmgDfERGDVQS+pR3WFG/BLI42EXa+OfXl6S VF7r82YlzCBgY4z9Qm+DXbEkxdRyYzDu+fXp7iT/gEpuN8tS+y/vEAlfz8TVxbmi P1cNkSnXcO4kKFGwW6mzVKOWE9Odxw1kFu0srade53RfiIC0xhXGafHXplRiIM+7 2saUeJgmWDYsOAcSO7IBvnoicuXNOn0+FPV9O+Raj+1vw5BCD6wJGdbCQPI+OYSl DfaR1UmYKJkXH5wCjCHsaAkMI3Y/1u04Xoik5Y2cle8e1DdE6w1a/vzIEhLIqup2 Nzc07kK12LcFNNRdcqE4MiRNMNpS+Q== =FQdn -----END PGP SIGNATURE----- --HCdXmnRlPgeNBad2--