From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm: damage_helper: Fix race checking plane->state->fb Date: Tue, 8 Oct 2019 10:00:05 -0400 Message-ID: <20191008140005.GI126146@art_vandelay> References: <20190904202938.110207-1-sean@poorly.run> <20190919150401.GV218215@art_vandelay> <20191008095033.GJ16989@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw1-xc42.google.com (mail-yw1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 448006E7BC for ; Tue, 8 Oct 2019 14:00:07 +0000 (UTC) Received: by mail-yw1-xc42.google.com with SMTP id i207so6445446ywc.9 for ; Tue, 08 Oct 2019 07:00:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191008095033.GJ16989@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Thomas Hellstrom , Maxime Ripard , Daniel Vetter , dri-devel , David Airlie , Sean Paul , stable , Deepak Rawat , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMDgsIDIwMTkgYXQgMTE6NTA6MzNBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIFNlcCAxOSwgMjAxOSBhdCAxMTowNDowMUFNIC0wNDAwLCBTZWFuIFBh dWwgd3JvdGU6Cj4gPiBPbiBUaHUsIFNlcCAwNSwgMjAxOSBhdCAxMjo0MToyN1BNICswMjAwLCBE YW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBXZWQsIFNlcCA0LCAyMDE5IGF0IDEwOjI5IFBN IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVuPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IEZyb206 IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+ID4gPiA+Cj4gPiA+ID4gU2luY2Ug dGhlIGRpcnR5ZmIgaW9jdGwgZG9lc24ndCBnaXZlIHVzIGFueSBoaW50cyBhcyB0byB3aGljaCBw bGFuZSBpcwo+ID4gPiA+IHNjYW5uaW5nIG91dCB0aGUgZmIgaXQncyBtYXJraW5nIGFzIGRhbWFn ZWQsIHdlIG5lZWQgdG8gbG9vcCB0aHJvdWdoCj4gPiA+ID4gcGxhbmVzIHRvIGZpbmQgaXQuCj4g PiA+ID4KPiA+ID4gPiBDdXJyZW50bHkgd2UganVzdCByZWFjaCBpbnRvIHBsYW5lIHN0YXRlIGFu ZCBjaGVjaywgYnV0IHRoYXQgY2FuIHJhY2UKPiA+ID4gPiB3aXRoIGFub3RoZXIgY29tbWl0IGNo YW5naW5nIHRoZSBmYiBvdXQgZnJvbSB1bmRlciB1cy4gVGhpcyBwYXRjaCBsb2Nrcwo+ID4gPiA+ IHRoZSBwbGFuZSBiZWZvcmUgY2hlY2tpbmcgdGhlIGZiIGFuZCB3aWxsIHJlbGVhc2UgdGhlIGxv Y2sgaWYgdGhlIHBsYW5lCj4gPiA+ID4gaXMgbm90IGRpc3BsYXlpbmcgdGhlIGRpcnR5IGZiLgo+ ID4gPiA+Cj4gPiA+ID4gRml4ZXM6IGI5ZmM1ZTAxZDFjZSAoImRybTogQWRkIGhlbHBlciB0byBp bXBsZW1lbnQgbGVnYWN5IGRpcnR5ZmIiKQo+ID4gPiA+IENjOiBSb2IgQ2xhcmsgPHJvYmRjbGFy a0BnbWFpbC5jb20+Cj4gPiA+ID4gQ2M6IERlZXBhayBSYXdhdCA8ZHJhd2F0QHZtd2FyZS5jb20+ Cj4gPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiA+ ID4gQ2M6IFRob21hcyBIZWxsc3Ryb20gPHRoZWxsc3Ryb21Adm13YXJlLmNvbT4KPiA+ID4gPiBD YzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K PiA+ID4gPiBDYzogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiA+ ID4gPiBDYzogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+Cj4gPiA+ID4gQ2M6IERhdmlkIEFp cmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiA+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs QGZmd2xsLmNoPgo+ID4gPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g PiA+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY1LjArCj4gPiA+ID4gUmVwb3J0 ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiA+ID4gPiAtLS0KPiA+ID4g PiAgZHJpdmVycy9ncHUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMgfCA4ICsrKysrKystCj4gPiA+ ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4g Pgo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RhbWFnZV9oZWxwZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5jCj4gPiA+ID4gaW5kZXggODIz MGRhYzAxYTg5Li4zYTQxMjZkYzI1MjAgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2RhbWFnZV9oZWxwZXIuYwo+ID4gPiA+IEBAIC0yMTIsOCArMjEyLDE0IEBAIGludCBkcm1fYXRv bWljX2hlbHBlcl9kaXJ0eWZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ID4gPiA+ICAg ICAgICAgZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBmYi0+ZGV2KSB7Cj4gPiA+ID4gICAgICAg ICAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlOwo+ID4gPiA+Cj4g PiA+ID4gLSAgICAgICAgICAgICAgIGlmIChwbGFuZS0+c3RhdGUtPmZiICE9IGZiKQo+ID4gPiA+ ICsgICAgICAgICAgICAgICByZXQgPSBkcm1fbW9kZXNldF9sb2NrKCZwbGFuZS0+bXV0ZXgsIHN0 YXRlLT5hY3F1aXJlX2N0eCk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgIGlmIChyZXQpCj4gPiA+ IAo+ID4gPiBJIHRoaW5rIGZvciBwYXJhbm9pZCBzYWZldHkgd2Ugc2hvdWxkIGhhdmUgYSBXQVJO X09OKHJldCA9PSAtRUFMUkVBRFkpCj4gPiA+IGhlcmUuIEl0IHNob3VsZCBiZSBpbXBvc3NpYmxl LCBidXQgaWYgaXQncyBub3QgZm9yIHNvbWUgb2RkYmFsbAo+ID4gPiByZWFzb24sIHdlJ2xsIGJs b3cgdXAuCj4gPiAKPiA+IGRybV9tb2Rlc2V0X2xvY2sgZWF0cyBFQUxSRUFEWSBhbmQgcmV0dXJu cyAwIGZvciB0aGF0IGNhc2UsIHNvIEkgZ3Vlc3MgaXQKPiA+IGRlcGVuZHMgX2hvd18gcGFyYW5v aWQgeW91IHdhbnQgdG8gYmUgaGVyZSA6LSkKPiAKPiBBaCBzaWxseSBtZSwgci1iIGFzLWlzIHRo ZW4uCgpUaGFua3MsIHB1c2hlZCB0byAtbWlzYy1uZXh0CgpTZWFuCgo+IC1EYW5pZWwKPiAKPiA+ IAo+ID4gPiAKPiA+ID4gV2l0aCB0aGF0OiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsQGZmd2xsLmNoPgo+ID4gPiAKPiA+ID4gQnV0IHBsZWFzZSBnaXZlIHRoaXMgYSBzcGluIHdp dGggc29tZSB3b3JrbG9hZHMgYW5kIHRoZSB3d19tdXRleAo+ID4gPiBzbG93cGF0aCBkZWJ1Z2dp bmcgZW5hYmxlZCwganVzdCB0byBtYWtyZSBzdXJlLgo+ID4gCj4gPiBPaywgaGFkIGEgY2hhbmNl IHRvIHJ1biB0aHJvdWdoIHNvbWUgdGVzdHMgdGhpcyBtb3JuaW5nIHdpdGgKPiA+IENPTkZJR19E RUJVR19XV19NVVRFWF9TTE9XUEFUSCBhbmQgdGhpbmdzIGxndG0KPiA+IAo+ID4gU2Vhbgo+ID4g Cj4gPiA+IC1EYW5pZWwKPiA+ID4gCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZ290 byBvdXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgICAgICAgICBpZiAocGxhbmUtPnN0YXRl LT5mYiAhPSBmYikgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGRybV9tb2Rlc2V0 X3VubG9jaygmcGxhbmUtPm11dGV4KTsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBj b250aW51ZTsKPiA+ID4gPiArICAgICAgICAgICAgICAgfQo+ID4gPiA+Cj4gPiA+ID4gICAgICAg ICAgICAgICAgIHBsYW5lX3N0YXRlID0gZHJtX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3RhdGUs IHBsYW5lKTsKPiA+ID4gPiAgICAgICAgICAgICAgICAgaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkp IHsKPiA+ID4gPiAtLQo+ID4gPiA+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2ds ZSAvIENocm9taXVtIE9TCj4gPiA+ID4KPiA+ID4gCj4gPiA+IAo+ID4gPiAtLSAKPiA+ID4gRGFu aWVsIFZldHRlcgo+ID4gPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiA+ ID4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaAo+ID4gCj4gPiAt LSAKPiA+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9T Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBF bmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs