From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/6] drm/gem: refine drm_gem_objects_lookup Date: Wed, 9 Oct 2019 17:07:08 +0200 Message-ID: <20191009150708.GE16989@phenom.ffwll.local> References: <20190927134616.21899-1-yuq825@gmail.com> <20190927134616.21899-2-yuq825@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9520E6E9D2 for ; Wed, 9 Oct 2019 15:07:22 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id r9so2330335edl.10 for ; Wed, 09 Oct 2019 08:07:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190927134616.21899-2-yuq825@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Qiang Yu Cc: Tomeu Vizoso , lima@lists.freedesktop.org, Maxime Ripard , dri-devel@lists.freedesktop.org, Steven Price , David Airlie , Alyssa Rosenzweig , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBTZXAgMjcsIDIwMTkgYXQgMDk6NDY6MTFQTSArMDgwMCwgUWlhbmcgWXUgd3JvdGU6 Cj4gZHJtX2dlbV9vYmplY3RzX2xvb2t1cCBkb2VzIG5vdCB1c2UgdXNlciBzcGFjZSBibyBoYW5k bGVzCj4gZGlyZWN0bHkgYW5kIGxlZnQgdGhlIHVzZXIgdG8ga2VybmVsIGNvcHkgd29yayB0byBh IG5ldwo+IGludGVyZmFjZSBkcm1fZ2VtX29iamVjdHNfbG9va3VwX3VzZXIuCj4gCj4gVGhpcyBp cyBmb3IgZHJpdmVyIGxpa2UgbGltYSB3aGljaCBkb2VzIG5vdCBwYXNzIGdlbSBibwo+IGhhbmRs ZXMgY29udGlub3VzbHkgaW4gYW4gYXJyYXkgaW4gaW9jdGwgYXJndW1lbnQuCj4gCj4gdjI6Cj4g MS4gYWRkIGRybV9nZW1fb2JqZWN0c19sb29rdXBfdXNlcgo+IDIuIHJlbW92ZSBub25lLXplcm8g Y2hlY2sgYXMgYWxsIGNhbGxlciB3aWxsIGNoZWNrIGJlZm9yZQo+ICAgIGNhbGxpbmcgdGhpcyBm dW5jdGlvbgo+IAo+IENjOiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+IENjOiBUb21l dSBWaXpvc28gPHRvbWV1LnZpem9zb0Bjb2xsYWJvcmEuY29tPgo+IENjOiBTdGV2ZW4gUHJpY2Ug PHN0ZXZlbi5wcmljZUBhcm0uY29tPgo+IENjOiBBbHlzc2EgUm9zZW56d2VpZyA8YWx5c3NhLnJv c2VuendlaWdAY29sbGFib3JhLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2Jo QGtlcm5lbC5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogUWlhbmcgWXUgPHl1cTgyNUBnbWFpbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgICAgICAgICAgICAgICB8IDU3ICsr KysrKysrKysrKysrKysrKystLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZy b3N0X2Rydi5jIHwgIDYgKy0tCj4gIGluY2x1ZGUvZHJtL2RybV9nZW0uaCAgICAgICAgICAgICAg ICAgICB8ICA0ICstCj4gIDMgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgMTggZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gaW5kZXggNjg1NGY1ODY3ZDUxLi5hNWU4OGMzZTZk MjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBAQCAtNjc5LDExICs2NzksMTEgQEAgc3RhdGljIGludCBv YmplY3RzX2xvb2t1cChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsIHUzMiAqaGFuZGxlLCBpbnQgY291 bnQsCj4gIC8qKgo+ICAgKiBkcm1fZ2VtX29iamVjdHNfbG9va3VwIC0gbG9vayB1cCBHRU0gb2Jq ZWN0cyBmcm9tIGFuIGFycmF5IG9mIGhhbmRsZXMKPiAgICogQGZpbHA6IERSTSBmaWxlIHByaXZh dGUgZGF0ZQo+IC0gKiBAYm9faGFuZGxlczogdXNlciBwb2ludGVyIHRvIGFycmF5IG9mIHVzZXJz cGFjZSBoYW5kbGUKPiArICogQGJvX2hhbmRsZXM6IGFycmF5IG9mIEdFTSBvYmplY3QgaGFuZGxl cwo+ICAgKiBAY291bnQ6IHNpemUgb2YgaGFuZGxlIGFycmF5Cj4gICAqIEBvYmpzX291dDogcmV0 dXJuZWQgcG9pbnRlciB0byBhcnJheSBvZiBkcm1fZ2VtX29iamVjdCBwb2ludGVycwo+ICAgKgo+ IC0gKiBUYWtlcyBhbiBhcnJheSBvZiB1c2Vyc3BhY2UgaGFuZGxlcyBhbmQgcmV0dXJucyBhIG5l d2x5IGFsbG9jYXRlZCBhcnJheSBvZgo+ICsgKiBUYWtlcyBhbiBhcnJheSBvZiBHRU0gb2JqZWN0 IGhhbmRsZXMgYW5kIHJldHVybnMgYSBuZXdseSBhbGxvY2F0ZWQgYXJyYXkgb2YKPiAgICogR0VN IG9iamVjdHMuCj4gICAqCj4gICAqIEZvciBhIHNpbmdsZSBoYW5kbGUgbG9va3VwLCB1c2UgZHJt X2dlbV9vYmplY3RfbG9va3VwKCkuCj4gQEAgLTY5NSwyNiArNjk1LDU2IEBAIHN0YXRpYyBpbnQg b2JqZWN0c19sb29rdXAoc3RydWN0IGRybV9maWxlICpmaWxwLCB1MzIgKmhhbmRsZSwgaW50IGNv dW50LAo+ICAgKiBmYWlsdXJlLiAwIGlzIHJldHVybmVkIG9uIHN1Y2Nlc3MuCj4gICAqCj4gICAq Lwo+IC1pbnQgZHJtX2dlbV9vYmplY3RzX2xvb2t1cChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsIHZv aWQgX191c2VyICpib19oYW5kbGVzLAo+ICtpbnQgZHJtX2dlbV9vYmplY3RzX2xvb2t1cChzdHJ1 Y3QgZHJtX2ZpbGUgKmZpbHAsIHUzMiAqYm9faGFuZGxlcywKPiAgCQkJICAgaW50IGNvdW50LCBz dHJ1Y3QgZHJtX2dlbV9vYmplY3QgKioqb2Jqc19vdXQpCgpZb3UgY2FuJ3QgZG8gdGhpcyBjaGFu Z2Ugd2l0aG91dCB1cGRhdGluZyBhbGwgdGhlIGRyaXZlcnMuIFNpbXBsZXIgdG8ga2VlcAp0aGlz IG9uZSBhcy1pcywgYW5kIGNyZWF0ZSBhIG5ldyBmdW5jdGlvbiB3aXRoIGFuIF9pbnRlcm5hbCBz dWZmaXguCi1EYW5pZWwKCj4gIHsKPiAgCWludCByZXQ7Cj4gLQl1MzIgKmhhbmRsZXM7Cj4gIAlz dHJ1Y3QgZHJtX2dlbV9vYmplY3QgKipvYmpzOwo+ICAKPiAtCWlmICghY291bnQpCj4gLQkJcmV0 dXJuIDA7Cj4gLQo+ICAJb2JqcyA9IGt2bWFsbG9jX2FycmF5KGNvdW50LCBzaXplb2Yoc3RydWN0 IGRybV9nZW1fb2JqZWN0ICopLAo+ICAJCQkgICAgIEdGUF9LRVJORUwgfCBfX0dGUF9aRVJPKTsK PiAgCWlmICghb2JqcykKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gKwlyZXQgPSBvYmplY3Rz X2xvb2t1cChmaWxwLCBib19oYW5kbGVzLCBjb3VudCwgb2Jqcyk7Cj4gKwlpZiAocmV0KQo+ICsJ CWt2ZnJlZShvYmpzKTsKPiArCWVsc2UKPiArCQkqb2Jqc19vdXQgPSBvYmpzOwo+ICsKPiArCXJl dHVybiByZXQ7Cj4gKwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2dlbV9vYmplY3RzX2xvb2t1 cCk7Cj4gKwo+ICsvKioKPiArICogZHJtX2dlbV9vYmplY3RzX2xvb2t1cF91c2VyIC0gbG9vayB1 cCBHRU0gb2JqZWN0cyBmcm9tIGFuIGFycmF5IG9mIGhhbmRsZXMKPiArICogQGZpbHA6IERSTSBm aWxlIHByaXZhdGUgZGF0ZQo+ICsgKiBAYm9faGFuZGxlczogdXNlciBwb2ludGVyIHRvIGFycmF5 IG9mIHVzZXJzcGFjZSBoYW5kbGUKPiArICogQGNvdW50OiBzaXplIG9mIGhhbmRsZSBhcnJheQo+ ICsgKiBAb2Jqc19vdXQ6IHJldHVybmVkIHBvaW50ZXIgdG8gYXJyYXkgb2YgZHJtX2dlbV9vYmpl Y3QgcG9pbnRlcnMKPiArICoKPiArICogVGFrZXMgYW4gYXJyYXkgb2YgdXNlcnNwYWNlIGhhbmRs ZXMgYW5kIHJldHVybnMgYSBuZXdseSBhbGxvY2F0ZWQgYXJyYXkgb2YKPiArICogR0VNIG9iamVj dHMuCj4gKyAqCj4gKyAqIEZvciBhIHNpbmdsZSBoYW5kbGUgbG9va3VwLCB1c2UgZHJtX2dlbV9v YmplY3RfbG9va3VwKCkuCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqCj4gKyAqIEBvYmpzIGZp bGxlZCBpbiB3aXRoIEdFTSBvYmplY3QgcG9pbnRlcnMuIFJldHVybmVkIEdFTSBvYmplY3RzIG5l ZWQgdG8gYmUKPiArICogcmVsZWFzZWQgd2l0aCBkcm1fZ2VtX29iamVjdF9wdXQoKS4gLUVOT0VO VCBpcyByZXR1cm5lZCBvbiBhIGxvb2t1cAo+ICsgKiBmYWlsdXJlLiAwIGlzIHJldHVybmVkIG9u IHN1Y2Nlc3MuCj4gKyAqCj4gKyAqLwo+ICtpbnQgZHJtX2dlbV9vYmplY3RzX2xvb2t1cF91c2Vy KHN0cnVjdCBkcm1fZmlsZSAqZmlscCwgdm9pZCBfX3VzZXIgKmJvX2hhbmRsZXMsCj4gKwkJCQlp bnQgY291bnQsIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqKipvYmpzX291dCkKPiArewo+ICsJaW50 IHJldDsKPiArCXUzMiAqaGFuZGxlczsKPiArCj4gIAloYW5kbGVzID0ga3ZtYWxsb2NfYXJyYXko Y291bnQsIHNpemVvZih1MzIpLCBHRlBfS0VSTkVMKTsKPiAtCWlmICghaGFuZGxlcykgewo+IC0J CXJldCA9IC1FTk9NRU07Cj4gLQkJZ290byBvdXQ7Cj4gLQl9Cj4gKwlpZiAoIWhhbmRsZXMpCj4g KwkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJaWYgKGNvcHlfZnJvbV91c2VyKGhhbmRsZXMsIGJv X2hhbmRsZXMsIGNvdW50ICogc2l6ZW9mKHUzMikpKSB7Cj4gIAkJcmV0ID0gLUVGQVVMVDsKPiBA QCAtNzIyLDE1ICs3NTIsMTQgQEAgaW50IGRybV9nZW1fb2JqZWN0c19sb29rdXAoc3RydWN0IGRy bV9maWxlICpmaWxwLCB2b2lkIF9fdXNlciAqYm9faGFuZGxlcywKPiAgCQlnb3RvIG91dDsKPiAg CX0KPiAgCj4gLQlyZXQgPSBvYmplY3RzX2xvb2t1cChmaWxwLCBoYW5kbGVzLCBjb3VudCwgb2Jq cyk7Cj4gLQkqb2Jqc19vdXQgPSBvYmpzOwo+ICsJcmV0ID0gZHJtX2dlbV9vYmplY3RzX2xvb2t1 cChmaWxwLCBoYW5kbGVzLCBjb3VudCwgb2Jqc19vdXQpOwo+ICAKPiAgb3V0Ogo+ICAJa3ZmcmVl KGhhbmRsZXMpOwo+ICAJcmV0dXJuIHJldDsKPiAgCj4gIH0KPiAtRVhQT1JUX1NZTUJPTChkcm1f Z2VtX29iamVjdHNfbG9va3VwKTsKPiArRVhQT1JUX1NZTUJPTChkcm1fZ2VtX29iamVjdHNfbG9v a3VwX3VzZXIpOwo+ICAKPiAgLyoqCj4gICAqIGRybV9nZW1fb2JqZWN0X2xvb2t1cCAtIGxvb2sg dXAgYSBHRU0gb2JqZWN0IGZyb20gaXRzIGhhbmRsZQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3Qv cGFuZnJvc3RfZHJ2LmMKPiBpbmRleCBkNzQ0NDJkNzEwNDguLjQ4NmNhNTFkNTY2MiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMKPiBAQCAtMTMwLDkgKzEzMCw5 IEBAIHBhbmZyb3N0X2xvb2t1cF9ib3Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWlmICgh am9iLT5pbXBsaWNpdF9mZW5jZXMpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JcmV0dXJu IGRybV9nZW1fb2JqZWN0c19sb29rdXAoZmlsZV9wcml2LAo+IC0JCQkJICAgICAgKHZvaWQgX191 c2VyICopKHVpbnRwdHJfdClhcmdzLT5ib19oYW5kbGVzLAo+IC0JCQkJICAgICAgam9iLT5ib19j b3VudCwgJmpvYi0+Ym9zKTsKPiArCXJldHVybiBkcm1fZ2VtX29iamVjdHNfbG9va3VwX3VzZXIo ZmlsZV9wcml2LAo+ICsJCQkJCSAgICh2b2lkIF9fdXNlciAqKSh1aW50cHRyX3QpYXJncy0+Ym9f aGFuZGxlcywKPiArCQkJCQkgICBqb2ItPmJvX2NvdW50LCAmam9iLT5ib3MpOwo+ICB9Cj4gIAo+ ICAvKioKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oIGIvaW5jbHVkZS9kcm0v ZHJtX2dlbS5oCj4gaW5kZXggNmFhYmExNGY1OTcyLi4zNTRmYzhkMjQwZTQgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4g QEAgLTM4Nyw4ICszODcsMTAgQEAgc3RydWN0IHBhZ2UgKipkcm1fZ2VtX2dldF9wYWdlcyhzdHJ1 Y3QgZHJtX2dlbV9vYmplY3QgKm9iaik7Cj4gIHZvaWQgZHJtX2dlbV9wdXRfcGFnZXMoc3RydWN0 IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCBwYWdlICoqcGFnZXMsCj4gIAkJYm9vbCBkaXJ0 eSwgYm9vbCBhY2Nlc3NlZCk7Cj4gIAo+IC1pbnQgZHJtX2dlbV9vYmplY3RzX2xvb2t1cChzdHJ1 Y3QgZHJtX2ZpbGUgKmZpbHAsIHZvaWQgX191c2VyICpib19oYW5kbGVzLAo+ICtpbnQgZHJtX2dl bV9vYmplY3RzX2xvb2t1cChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsIHUzMiAqYm9faGFuZGxlcywK PiAgCQkJICAgaW50IGNvdW50LCBzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKioqb2Jqc19vdXQpOwo+ ICtpbnQgZHJtX2dlbV9vYmplY3RzX2xvb2t1cF91c2VyKHN0cnVjdCBkcm1fZmlsZSAqZmlscCwg dm9pZCBfX3VzZXIgKmJvX2hhbmRsZXMsCj4gKwkJCQlpbnQgY291bnQsIHN0cnVjdCBkcm1fZ2Vt X29iamVjdCAqKipvYmpzX291dCk7Cj4gIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZHJtX2dlbV9v YmplY3RfbG9va3VwKHN0cnVjdCBkcm1fZmlsZSAqZmlscCwgdTMyIGhhbmRsZSk7Cj4gIGxvbmcg ZHJtX2dlbV9kbWFfcmVzdl93YWl0KHN0cnVjdCBkcm1fZmlsZSAqZmlsZXAsIHUzMiBoYW5kbGUs Cj4gIAkJCQkgICAgYm9vbCB3YWl0X2FsbCwgdW5zaWduZWQgbG9uZyB0aW1lb3V0KTsKPiAtLSAK PiAyLjE3LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWw=