From: Daniel Vetter <daniel@ffwll.ch>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Jason Ekstrand" <jason@jlekstrand.net>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/drm_syncobj: Dead code removal
Date: Wed, 9 Oct 2019 18:10:43 +0200 [thread overview]
Message-ID: <20191009161043.GP16989@phenom.ffwll.local> (raw)
In-Reply-To: <a1b85bc1-46a8-9978-995f-f081c52594e5@intel.com>
On Fri, Oct 04, 2019 at 03:25:00PM +0300, Lionel Landwerlin wrote:
> On 04/10/2019 15:16, Zbigniew Kempczyński wrote:
> > Remove dead code, likely overseened during review process.
> >
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Chunming Zhou <david1.zhou@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > ---
> > drivers/gpu/drm/drm_syncobj.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> > index 4b5c7b0ed714..21a22e39c9fa 100644
> > --- a/drivers/gpu/drm/drm_syncobj.c
> > +++ b/drivers/gpu/drm/drm_syncobj.c
> > @@ -192,8 +192,6 @@ static void drm_syncobj_fence_add_wait(struct drm_syncobj *syncobj,
> > if (!fence || dma_fence_chain_find_seqno(&fence, wait->point)) {
> > dma_fence_put(fence);
> > list_add_tail(&wait->node, &syncobj->cb_list);
> > - } else if (!fence) {
> > - wait->fence = dma_fence_get_stub();
> > } else {
> > wait->fence = fence;
> > }
> > @@ -856,8 +854,6 @@ static void syncobj_wait_syncobj_func(struct drm_syncobj *syncobj,
> > if (!fence || dma_fence_chain_find_seqno(&fence, wait->point)) {
> > dma_fence_put(fence);
> > return;
> > - } else if (!fence) {
> > - wait->fence = dma_fence_get_stub();
> > } else {
> > wait->fence = fence;
> > }
>
> Like Chris said, dma_fence_chain_find_seqno() will update the fence pointer,
> so a subsequent check might not be dealing with the same value.
>
> A bit cheeky, but...
Feels like warrants a comment, I missed this one too. Maybe even extract
it into one common function since it's the same code in both places?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-10-09 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 12:16 [PATCH] drm/drm_syncobj: Dead code removal Zbigniew Kempczyński
2019-10-04 12:20 ` Chris Wilson
2019-10-04 12:25 ` Lionel Landwerlin
2019-10-09 16:10 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009161043.GP16989@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=lionel.g.landwerlin@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox