From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v2 16/24] drm/msm: dpu: Add modeset lock checks where applicable Date: Thu, 10 Oct 2019 09:13:22 -0400 Message-ID: <20191010131322.GI85762@art_vandelay> References: <20181116184238.170034-1-sean@poorly.run> <20181116184238.170034-17-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7ACD6EB2A for ; Thu, 10 Oct 2019 13:13:24 +0000 (UTC) Received: by mail-yb1-xb44.google.com with SMTP id s7so1910746ybq.7 for ; Thu, 10 Oct 2019 06:13:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Sean Paul , freedreno , Sean Paul , dri-devel , linux-arm-msm List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTAsIDIwMTkgYXQgMTI6MjA6NTZBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIE5vdiAxNiwgMjAxOCBhdCA3OjQ0IFBNIFNlYW4gUGF1bCA8c2VhbkBw b29ybHkucnVuPiB3cm90ZToKPiA+Cj4gPiBGcm9tOiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9t aXVtLm9yZz4KPiA+Cj4gPiBBZGQgbW9kZXNldCBsb2NrIGNoZWNrcyB0byBmdW5jdGlvbnMgdGhh dCBjb3VsZCBiZSBjYWxsZWQgb3V0c2lkZSB0aGUKPiA+IGNvcmUgYXRvbWljIHN0YWNrLgo+ID4K PiA+IENoYW5nZXMgaW4gdjI6Cj4gPiAtIE5vbmUKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBTZWFu IFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgfCAyICsrCj4gPiAgZHJpdmVycy9ncHUvZHJtL21z bS9kaXNwL2RwdTEvZHB1X2ttcy5jICB8IDEgKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMyBpbnNl cnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5j Cj4gPiBpbmRleCBhMDA4YTg3YTgxMTMuLmNkMGEwYmVhNDMzNSAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMKPiA+IEBAIC0yODQsNiArMjg0LDggQEAg ZW51bSBkcHVfaW50Zl9tb2RlIGRwdV9jcnRjX2dldF9pbnRmX21vZGUoc3RydWN0IGRybV9jcnRj ICpjcnRjKQo+ID4gICAgICAgICAgICAgICAgIHJldHVybiBJTlRGX01PREVfTk9ORTsKPiA+ICAg ICAgICAgfQo+ID4KPiA+ICsgICAgICAgV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2VkKCZj cnRjLT5tdXRleCkpOwo+ID4gKwo+ID4gICAgICAgICAvKiBUT0RPOiBSZXR1cm5zIHRoZSBmaXJz dCBJTlRGX01PREUsIGNvdWxkIHRoZXJlIGJlIG11bHRpcGxlIHZhbHVlcz8gKi8KPiA+ICAgICAg ICAgZHJtX2Zvcl9lYWNoX2VuY29kZXJfbWFzayhlbmNvZGVyLCBjcnRjLT5kZXYsIGNydGMtPnN0 YXRlLT5lbmNvZGVyX21hc2spCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIGRwdV9lbmNvZGVy X2dldF9pbnRmX21vZGUoZW5jb2Rlcik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2ttcy5jCj4gPiBpbmRleCA2NDEzNGQ2MTk3NDguLjUxMDRmYzAxMTQ3ZSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gPiBAQCAtMzU4LDYgKzM1 OCw3IEBAIHZvaWQgZHB1X2ttc19lbmNvZGVyX2VuYWJsZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVu Y29kZXIpCj4gPiAgICAgICAgIGlmIChmdW5jcyAmJiBmdW5jcy0+Y29tbWl0KQo+ID4gICAgICAg ICAgICAgICAgIGZ1bmNzLT5jb21taXQoZW5jb2Rlcik7Cj4gPgo+ID4gKyAgICAgICBXQVJOX09O KCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRl eCkpOwo+ID4gICAgICAgICBkcm1fZm9yX2VhY2hfY3J0YyhjcnRjLCBkZXYpIHsKPiA+ICAgICAg ICAgICAgICAgICBpZiAoIShjcnRjLT5zdGF0ZS0+ZW5jb2Rlcl9tYXNrICYgZHJtX2VuY29kZXJf bWFzayhlbmNvZGVyKSkpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAK PiBJJ20gZmFpcmx5IHN1cmUgdGhpcyBpcyBjYWxsZWQgaW4gdGhlIGF0b21pY19jb21taXQgcGF0 aCwgYW5kIGluIHRoZXJlCj4geW91IG1pZ2h0IG5vdCBhY3R1YWxseSBob2xkIHRoZXNlIGxvY2tz IChpZiB5b3UgZG8gYSBub25ibG9ja2luZwo+IG1vZGVzZXQpLgoKSW5kZWVkLiBJJ20gbm90IHN1 cmUgd2hhdCBteSB0aGlua2luZyB3YXMgd2hlbiBzdWJtaXR0aW5nIHRoaXMsIEkgdGhpbmsgc29t ZSBvZgp0aGUgY2FsbHNpdGVzIG1heSBoYXZlIGNoYW5nZWQgc2luY2UgdGhpcyB3YXMgcG9zdGVk ICh3aXRoIHRoZSBlbmFibGUvcHJvYmUKcmVmYWN0b3JzIGZyb20gYSBmZXcgbW9udGhzIGFnbyku IEF0IGFueSByYXRlLCBkb2Vzbid0IG1hdHRlciBub3csIEknbGwgcG9zdCB0aGUKcmV2ZXJ0IDot KQoKPiAKPiBUaGUgbG9ja2luZyBydWxlcyBmb3IgLT5zdGF0ZSBhcmUgcHJldHR5IGZ1bjogRWl0 aGVyIGhvbGQgdGhlIGxvY2ssIG9yCj4gYmUgaW4gYXRvbWljIGNvbW1pdC4gSW4gdGhlIGxhdGVy IGNhc2UgYXRvbWljIGhlbHBlcnMnIGNvbW1pdCBvcmRlcmluZwo+IGd1YXJhbnRlZXMgdGhhdCB5 b3UgY2FuIHNhZmVseSBhY2Nlc3MgLT5zdGF0ZSAoYnV0IHJlYWQtb25seSBvbmx5KQo+IHdpdGhv dXQgaG9kbGluZyBhbnkgbG9ja3MuIFlvdSBtaWdodCB3YW50IHRvIHJldmVydC4KPiAKPiBEb24n dCBhc2sgd2h5IEkgc3R1bWJsZWQgb3ZlciB0aGlzLgoKT2ssIEknbGwganVzdCBhc3N1bWUgdGhh dCB5b3UgcmVhZCBzZWFucGF1bCdzIDExLW1vbnRoIG9sZCByZXZpZXdzIGJlZm9yZSBiZWQgdG8K cmVsYXggOy0pCgpTZWFuCgoKPiAtRGFuaWVsCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0g aHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBH b29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw=