From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xin Ji <xji@analogixsemi.com>
Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to
 DP bridge driver
Date: Fri, 11 Oct 2019 02:08:50 +0000
Message-ID: <20191011020838.GA24665@xin-VirtualBox>
References: <cover.1570699576.git.xji@analogixsemi.com>
 <43f48a7036e5a2991bd6bd8a7361107b27e48c54.1570699576.git.xji@analogixsemi.com>
 <20191010095315.GK13286@kadam> <20191010095617.GL13286@kadam>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <driverdev-devel-bounces@linuxdriverproject.org>
In-Reply-To: <20191010095617.GL13286@kadam>
Content-Language: en-US
Content-ID: <74774DB8CEF834469574AC2BF8907A4B@namprd04.prod.outlook.com>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, Neil Armstrong <narmstrong@baylibre.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Daniel Vetter <daniel@ffwll.ch>, Sheng Pan <span@analogixsemi.com>
List-Id: dri-devel@lists.freedesktop.org

Hi Dan Carpenter,

This is a bug, I'll fix it right now.

The coding is much nicer than before, thanks for your comments,
it is very helpful for me.

Thanks,
Xin


On Thu, Oct 10, 2019 at 12:56:17PM +0300, Dan Carpenter wrote:
> On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote:
> > This code is *so* much nicer than before.  I hope you feel good about
> > the changes.  It makes me happy to look at this code now.
> > 
> > On Thu, Oct 10, 2019 at 09:34:19AM +0000, Xin Ji wrote:
> > > +static int edid_read(struct anx7625_data *ctx,
> > > +		     u8 offset, u8 *pblock_buf)
> > > +{
> > > +	int ret, cnt;
> > > +	struct device *dev = &ctx->client->dev;
> > > +
> > > +	for (cnt = 0; cnt < EDID_TRY_CNT; cnt++) {
>                                           ^^^^^
> 
> > > +		sp_tx_aux_wr(ctx, offset);
> > > +		/* set I2C read com 0x01 mot = 0 and read 16 bytes */
> > > +		ret = sp_tx_aux_rd(ctx, 0xf1);
> > > +
> > > +		if (ret) {
> > > +			sp_tx_rst_aux(ctx);
> > > +			DRM_DEV_DEBUG_DRIVER(dev, "edid read failed, reset!\n");
> > > +			cnt++;
>                         ^^^^^
> 
> I mean that it's incremented twice, yeah?
> 
> regards,
> dan carpenter