From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v2] drm/msm: Sanitize the modeset_is_locked checks in dpu Date: Fri, 11 Oct 2019 09:33:34 -0400 Message-ID: <20191011133334.GS85762@art_vandelay> References: <20191010181801.186069-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191010181801.186069-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , Rob Clark , Sean Paul , Daniel Vetter , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeykumar Sankaran , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTAsIDIwMTkgYXQgMDI6MTc6NDRQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEFzIERhbmll bCBtZW50aW9ucyBpbiBoaXMgZW1haWwgWzFdLCBub24tYmxvY2tpbmcgY29tbWl0cyBkb24ndCBo b2xkIHRoZQo+IG1vZGVzZXQgbG9ja3MsIHNvIHdlIGNhbiBzYWZlbHkgYWNjZXNzIHN0YXRlIGFz IGxvbmcgYXMgdGhlc2UgZnVuY3Rpb25zCj4gYXJlIGluIHRoZSBjb21taXQgcGF0aC4gU28gcmVt b3ZlIHRoZSBXQVJOX09OIGluIGRwdV9rbXNfZW5jb2Rlcl9lbmFibGUuCj4gCj4gSW4gZHB1X2Ny dGNfZ2V0X2ludGZfbW9kZSwgdGhpbmdzIGFyZSBhIGJpdCBtb3JlIGNvbXBsaWNhdGVkLiBTbyBr ZWVwCj4gdGhlIFdBUk5fT04sIGJ1dCBhZGQgYSBjb21tZW50IGV4cGxhaW5pbmcgdGhlIHNpdHVh dGlvbiBhbmQgaG9wZSBzb21lb25lCj4gY29tZXMgYWxvbmcgYW5kIGZpeGVzIHRoZSBpc3N1ZS4K PiAKPiBbMV0tIGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZl bC8yMDE5LU9jdG9iZXIvMjM5NDQxLmh0bWwKPiAKPiBMaW5rIHRvIHYxOiBodHRwczovL3BhdGNo d29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAxOTEwMTAxNTEzNTEuMTI2NzM1LTEt c2VhbkBwb29ybHkucnVuCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAtIFJlc3RvcmVkIHRoZSBXQVJO X09OIGluIGdldF9pbnRmX21vZGUgYW5kIGFkZGVkIGEgY2xhcmlmeWluZyBjb21tZW50IChEYW5p ZWwpCj4gCj4gRml4ZXM6IDFkZmRiMGUxMDdkYiAoImRybS9tc206IGRwdTogQWRkIG1vZGVzZXQg bG9jayBjaGVja3Mgd2hlcmUgYXBwbGljYWJsZSIpCj4gQ2M6IEpleWt1bWFyIFNhbmthcmFuIDxq c2Fua2FAY29kZWF1cm9yYS5vcmc+Cj4gQ2M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGNocm9taXVt Lm9yZz4KPiBTdWdnZXN0ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBQ YXJ0aWFsbHktUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu Y2g+CgpBcHBsaWVkIHRvIG1zbS1uZXh0IHdpdGggZGFudmV0J3MgZnVsbCBpcmMgci1iLCB0aGFu a3MgZm9yIHRoZSByZXBvcnQgYW5kCnJldmlldyEKClNlYW4KCj4gU2lnbmVkLW9mZi1ieTogU2Vh biBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9t c20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgfCA5ICsrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMgIHwgMSAtCj4gIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1 MS9kcHVfY3J0Yy5jCj4gaW5kZXggMGI5ZGMwNDJkMmUyMi4uZjE5N2RjZTU0NTc2MSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMuYwo+IEBAIC0yNzEsNiArMjcx LDE1IEBAIGVudW0gZHB1X2ludGZfbW9kZSBkcHVfY3J0Y19nZXRfaW50Zl9tb2RlKHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiAgCQlyZXR1cm4gSU5URl9NT0RFX05PTkU7Cj4gIAl9Cj4gIAo+ICsJ LyoKPiArCSAqIFRPRE86IFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGZyb20gZHB1IGRlYnVnZnMg YW5kIGFzIHBhcnQgb2YgYXRvbWljCj4gKwkgKiBjaGVjay4gV2hlbiBjYWxsZWQgZnJvbSBkZWJ1 Z2ZzLCB0aGUgY3J0Yy0+bXV0ZXggbXVzdCBiZSBoZWxkIHRvCj4gKwkgKiByZWFkIGNydGMtPnN0 YXRlLiBIb3dldmVyIHJlYWRpbmcgY3J0Yy0+c3RhdGUgZnJvbSBhdG9taWMgY2hlY2sgaXNuJ3QK PiArCSAqIGFsbG93ZWQgKHVubGVzcyB5b3UgaGF2ZSBhIGdvb2QgcmVhc29uLCBhIGJpZyBjb21t ZW50LCBhbmQgYSBkZWVwCj4gKwkgKiB1bmRlcnN0YW5kaW5nIG9mIGhvdyB0aGUgYXRvbWljL21v ZGVzZXQgbG9ja3Mgd29yayAoPC0gYW5kIHRoaXMgaXMKPiArCSAqIHByb2JhYmx5IG5vdCBwb3Nz aWJsZSkpLiBTbyB3ZSdsbCBrZWVwIHRoZSBXQVJOX09OIGhlcmUgZm9yIG5vdywgYnV0Cj4gKwkg KiByZWFsbHkgd2UgbmVlZCB0byBmaWd1cmUgb3V0IGEgYmV0dGVyIHdheSB0byB0cmFjayBvdXIg b3BlcmF0aW5nIG1vZGUKPiArCSAqLwo+ICAJV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2Vk KCZjcnRjLT5tdXRleCkpOwo+ICAKPiAgCS8qIFRPRE86IFJldHVybnMgdGhlIGZpcnN0IElOVEZf TU9ERSwgY291bGQgdGhlcmUgYmUgbXVsdGlwbGUgdmFsdWVzPyAqLwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMgYi9kcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMKPiBpbmRleCBiMTY0NWFkODNhMWUxLi42YzkyZjBmYmVh Yzk4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC0z MTYsNyArMzE2LDYgQEAgdm9pZCBkcHVfa21zX2VuY29kZXJfZW5hYmxlKHN0cnVjdCBkcm1fZW5j b2RlciAqZW5jb2RlcikKPiAgCWlmIChmdW5jcyAmJiBmdW5jcy0+Y29tbWl0KQo+ICAJCWZ1bmNz LT5jb21taXQoZW5jb2Rlcik7Cj4gIAo+IC0JV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2Vk KCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpKTsKPiAgCWRybV9mb3JfZWFjaF9j cnRjKGNydGMsIGRldikgewo+ICAJCWlmICghKGNydGMtPnN0YXRlLT5lbmNvZGVyX21hc2sgJiBk cm1fZW5jb2Rlcl9tYXNrKGVuY29kZXIpKSkKPiAgCQkJY29udGludWU7Cj4gLS0gCj4gU2VhbiBQ YXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKPiAKCi0tIApTZWFu IFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBs aXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8=