From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 5/5] backlight: add led-backlight driver Date: Mon, 14 Oct 2019 08:57:25 +0100 Message-ID: <20191014075725.GI4545@dell> References: <20190918145730.22805-1-jjhiblot@ti.com> <20190918145730.22805-6-jjhiblot@ti.com> <20191004143900.GO18429@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jean-Jacques Hiblot Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, daniel.thompson@linaro.org, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com List-Id: dri-devel@lists.freedesktop.org On Fri, 04 Oct 2019, Jean-Jacques Hiblot wrote: > Hi Lee, > > On 04/10/2019 16:39, Lee Jones wrote: > > On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: > > > > > From: Tomi Valkeinen > > > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > --- > > > drivers/video/backlight/Kconfig | 7 + > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > Applied, thanks. > > It will break the build because it relies on functions not yet in the LED > core (devm_led_get() for v7 or devm_of_led_get() for v8) You're right, un-applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog