From: James Jones <jajones-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH] drm: Generalized NV Block Linear DRM format mod
Date: Mon, 14 Oct 2019 15:13:20 -0700 [thread overview]
Message-ID: <20191014221321.8163-1-jajones@nvidia.com> (raw)
Beyond general review, I'm looking for feedback on a few things
specifically here:
-Is the level of backwards compatibility described here sufficient?
Technically I can make the user space drivers support the old
modifiers too, but that would mean the layout they specify would
morph based on the GPU they're being used on, and sharing buffers
between two different NV GPUs, which would appear to be possible,
would result in corruption on one side or the other.
-I used "magic" numbers for all the bit shifting. Would it be
better to use __fourcc_XXX constants like the broadcom modifiers
do? I wasn't sure which style was preferred. The nouveau code is
full of magic numbers, but that's a bit lower level than this file.
If preferred, I can send this out as part of a patchset that adds
support for the modifiers to nouveau and TegraDRM, but I have some
things to clean up there before it's ready for proper review, and
I didn't want to block review of the basic modifier layout on that
work.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next reply other threads:[~2019-10-14 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 22:13 James Jones [this message]
2019-10-14 22:13 ` [PATCH] drm: Generalized NV Block Linear DRM format mod James Jones
[not found] ` <20191014221321.8163-2-jajones-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-10-15 14:19 ` Daniel Vetter
[not found] ` <20191015141913.GO11828-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-10-15 15:07 ` James Jones
[not found] ` <d6252e64-57b5-3007-62ae-7e5aff0df5f6-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-10-15 15:42 ` Daniel Vetter
[not found] ` <CAKMK7uGC46L_PxSYRxpjnF_gDWvo5K7=6ZBo_Gc1g27M1+TrXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-10-16 17:24 ` James Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014221321.8163-1-jajones@nvidia.com \
--to=jajones-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=daniel-/w4YWyX8dFk@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox