From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
David Airlie <airlied@linux.ie>, Sean Paul <sean@poorly.run>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb'
Date: Fri, 18 Oct 2019 21:45:30 +0300 [thread overview]
Message-ID: <20191018184530.GF1208@intel.com> (raw)
In-Reply-To: <20191017110846.21769-1-ben.dooks@codethink.co.uk>
On Thu, Oct 17, 2019 at 12:08:46PM +0100, Ben Dooks (Codethink) wrote:
> The drm_need_swiotlb is declared in <drm/drm_cache.h>
> which should be included in drivers/gpu/drm/drm_memory.c
> to silence the following warning:
>
> drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static?
IIRC I silenced that already, so you're probably working on
some old tree. For the latest stuff use:
git://anongit.freedesktop.org/drm-tip drm-tip
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/drm_memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 0bec6dbb0142..2d8615baeadc 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -41,6 +41,7 @@
>
> #include <drm/drm_agpsupport.h>
> #include <drm/drm_device.h>
> +#include <drm/drm_cache.h>
>
> #include "drm_legacy.h"
>
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-10-18 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 11:08 [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb' Ben Dooks (Codethink)
2019-10-18 18:45 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018184530.GF1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=ben.dooks@codethink.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox