From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Date: Fri, 25 Oct 2019 09:30:42 +0200 Message-ID: <20191025073042.GL11828@phenom.ffwll.local> References: <20191024191859.31700-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id A79976E8B9 for ; Fri, 25 Oct 2019 07:30:46 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id r141so895598wme.4 for ; Fri, 25 Oct 2019 00:30:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191024191859.31700-1-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Daniel Vetter , Gerd Hoffmann , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMjQsIDIwMTkgYXQgMDI6MTg6NTlQTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gQ29tbWl0IGM0MDA2OWNiN2JkNiAoImRybTogYWRkIG1tYXAoKSB0byBkcm1fZ2VtX29i amVjdF9mdW5jcyIpCj4gaW50cm9kdWNlZCBhIEdFTSBvYmplY3QgbW1hcCgpIGhvb2sgd2hpY2gg aXMgZXhwZWN0ZWQgdG8gc3VidHJhY3QgdGhlCj4gZmFrZSBvZmZzZXQgZnJvbSB2bV9wZ29mZi4g SG93ZXZlciwgZm9yIG1tYXAoKSBvbiBkbWFidWZzLCB0aGVyZSBpcyBub3QKPiBhIGZha2Ugb2Zm c2V0Lgo+IAo+IFRvIGZpeCB0aGlzLCBsZXQncyBhbHdheXMgY2FsbCBtbWFwKCkgb2JqZWN0IGNh bGxiYWNrIHdpdGggYW4gb2Zmc2V0IG9mIDAsCj4gYW5kIGxlYXZlIGl0IHVwIHRvIGRybV9nZW1f bW1hcF9vYmooKSB0byByZW1vdmUgdGhlIGZha2Ugb2Zmc2V0Lgo+IAo+IFRUTSBzdGlsbCBuZWVk cyB0aGUgZmFrZSBvZmZzZXQsIHNvIHdlIGhhdmUgdG8gYWRkIGl0IGJhY2sgdW50aWwgdGhhdCdz Cj4gZml4ZWQuCj4gCj4gRml4ZXM6IGM0MDA2OWNiN2JkNiAoImRybTogYWRkIG1tYXAoKSB0byBk cm1fZ2VtX29iamVjdF9mdW5jcyIpCj4gQ2M6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQu Y29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25l ZC1vZmYtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4gLS0tCj4gdjI6Cj4gLSBN b3ZlIHN1YnRyYWN0aW5nIHRoZSBmYWtlIG9mZnNldCBvdXQgb2YgbW1hcCgpIG9iaiBjYWxsYmFj a3MuCj4gCj4gSSd2ZSB0ZXN0ZWQgc2htZW0sIGJ1dCBub3QgdHRtLiBIb3BlZnVsbHksIEkgdW5k ZXJzdG9vZCB3aGF0J3MgbmVlZGVkIAo+IGZvciBUVE0uCj4gCj4gUm9iCj4gCj4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fZ2VtLmMgICAgICAgICAgICAgIHwgMyArKysKPiAgZHJpdmVycy9ncHUvZHJt L2RybV9nZW1fc2htZW1faGVscGVyLmMgfCAzIC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdHRtL3R0 bV9ib192bS5jICAgICAgICB8IDcgKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fZ2VtLmggICAg ICAgICAgICAgICAgICB8IDQgKysrLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gaW5kZXggNTZmNDJlMGYyNTg0Li4y ZjJiODg5MDk2YjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBAQCAtMTEwNiw2ICsxMTA2LDkgQEAgaW50 IGRybV9nZW1fbW1hcF9vYmooc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHVuc2lnbmVkIGxv bmcgb2JqX3NpemUsCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAo+ICAJaWYgKG9iai0+ZnVuY3Mg JiYgb2JqLT5mdW5jcy0+bW1hcCkgewo+ICsJCS8qIFJlbW92ZSB0aGUgZmFrZSBvZmZzZXQgKi8K PiArCQl2bWEtPnZtX3Bnb2ZmIC09IGRybV92bWFfbm9kZV9zdGFydCgmb2JqLT52bWFfbm9kZSk7 Cj4gKwo+ICAJCXJldCA9IG9iai0+ZnVuY3MtPm1tYXAob2JqLCB2bWEpOwo+ICAJCWlmIChyZXQp Cj4gIAkJCXJldHVybiByZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2Vt X3NobWVtX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMK PiBpbmRleCBhODc4Yzc4N2I4NjcuLmU4MDYxYzY0YzQ4MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3NobWVtX2hlbHBlci5jCj4gQEAgLTU0Miw5ICs1NDIsNiBAQCBpbnQgZHJtX2dlbV9z aG1lbV9tbWFwKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1 Y3QgKnZtYSkKPiAgCXZtYS0+dm1fcGFnZV9wcm90ID0gcGdwcm90X2RlY3J5cHRlZCh2bWEtPnZt X3BhZ2VfcHJvdCk7Cj4gIAl2bWEtPnZtX29wcyA9ICZkcm1fZ2VtX3NobWVtX3ZtX29wczsKPiAg Cj4gLQkvKiBSZW1vdmUgdGhlIGZha2Ugb2Zmc2V0ICovCj4gLQl2bWEtPnZtX3Bnb2ZmIC09IGRy bV92bWFfbm9kZV9zdGFydCgmc2htZW0tPmJhc2Uudm1hX25vZGUpOwo+IC0KPiAgCXJldHVybiAw Owo+ICB9Cj4gIEVYUE9SVF9TWU1CT0xfR1BMKGRybV9nZW1fc2htZW1fbW1hcCk7Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0v dHRtL3R0bV9ib192bS5jCj4gaW5kZXggMWE5ZGI2OTFmOTU0Li4wODkwMmM3MjkwYTUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdm0uYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS90dG0vdHRtX2JvX3ZtLmMKPiBAQCAtNDgyLDYgKzQ4MiwxMyBAQCBFWFBPUlRfU1lN Qk9MKHR0bV9ib19tbWFwKTsKPiAgaW50IHR0bV9ib19tbWFwX29iaihzdHJ1Y3Qgdm1fYXJlYV9z dHJ1Y3QgKnZtYSwgc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0ICpibykKPiAgewo+ICAJdHRtX2Jv X2dldChibyk7Cj4gKwo+ICsJLyoKPiArCSAqIEZJWE1FOiAmZHJtX2dlbV9vYmplY3RfZnVuY3Mu bW1hcCBpcyBjYWxsZWQgd2l0aCB0aGUgZmFrZSBvZmZzZXQKPiArCSAqIHJlbW92ZWQuIEFkZCBp dCBiYWNrIGhlcmUgdW50aWwgdGhlIHJlc3Qgb2YgVFRNIHdvcmtzIHdpdGhvdXQgaXQuCj4gKwkg Ki8KPiArCXZtYS0+dm1fcGdvZmYgKz0gZHJtX3ZtYV9ub2RlX3N0YXJ0KCZiby0+YmFzZS52bWFf bm9kZSk7Cj4gKwo+ICAJdHRtX2JvX21tYXBfdm1hX3NldHVwKGJvLCB2bWEpOwo+ICAJcmV0dXJu IDA7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oIGIvaW5jbHVkZS9k cm0vZHJtX2dlbS5oCj4gaW5kZXggZTcxZjc1YTJhYjU3Li5jNTZjYmIzNTA5ZTAgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2dlbS5o Cj4gQEAgLTE1OSw3ICsxNTksOSBAQCBzdHJ1Y3QgZHJtX2dlbV9vYmplY3RfZnVuY3Mgewo+ICAJ ICoKPiAgCSAqIFRoZSBjYWxsYmFjayBpcyB1c2VkIGJ5IGJ5IGJvdGggZHJtX2dlbV9tbWFwX29i aigpIGFuZAo+ICAJICogZHJtX2dlbV9wcmltZV9tbWFwKCkuICBXaGVuIEBtbWFwIGlzIHByZXNl bnQgQHZtX29wcyBpcyBub3QKPiAtCSAqIHVzZWQsIHRoZSBAbW1hcCBjYWxsYmFjayBtdXN0IHNl dCB2bWEtPnZtX29wcyBpbnN0ZWFkLgo+ICsJICogdXNlZCwgdGhlIEBtbWFwIGNhbGxiYWNrIG11 c3Qgc2V0IHZtYS0+dm1fb3BzIGluc3RlYWQuIFRoZSBAbW1hcAo+ICsJICogY2FsbGJhY2sgaXMg YWx3YXlzIGNhbGxlZCB3aXRoIGEgMCBvZmZzZXQuIFRoZSBjYWxsZXIgd2lsbCByZW1vdmUKPiAr CSAqIHRoZSBmYWtlIG9mZnNldCBhcyBuZWNlc3NhcnkuCj4gIAkgKgoKTWF5YmUgcmVtb3ZlIHRo aXMgZW1wdHkgY29tbWVudCBsaW5lIGhlcmUgd2hpbGUgYXQgaXQuIFdpdGggdGhhdAoKUmV2aWV3 ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpJIHRoaW5rIEkn bGwgZm9sbG93IHVwIHdpdGggYSBwYXRjaCB0byBhbm5vdGF0ZSBkcm1fZ2VtX21tYXBfb2JqIGFz CmRlcHJlY2F0ZWQgYW5kIHRoYXQgaW5zdGVhZCB0aGlzIGhlcmUgc2hvdWxkIGJlIHVzZWQuCi1E YW5pZWwKCj4gIAkgKi8KPiAgCWludCAoKm1tYXApKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2Jq LCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSk7Cj4gLS0gCj4gMi4yMC4xCj4gCgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs