From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 2/5] drm/dsi: add missing DSI data types Date: Mon, 4 Nov 2019 16:24:11 +0100 Message-ID: <20191104152411.GB1602887@ulmo> References: <20191028150047.22048-1-jani.nikula@intel.com> <20191028150047.22048-2-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1632325686==" Return-path: In-Reply-To: <20191028150047.22048-2-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Vandita Kulkarni , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1632325686== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 28, 2019 at 05:00:44PM +0200, Jani Nikula wrote: > Add execute queue and compressed pixel stream packet data types for > completeness. >=20 > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dsi.c | 2 ++ > include/video/mipi_display.h | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_ds= i.c > index f237d80828c3..3f33f02571fd 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -388,6 +388,7 @@ bool mipi_dsi_packet_format_is_short(u8 type) > case MIPI_DSI_DCS_SHORT_WRITE: > case MIPI_DSI_DCS_SHORT_WRITE_PARAM: > case MIPI_DSI_DCS_READ: > + case MIPI_DSI_EXECUTE_QUEUE: > case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE: > return true; > } > @@ -411,6 +412,7 @@ bool mipi_dsi_packet_format_is_long(u8 type) > case MIPI_DSI_GENERIC_LONG_WRITE: > case MIPI_DSI_DCS_LONG_WRITE: > case MIPI_DSI_PICTURE_PARAMETER_SET: > + case MIPI_DSI_COMPRESSED_PIXEL_STREAM: > case MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20: > case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24: > case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16: > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > index 79fd71cf4934..6b6390dfa203 100644 > --- a/include/video/mipi_display.h > +++ b/include/video/mipi_display.h > @@ -37,6 +37,7 @@ enum { > MIPI_DSI_DCS_SHORT_WRITE_PARAM =3D 0x15, > =20 > MIPI_DSI_DCS_READ =3D 0x06, > + MIPI_DSI_EXECUTE_QUEUE =3D 0x16, > =20 > MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE =3D 0x37, > =20 > @@ -46,6 +47,7 @@ enum { > MIPI_DSI_DCS_LONG_WRITE =3D 0x39, > =20 > MIPI_DSI_PICTURE_PARAMETER_SET =3D 0x0a, > + MIPI_DSI_COMPRESSED_PIXEL_STREAM =3D 0x0b, > =20 > MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20 =3D 0x0c, > MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24 =3D 0x1c, Actually, it looks like the ordering is by lowest-significant nibble first, then by highest-significant nibble, so maybe there's some logic to this after all. Hmm... that's mostly true, except for 0x07 and 0x08... anyway, the new enumeration values and names match the specification, so: Reviewed-by: Thierry Reding --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl3AQpsACgkQ3SOs138+ s6EqJg//V4ou45jO8qy3/RPAj0Hjuz4x6aHFyTOAuPMXJfJxX7e1lEvACqJcWsDA 699DHG4KZdOp1Lv8ZBiFBxe9BnO2NXEOE+b51REPh9rvqJZTGwgSXXRrluDxxoOs eDNxKfng0HFfHQFn3lHe+eGgNAN2QKa1L4b4/ujpvNIk4TM+dk6AkaFY1Yfvjvbx 2ow+JuE3YBZoyp4nDuSVj6afGnyTqUQ9+K3XnfvhJamnoSVfgbaln67Tr8Jv7m4I N2bcGwd0wHqKIBPF5d5qQjwOmirp/KYrOlpYeR1BvuU6M2WPCS/+eMZkQeOKNY/l q3qOgWVfa6nzDUcJBJg/9cmqi+FsyxQF10PQP+2/Oyiouq9a2VR9xzp5mR0T/c3V yh9gAnlXv5o+pBxY1WhX7fuqpIHDYijgqDjiO0CwoBVukSuVEWDKahkoLo4A4510 ZyPAqNCQfX+TXyvnqSLrWBnf+m6WGav6Tlh8vWMarS5wCqt4hROkEwxHSJbGNuP4 qGL9ki1JobAWpumh4/HB0iED2VZwOn0NolUJX3SZcT326yk92q338k4o/VED1aW1 8h6tuac1uylUcG8DtQSewyrRJNMECNIcYeia9m++pRHRdb835Hz5Zf2y+7gR+Hxz lgVJKibNdELaWqP8V8BVBXT+90rHaV+f5nNKmIlhmXsBrUupSiY= =raOG -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ-- --===============1632325686== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1632325686==--