From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH hmm 05/15] RDMA/odp: Use mmu_range_notifier_insert() Date: Mon, 4 Nov 2019 16:25:00 -0400 Message-ID: <20191104202500.GA19383@ziepe.ca> References: <20191015181242.8343-1-jgg@ziepe.ca> <20191015181242.8343-6-jgg@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191015181242.8343-6-jgg-uk2M96/98Pc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Jerome Glisse , Ralph Campbell , John Hubbard , Felix.Kuehling-5C7GfCeVMHo@public.gmane.org Cc: Andrea Arcangeli , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ben Skeggs List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTUsIDIwMTkgYXQgMDM6MTI6MzJQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IEBAIC0yNTAsMjYgKzg1LDE1IEBAIHN0YXRpYyBpbmxpbmUgaW50IGliX2luaXRf dW1lbV9vZHAoc3RydWN0IGliX3VtZW1fb2RwICp1bWVtX29kcCkKPiAgCQkJcmV0ID0gLUVOT01F TTsKPiAgCQkJZ290byBvdXRfcGFnZV9saXN0Owo+ICAJCX0KPiAtCX0KPiAgCj4gLQltbiA9IG1t dV9ub3RpZmllcl9nZXQoJmliX3VtZW1fbm90aWZpZXJzLCB1bWVtX29kcC0+dW1lbS5vd25pbmdf bW0pOwo+IC0JaWYgKElTX0VSUihtbikpIHsKPiAtCQlyZXQgPSBQVFJfRVJSKG1uKTsKPiAtCQln b3RvIG91dF9kbWFfbGlzdDsKPiAtCX0KPiAtCXVtZW1fb2RwLT5wZXJfbW0gPSBwZXJfbW0gPQo+ IC0JCWNvbnRhaW5lcl9vZihtbiwgc3RydWN0IGliX3Vjb250ZXh0X3Blcl9tbSwgbW4pOwo+IC0K PiAtCW11dGV4X2luaXQoJnVtZW1fb2RwLT51bWVtX211dGV4KTsKPiAtCWluaXRfY29tcGxldGlv bigmdW1lbV9vZHAtPm5vdGlmaWVyX2NvbXBsZXRpb24pOwo+ICsJCXJldCA9IG1tdV9yYW5nZV9u b3RpZmllcl9pbnNlcnQoJnVtZW1fb2RwLT5ub3RpZmllciwgc3RhcnQsCj4gKwkJCQkJCWVuZCAt IHN0YXJ0LCBjdXJyZW50LT5tbSk7Cj4gKwkJaWYgKHJldCkKPiArCQkJZ290byBvdXRfZG1hX2xp c3Q7CgpJdCB0dXJucyBvdXQgJ2N1cnJlbnQnIGNhbid0IGJlIHVzZWQgaGVyZSBhcyB0aGlzIGNh biBiZSBjYWxsZWQgZnJvbSB0aGUKcGFnZSBmYXVsdCB3b3JrIHF1ZXVlIGFuZCBzaG91bGQgYmUg J3VtZW1fb2RwLT51bWVtLm93bmluZ19tbScKClRoZSBzYW1lIHByb2JsZW0gYXBwbGllcyB0byB0 aGUgdGdpZCBhIGZldyBsaW5lcyBiZWxvdwoKSXQgYWxzbyBzZWVtcyB0aGVyZSBpcyBhIHByZS1l eGlzdGluZyBwcm9ibGVtIGhlcmUgYXMgdGhpcyBjb2RlCmRvZXNuJ3QgZ3VhcmVudGVlIHRvIGhh dmUgYSBtbWdldCgpIG9uIHRoZSBtbSBmb3IgdGhlIG5vbi1jdXJyZW50IGNhc2UKd2hlbiBpdCBj YWxsZWQgbW11X25vdGlmaWVyX2dldCgpIG9yIG5vdwptbXVfcmFuZ2Vfbm90aWZpZXJfaW5zZXJ0 KCkuIAoKSSdsbCBmaXggdGhpcyBpbiBhIGRlZGljYXRlZCBwYXRjaC4KClRoaXMgaW5jcmVtZW50 YWwgc29ydHMgaXQgb3V0LCBJJ2xsIHNxdWFzaCBpdCBpbnRvIHRoaXMgcGF0Y2g6CgpkaWZmIC0t Z2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL2NvcmUvdW1lbV9vZHAuYyBiL2RyaXZlcnMvaW5maW5p YmFuZC9jb3JlL3VtZW1fb2RwLmMKaW5kZXggNjEzMmI4MTI3ZTg0MzUuLjA3NjhiYjYwY2UxNjYy IDEwMDY0NAotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvY29yZS91bWVtX29kcC5jCisrKyBiL2Ry aXZlcnMvaW5maW5pYmFuZC9jb3JlL3VtZW1fb2RwLmMKQEAgLTg3LDEyICs4NywxMCBAQCBzdGF0 aWMgaW5saW5lIGludCBpYl9pbml0X3VtZW1fb2RwKHN0cnVjdCBpYl91bWVtX29kcCAqdW1lbV9v ZHApCiAJCX0KIAogCQlyZXQgPSBtbXVfcmFuZ2Vfbm90aWZpZXJfaW5zZXJ0KCZ1bWVtX29kcC0+ bm90aWZpZXIsIHN0YXJ0LAotCQkJCQkJZW5kIC0gc3RhcnQsIGN1cnJlbnQtPm1tKTsKKwkJCQkJ CWVuZCAtIHN0YXJ0LAorCQkJCQkJdW1lbV9vZHAtPnVtZW0ub3duaW5nX21tKTsKIAkJaWYgKHJl dCkKIAkJCWdvdG8gb3V0X2RtYV9saXN0OwotCi0JCXVtZW1fb2RwLT50Z2lkID0KLQkJCWdldF90 YXNrX3BpZChjdXJyZW50LT5ncm91cF9sZWFkZXIsIFBJRFRZUEVfUElEKTsKIAl9CiAKIAlyZXR1 cm4gMDsKQEAgLTE0MCw4ICsxMzgsMTAgQEAgaWJfdW1lbV9vZHBfYWxsb2NfaW1wbGljaXQoc3Ry dWN0IGliX3VkYXRhICp1ZGF0YSwgaW50IGFjY2VzcykKIAl1bWVtX29kcC0+aXNfaW1wbGljaXRf b2RwID0gMTsKIAl1bWVtX29kcC0+cGFnZV9zaGlmdCA9IFBBR0VfU0hJRlQ7CiAKKwl1bWVtX29k cC0+dGdpZCA9IGdldF90YXNrX3BpZChjdXJyZW50LT5ncm91cF9sZWFkZXIsIFBJRFRZUEVfUElE KTsKIAlyZXQgPSBpYl9pbml0X3VtZW1fb2RwKHVtZW1fb2RwKTsKIAlpZiAocmV0KSB7CisJCXB1 dF9waWQodW1lbV9vZHAtPnRnaWQpOwogCQlrZnJlZSh1bWVtX29kcCk7CiAJCXJldHVybiBFUlJf UFRSKHJldCk7CiAJfQpAQCAtMTg1LDggKzE4NSwxMCBAQCBpYl91bWVtX29kcF9hbGxvY19jaGls ZChzdHJ1Y3QgaWJfdW1lbV9vZHAgKnJvb3QsIHVuc2lnbmVkIGxvbmcgYWRkciwKIAlvZHBfZGF0 YS0+cGFnZV9zaGlmdCA9IFBBR0VfU0hJRlQ7CiAJb2RwX2RhdGEtPm5vdGlmaWVyLm9wcyA9IG9w czsKIAorCW9kcF9kYXRhLT50Z2lkID0gZ2V0X3BpZChyb290LT50Z2lkKTsKIAlyZXQgPSBpYl9p bml0X3VtZW1fb2RwKG9kcF9kYXRhKTsKIAlpZiAocmV0KSB7CisJCXB1dF9waWQob2RwX2RhdGEt PnRnaWQpOwogCQlrZnJlZShvZHBfZGF0YSk7CiAJCXJldHVybiBFUlJfUFRSKHJldCk7CiAJfQpA QCAtMjU0LDExICsyNTYsMTQgQEAgc3RydWN0IGliX3VtZW1fb2RwICppYl91bWVtX29kcF9nZXQo c3RydWN0IGliX3VkYXRhICp1ZGF0YSwgdW5zaWduZWQgbG9uZyBhZGRyLAogCQl1cF9yZWFkKCZt bS0+bW1hcF9zZW0pOwogCX0KIAorCXVtZW1fb2RwLT50Z2lkID0gZ2V0X3Rhc2tfcGlkKGN1cnJl bnQtPmdyb3VwX2xlYWRlciwgUElEVFlQRV9QSUQpOwogCXJldCA9IGliX2luaXRfdW1lbV9vZHAo dW1lbV9vZHApOwogCWlmIChyZXQpCi0JCWdvdG8gZXJyX2ZyZWU7CisJCWdvdG8gZXJyX3B1dF9w aWQ7CiAJcmV0dXJuIHVtZW1fb2RwOwogCitlcnJfcHV0X3BpZDoKKwlwdXRfcGlkKHVtZW1fb2Rw LT50Z2lkKTsKIGVycl9mcmVlOgogCWtmcmVlKHVtZW1fb2RwKTsKIAlyZXR1cm4gRVJSX1BUUihy ZXQpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQt Z2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=