From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/atomic: clear new_state pointers at hw_done Date: Mon, 4 Nov 2019 22:50:10 +0200 Message-ID: <20191104205010.GM1208@intel.com> References: <20191101180713.5470-1-robdclark@gmail.com> <20191101180713.5470-2-robdclark@gmail.com> <20191101192458.GI1208@intel.com> <20191101214431.GJ1208@intel.com> <20191104184156.GL1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id D84726E868 for ; Mon, 4 Nov 2019 20:50:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: Rob Clark , David Airlie , open list , dri-devel , Sean Paul , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMDQsIDIwMTkgYXQgMTE6MTM6NTlBTSAtMDgwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIE1vbiwgTm92IDQsIDIwMTkgYXQgMTA6NDIgQU0gVmlsbGUgU3lyasOkbMOkCj4gPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBGcmksIE5vdiAw MSwgMjAxOSBhdCAwMzoxNDowOVBNIC0wNzAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gPiA+IE9uIEZy aSwgTm92IDEsIDIwMTkgYXQgMjo0NCBQTSBWaWxsZSBTeXJqw6Rsw6QKPiA+ID4gPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IE9uIEZyaSwgTm92 IDAxLCAyMDE5IGF0IDEyOjQ5OjAyUE0gLTA3MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gPiA+ IE9uIEZyaSwgTm92IDEsIDIwMTkgYXQgMTI6MjUgUE0gVmlsbGUgU3lyasOkbMOkCj4gPiA+ID4g PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiBPbiBGcmksIE5vdiAwMSwgMjAxOSBhdCAxMTowNzoxM0FNIC0wNzAwLCBSb2IgQ2xh cmsgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gRnJvbTogUm9iIENsYXJrIDxyb2JkY2xhcmtAY2hyb21p dW0ub3JnPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gVGhlIG5ldyBzdGF0ZSBzaG91bGQg bm90IGJlIGFjY2Vzc2VkIGFmdGVyIHRoaXMgcG9pbnQuICBDbGVhciB0aGUKPiA+ID4gPiA+ID4g PiBwb2ludGVycyB0byBtYWtlIHRoYXQgZXhwbGljaXQuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiBUaGlzIG1ha2VzIHRoZSBlcnJvciBjb3JyZWN0ZWQgaW4gdGhlIHByZXZpb3VzIHBhdGNo IG1vcmUgb2J2aW91cy4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6 IFJvYiBDbGFyayA8cm9iZGNsYXJrQGNocm9taXVtLm9yZz4KPiA+ID4gPiA+ID4gPiAtLS0KPiA+ ID4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCAyOSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg MjkgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMKPiA+ID4gPiA+ID4gPiBpbmRleCA3MzJiZDBjZTkyNDEuLjE3Njgz MWRmODE2MyAxMDA2NDQKPiA+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+ID4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljX2hlbHBlci5jCj4gPiA+ID4gPiA+ID4gQEAgLTIyMzQsMTMgKzIyMzQsNDIgQEAgRVhQT1JU X1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9mYWtlX3ZibGFuayk7Cj4gPiA+ID4gPiA+ID4gICAq Lwo+ID4gPiA+ID4gPiA+ICB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9od19kb25lKHN0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpCj4gPiA+ID4gPiA+ID4gIHsKPiA+ID4g PiA+ID4gPiArICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ID4gPiA+ID4g PiA+ICsgICAgIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpvbGRfY29ubl9zdGF0ZSwgKm5l d19jb25uX3N0YXRlOwo+ID4gPiA+ID4gPiA+ICAgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsK PiA+ID4gPiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRl LCAqbmV3X2NydGNfc3RhdGU7Cj4gPiA+ID4gPiA+ID4gKyAgICAgc3RydWN0IGRybV9wbGFuZSAq cGxhbmU7Cj4gPiA+ID4gPiA+ID4gKyAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3Bs YW5lX3N0YXRlLCAqbmV3X3BsYW5lX3N0YXRlOwo+ID4gPiA+ID4gPiA+ICAgICAgIHN0cnVjdCBk cm1fY3J0Y19jb21taXQgKmNvbW1pdDsKPiA+ID4gPiA+ID4gPiArICAgICBzdHJ1Y3QgZHJtX3By aXZhdGVfb2JqICpvYmo7Cj4gPiA+ID4gPiA+ID4gKyAgICAgc3RydWN0IGRybV9wcml2YXRlX3N0 YXRlICpvbGRfb2JqX3N0YXRlLCAqbmV3X29ial9zdGF0ZTsKPiA+ID4gPiA+ID4gPiAgICAgICBp bnQgaTsKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ICsgICAgIC8qCj4gPiA+ID4gPiA+ID4g KyAgICAgICogQWZ0ZXIgdGhpcyBwb2ludCwgZHJpdmVycyBzaG91bGQgbm90IGFjY2VzcyB0aGUg cGVybWFuZW50IG1vZGVzZXQKPiA+ID4gPiA+ID4gPiArICAgICAgKiBzdGF0ZSwgc28gd2UgYWxz byBjbGVhciB0aGUgbmV3X3N0YXRlIHBvaW50ZXJzIHRvIG1ha2UgdGhpcwo+ID4gPiA+ID4gPiA+ ICsgICAgICAqIHJlc3RyaWN0aW9uIGV4cGxpY2l0Lgo+ID4gPiA+ID4gPiA+ICsgICAgICAqCj4g PiA+ID4gPiA+ID4gKyAgICAgICogRm9yIHRoZSBDUlRDIHN0YXRlLCB3ZSBkbyB0aGlzIGluIHRo ZSBzYW1lIGxvb3Agd2hlcmUgd2Ugc2lnbmFsCj4gPiA+ID4gPiA+ID4gKyAgICAgICogaHdfZG9u ZSwgc2luY2Ugd2Ugc3RpbGwgbmVlZCB0byBuZXdfY3J0Y19zdGF0ZSB0byBmaXNoIG91dCB0aGUK PiA+ID4gPiA+ID4gPiArICAgICAgKiBjb21taXQuCj4gPiA+ID4gPiA+ID4gKyAgICAgICovCj4g PiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ICsgICAgIGZvcl9lYWNoX29sZG5ld19jb25uZWN0 b3JfaW5fc3RhdGUob2xkX3N0YXRlLCBjb25uZWN0b3IsIG9sZF9jb25uX3N0YXRlLCBuZXdfY29u bl9zdGF0ZSwgaSkgewo+ID4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgb2xkX3N0YXRlLT5jb25u ZWN0b3JzW2ldLm5ld19zdGF0ZSA9IE5VTEw7Cj4gPiA+ID4gPiA+ID4gKyAgICAgfQo+ID4gPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiArICAgICBmb3JfZWFjaF9vbGRuZXdfcGxhbmVfaW5fc3Rh dGUob2xkX3N0YXRlLCBwbGFuZSwgb2xkX3BsYW5lX3N0YXRlLCBuZXdfcGxhbmVfc3RhdGUsIGkp IHsKPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgIG9sZF9zdGF0ZS0+cGxhbmVzW2ldLm5ld19z dGF0ZSA9IE5VTEw7Cj4gPiA+ID4gPiA+ID4gKyAgICAgfQo+ID4gPiA+ID4gPiA+ICsKPiA+ID4g PiA+ID4gPiArICAgICBmb3JfZWFjaF9vbGRuZXdfcHJpdmF0ZV9vYmpfaW5fc3RhdGUob2xkX3N0 YXRlLCBvYmosIG9sZF9vYmpfc3RhdGUsIG5ld19vYmpfc3RhdGUsIGkpIHsKPiA+ID4gPiA+ID4g PiArICAgICAgICAgICAgIG9sZF9zdGF0ZS0+cHJpdmF0ZV9vYmpzW2ldLm5ld19zdGF0ZSA9IE5V TEw7Cj4gPiA+ID4gPiA+ID4gKyAgICAgfQo+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiAg ICAgICBmb3JfZWFjaF9vbGRuZXdfY3J0Y19pbl9zdGF0ZShvbGRfc3RhdGUsIGNydGMsIG9sZF9j cnRjX3N0YXRlLCBuZXdfY3J0Y19zdGF0ZSwgaSkgewo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAg ICAgb2xkX3N0YXRlLT5jcnRjc1tpXS5uZXdfc2VsZl9yZWZyZXNoX2FjdGl2ZSA9IG5ld19jcnRj X3N0YXRlLT5zZWxmX3JlZnJlc2hfYWN0aXZlOwo+ID4gPiA+ID4gPiA+ICsgICAgICAgICAgICAg b2xkX3N0YXRlLT5jcnRjc1tpXS5uZXdfc3RhdGUgPSBOVUxMOwo+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiBUaGF0J3MgZ29pbmcgdG8gYmUgYSByZWFsIFBJVEEgd2hlbiBkb2luZyBwcm9ncmFtbWlu ZyBhZnRlciB0aGUgZmFjdCBmcm9tCj4gPiA+ID4gPiA+IGEgdmJsYW5rIHdvcmtlci4gSXQncyBh bHJlYWR5IGEgcGFpbiB0aGF0IHRoZSBuZXdfY3J0Y19zdGF0ZS0+c3RhdGUgaXMKPiA+ID4gPiA+ ID4gZ2V0dGluZyBOVUxMZWQgc29tZXdoZXJlLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4g PiA+IEkgdGhpbmsgeW91IGFscmVhZHkgaGF2ZSB0aGF0IHByb2JsZW0sIHRoaXMganVzdCBtYWtl cyBpdCBleHBsaWNpdC4KPiA+ID4gPgo+ID4gPiA+IEkgZG9uJ3QgeWV0LiBFeGNlcHQgb24gYSBi cmFuY2ggd2hlcmUgSSBoYXZlIG15IHZibGFuayB3b3JrZXJzLgo+ID4gPiA+IEFuZCBJIHRoaW5r IHRoZSBvbmx5IHByb2JsZW0gaXMgaGF2aW5nIHRoZSBoZWxwZXJzL2NvcmUgY2xvYmJlcgo+ID4g PiA+IHRoZSBwb2ludGVycyB3aGVuIGl0IHNob3VsZCBub3QuIEkgZG9uJ3Qgc2VlIHdoeSBpdCBj YW4ndCBqdXN0Cj4gPiA+ID4gbGVhdmUgdGhlbSBiZSBhbmQgbGV0IG1lIHVzZSB0aGVtLgo+ID4g PiA+Cj4gPiA+Cj4gPiA+IEkgZ3Vlc3MgaXQgY29tZXMgZG93biB0byB3aGF0IGFzc3VtcHRpb25z IHlvdSBjYW4gbWFrZSBpbiBkcml2ZXIKPiA+ID4gYmFja2VuZC4gIEJ1dCBpZiB5b3UgY2FuLCBm b3IgZXhhbXBsZSwgbW92ZSBwbGFuZXMgYmV0d2VlbiBjcnRjcywgSQo+ID4gPiB0aGluayB5b3Ug Y2FuJ3QgbWFrZSBhc3N1bXB0aW9ucyBhYm91dCB0aGUgb3JkZXIgaW4gd2hpY2ggdGhpbmdzCj4g PiA+IGNvbXBsZXRlIGV2ZW4gaWYgeW91IGRvbid0IGhhdmUgY29tbWl0cyBvdmVydGFraW5nIGVh Y2ggb3RoZXIgb24gYQo+ID4gPiBzaW5nbGUgY3J0Yy4uCj4gPgo+ID4gSU1PIHRoaXMgd2hvbGUg bm90aW9uIG9mIGFjY2Vzc2luZyBuZXdfY3J0Y19zdGF0ZSAmIGNvLiBiZWluZyB1bnNhZmUKPiA+ IGZvciBzb21lIHJlYXNvbiBpcyB3cm9uZy4gSSB0aGluayBhcyBsb25nIGFzIEkgaGF2ZSB0aGUg ZHJtX2F0b21pY19zdGF0ZQo+ID4gSSBzaG91bGQgYmUgYWJsZSB0byBsb29rIGF0IHRoZSBuZXcv b2xkIHN0YXRlcyB3aXRoaW4uCj4gPgo+IAo+IGFjY2Vzc2luZyBuZXcgc3RhdGUgb25seSB3b3Jr cyBpZiB5b3UgY2FuIGd1YXJhbnRlZSB0aGUgb3JkZXIgaW4gd2hpY2gKPiBjb21taXRzIGNvbXBs ZXRlLCB3aGljaCBJIGRvbid0IHRoaW5rIHlvdSBjYW4gZG8gaW4gdGhlIGdlbmVyYWwgc2Vuc2Uu CgpEb2Vzbid0IGZlZWwgbGlrZSBpdCBzaG91bGQgdGFrZSBhIGxvdCBvZiByb2NrZXQgc2NpZW5j ZSB0byBndWFyYW50ZWUKdGhlIHN0YXRlcyBnZXQgZnJlZWQgaW4gdGhlIHJpZ2h0IG9yZGVyLgoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=