From mboxrd@z Thu Jan 1 00:00:00 1970 From: Torsten Duwe Subject: Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Date: Tue, 5 Nov 2019 11:58:08 +0100 Message-ID: <20191105105808.GA27999@lst.de> References: <20191104110400.F319F68BE1@verein.lst.de> <20191104110613.C3BA468C4E@verein.lst.de> <20191105104342.GD3876@gilmour.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191105104342.GD3876@gilmour.lan> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Nov 05, 2019 at 11:43:42AM +0100, Maxime Ripard wrote: > > On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote: > > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > > for portable devices. > > > > Add a binding document for it. > > > > Signed-off-by: Icenowy Zheng > > Signed-off-by: Vasily Khoruzhick > > Reviewed-by: Rob Herring > > Signed-off-by: Torsten Duwe > > Reviewed-by: Laurent Pinchart > > Applied, thanks Re-thanks! > (still, there's one comment below that can be addressed in a > subsequent patch). > > > + > > + ports: > > + type: object > > + > > + properties: > > + port@0: > > + type: object > > + description: | > > + Video port for LVTTL input > > + > > + port@1: > > + type: object > > + description: | > > + Video port for eDP output (panel or connector). > > + May be omitted if EDID works reliably. > > + > > + required: > > + - port@0 > > You should have something like: > > ports: > type: object > additionalProperties: false > > as well... Yes, and it also struck me that I forgot at least about the hotplug-gpio. It's unused on the Teres and the Pinebook, but in theory it's a valid property, which can't be added any more now. Torsten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47625C17461 for ; Tue, 5 Nov 2019 13:29:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27A8621D7C for ; Tue, 5 Nov 2019 13:29:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27A8621D7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20D856EA54; Tue, 5 Nov 2019 13:29:13 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0861C6E9CE for ; Tue, 5 Nov 2019 10:58:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2005) id 820FA68B05; Tue, 5 Nov 2019 11:58:08 +0100 (CET) Date: Tue, 5 Nov 2019 11:58:08 +0100 From: Torsten Duwe To: Maxime Ripard Subject: Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20191105105808.GA27999@lst.de> References: <20191104110400.F319F68BE1@verein.lst.de> <20191104110613.C3BA468C4E@verein.lst.de> <20191105104342.GD3876@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191105104342.GD3876@gilmour.lan> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Tue, 05 Nov 2019 13:29:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Harald Geyer , Sean Paul , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191105105808.B0rwvLP8BLRdvoySeC_BrmpxjrxMp8YsnWfFUl2oGiU@z> T24gVHVlLCBOb3YgMDUsIDIwMTkgYXQgMTE6NDM6NDJBTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiAKPiBPbiBUdWUsIE9jdCAyOSwgMjAxOSBhdCAwMToxNjo1N1BNICswMTAwLCBUb3Jz dGVuIER1d2Ugd3JvdGU6Cj4gPiBUaGUgYW54NjM0NSBpcyBhbiB1bHRyYS1sb3cgcG93ZXIgRGlz cGxheVBvcnQvZURQIHRyYW5zbWl0dGVyIGRlc2lnbmVkCj4gPiBmb3IgcG9ydGFibGUgZGV2aWNl cy4KPiA+Cj4gPiBBZGQgYSBiaW5kaW5nIGRvY3VtZW50IGZvciBpdC4KPiA+Cj4gPiBTaWduZWQt b2ZmLWJ5OiBJY2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2MuaW8+Cj4gPiBTaWduZWQtb2ZmLWJ5 OiBWYXNpbHkgS2hvcnV6aGljayA8YW5hcnNvdWxAZ21haWwuY29tPgo+ID4gUmV2aWV3ZWQtYnk6 IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBUb3JzdGVu IER1d2UgPGR1d2VAc3VzZS5kZT4KPiA+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gQXBwbGllZCwgdGhhbmtzCgpS ZS10aGFua3MhCgo+IChzdGlsbCwgdGhlcmUncyBvbmUgY29tbWVudCBiZWxvdyB0aGF0IGNhbiBi ZSBhZGRyZXNzZWQgaW4gYQo+IHN1YnNlcXVlbnQgcGF0Y2gpLgo+IAo+ID4gKwo+ID4gKyAgcG9y dHM6Cj4gPiArICAgIHR5cGU6IG9iamVjdAo+ID4gKwo+ID4gKyAgICBwcm9wZXJ0aWVzOgo+ID4g KyAgICAgIHBvcnRAMDoKPiA+ICsgICAgICAgIHR5cGU6IG9iamVjdAo+ID4gKyAgICAgICAgZGVz Y3JpcHRpb246IHwKPiA+ICsgICAgICAgICAgVmlkZW8gcG9ydCBmb3IgTFZUVEwgaW5wdXQKPiA+ ICsKPiA+ICsgICAgICBwb3J0QDE6Cj4gPiArICAgICAgICB0eXBlOiBvYmplY3QKPiA+ICsgICAg ICAgIGRlc2NyaXB0aW9uOiB8Cj4gPiArICAgICAgICAgIFZpZGVvIHBvcnQgZm9yIGVEUCBvdXRw dXQgKHBhbmVsIG9yIGNvbm5lY3RvcikuCj4gPiArICAgICAgICAgIE1heSBiZSBvbWl0dGVkIGlm IEVESUQgd29ya3MgcmVsaWFibHkuCj4gPiArCj4gPiArICAgIHJlcXVpcmVkOgo+ID4gKyAgICAg IC0gcG9ydEAwCj4gCj4gWW91IHNob3VsZCBoYXZlIHNvbWV0aGluZyBsaWtlOgo+IAo+IHBvcnRz Ogo+ICAgdHlwZTogb2JqZWN0Cj4gICBhZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UKPiAKPiBh cyB3ZWxsLi4uCgpZZXMsIGFuZCBpdCBhbHNvIHN0cnVjayBtZSB0aGF0IEkgZm9yZ290IGF0IGxl YXN0IGFib3V0IHRoZSBob3RwbHVnLWdwaW8uCkl0J3MgdW51c2VkIG9uIHRoZSBUZXJlcyBhbmQg dGhlIFBpbmVib29rLCBidXQgaW4gdGhlb3J5IGl0J3MgYSB2YWxpZApwcm9wZXJ0eSwgd2hpY2gg Y2FuJ3QgYmUgYWRkZWQgYW55IG1vcmUgbm93LgoKCVRvcnN0ZW4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==