From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: Incorrect buffer handling in dw-hdmi bridge audio Date: Tue, 5 Nov 2019 16:02:15 +0000 Message-ID: <20191105160215.GQ25745@shell.armlinux.org.uk> References: <6ad19121-c0e3-d278-2943-ff93ef80353b@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 459D66EAD3 for ; Tue, 5 Nov 2019 16:02:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <6ad19121-c0e3-d278-2943-ff93ef80353b@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: Jernej Skrabec , Jonas Karlman , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMDUsIDIwMTkgYXQgMDk6MDc6NDNBTSArMDEwMCwgTmVpbCBBcm1zdHJvbmcg d3JvdGU6Cj4gSGksCj4gCj4gT24gMDUvMTEvMjAxOSAwODo1NSwgVGFrYXNoaSBJd2FpIHdyb3Rl Ogo+ID4gSGksCj4gPiAKPiA+IHdoaWxlIHJlY2VudGx5IHdvcmtpbmcgb24gdGhlIEFMU0EgbWVt b3J5IGFsbG9jYXRvciBBUEkgY2xlYW51cCwgSQo+ID4gbm90aWNlZCB0aGF0IGR3LWhkbWkgYnJp ZGdlIGRyaXZlciBzZWVtcyBkb2luZyB3ZWlyZCBhYm91dCB0aGUgYnVmZmVyCj4gPiBtYW5hZ2Vt ZW50LiAgSXQgcHJlLWFsbG9jYXRlcyB0aGUgdXN1YWwgZGV2aWNlIGJ1ZmZlcnMgZnVsbHkgYXQg dGhlCj4gPiBwcm9iZSB0aW1lLCB3aGlsZSBlYWNoIHN0cmVhbSBhbGxvY2F0ZXMgdGhlIGJ1ZmZl ciB2aWEgdGhlIHZtYWxsb2MKPiA+IGhlbHBlcnMgYW5kIHJlcGxhY2VzIHdpdGggaXQgYXQgZWFj aCBvcGVuLgo+ID4gCj4gPiBJIGd1ZXNzIGl0J3Mgbm8gZXhwZWN0ZWQgYmVoYXZpb3I/ICBJdCdz IGJhc2ljYWxseSBhIGZ1bGwgd2FzdGUgb2YKPiA+IHJlc291cmNlcywgYW5kIHRoZSB2bWFsbG9j IGJ1ZmZlciBpc24ndCBndWFyYW50ZWVkIHRvIHdvcmsgd2VsbCBmb3IKPiA+IG1tYXAgb24gZXZl cnkgYXJjaGl0ZWN0dXJlLgo+ID4gCj4gPiBCZWxvdyBpcyB0aGUgcGF0Y2ggdG8gYWRkcmVzcyBp dC4gIENhbiBhbnlvbmUgY2hlY2sgd2hldGhlciB0aGlzIHN0aWxsCj4gPiB3b3Jrcz8KPiAKPiBJ IGRvbid0IGhhdmUgdGhlIHNldHVwIHRvIGNoZWNrLCBidXQgdGhpcyBoYXMgYmVlbiBwdXNoZWQg YnkgUnVzc2VsbCBJIEFkZGVkIGluIENDLgo+IAo+IEkgYWxzbyBhZGRlZCB0aGUgaW14IG1haW50 YWluZXIgc2luY2UgaXQncyAoQUZBSUspIG9ubHkgdXNlZCBvbiBpTVggU29Dcy4KPiAKPiBOZWls Cj4gCj4gPiAKPiA+IFNpbmNlIEkgaGF2ZSBhIGNsZWFudXAgc2VyaWVzIGFuZCB0aGlzIGlzIGlu dm9sdmVkLCBJJ2QgbGlrZSB0byB0YWtlCj4gPiB0aGUgZml4IHRocm91Z2ggbXkgdHJlZSBvbmNl IGFmdGVyIGl0J3MgY29uZmlybWVkIChhbmQgZ2V0IEFDSyBpZgo+ID4gcG9zc2libGUpLgo+ID4g Cj4gPiAKPiA+IFRoYW5rcyEKPiA+IAo+ID4gVGFrYXNoaQo+ID4gCj4gPiAtLSA4PCAtLQo+ID4g RnJvbTogVGFrYXNoaSBJd2FpIDx0aXdhaUBzdXNlLmRlPgo+ID4gU3ViamVjdDogW1BBVENIXSBk cm0vYnJpZGdlOiBkdy1oZG1pOiBGaXggdGhlIGluY29ycmVjdCBidWZmZXIgYWxsb2NhdGlvbnMK PiA+IAo+ID4gVGhlIGRyaXZlciBzZXRzIHVwIHRoZSBidWZmZXIgcHJlYWxsb2NhdGlvbiB3aXRo IFNORFJWX0RNQV9UWVBFX0RFViwKPiA+IHdoaWxlIGl0IHJlLWFsbG9jYXRlcyBhbmQgcmVsZWFz ZXMgdm1hbGxvYyBwYWdlcy4gIFRoaXMgaXMgbm90IG9ubHkgYQo+ID4gbG90IG9mIHdhc3RlIHJl c291cmNlcyBidXQgYWxzbyBjYXVzZXMgdGhlIG1tYXAgbWFsZnVuY3Rpb24uCj4gPiAKPiA+IENo YW5nZSAvIGRyb3AgdGhlIHZtYWxsb2MtcmVsYXRlZCBjb2RlIGFuZCB1c2UgdGhlIHN0YW5kYXJk IGJ1ZmZlcgo+ID4gYWxsb2NhdGlvbiAvIHJlbGVhc2UgY29kZSBpbnN0ZWFkLgoKSSB0aGluayBn ZXR0aW5nIHJpZCBvZiB0aGUgdm1hbGxvYyBjb2RlIGhlcmUgaXMgYSBtaXN0YWtlIC0gSSBzZWVt IHRvCnJlbWVtYmVyIHVzaW5nIHRoZSBzdGFuZGFyZCBidWZmZXIgYWxsb2NhdGlvbiBjYXVzZXMg ZmFpbHVyZXMsIGR1ZSB0bwptZW1vcnkgZnJhZ21lbnRhdGlvbi4gIFNpbmNlIHRoZSBoYXJkd2Fy ZSBpcyBsaW1pdGVkIHRvIERNQSBmcm9tIGF0Cm1vc3Qgb25lIHBhZ2UsIHRoZXJlIGlzIG5vIHJl YXNvbiBmb3IgdGhpcyBkcml2ZXIgdG8gcmVxdWlyZSBjb250aWd1b3VzCnBhZ2VzLCBoZW5jZSB3 aHkgaXQncyB1c2luZyAtIGFuZCBzaG91bGQgdXNlIC0gdm1hbGxvYyBwYWdlcy4gIHZtYWxsb2MK aXMgd2F5IGtpbmRlciB0byB0aGUgTU0gc3Vic3lzdGVtIHRoYW4gdHJ5aW5nIHRvIHJlcXVlc3Qg bGFyZ2Ugb3JkZXIKY29udGlndW91cyBwYWdlcy4KClNvLCBOQUsgb24gdGhpcyBwYXRjaC4KCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS1haGItYXVkaW8u YyB8IDYgKystLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lu b3BzeXMvZHctaGRtaS1haGItYXVkaW8uYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctaGRtaS1haGItYXVkaW8uYwo+ID4gaW5kZXggMmI3NTM5NzAxYjQyLi44ZmU3YTZlOGZm OTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhk bWktYWhiLWF1ZGlvLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMv ZHctaGRtaS1haGItYXVkaW8uYwo+ID4gQEAgLTM4NCwxNSArMzg0LDE0IEBAIHN0YXRpYyBpbnQg ZHdfaGRtaV9jbG9zZShzdHJ1Y3Qgc25kX3BjbV9zdWJzdHJlYW0gKnN1YnN0cmVhbSkKPiA+ICAK PiA+ICBzdGF0aWMgaW50IGR3X2hkbWlfaHdfZnJlZShzdHJ1Y3Qgc25kX3BjbV9zdWJzdHJlYW0g KnN1YnN0cmVhbSkKPiA+ICB7Cj4gPiAtCXJldHVybiBzbmRfcGNtX2xpYl9mcmVlX3ZtYWxsb2Nf YnVmZmVyKHN1YnN0cmVhbSk7Cj4gPiArCXJldHVybiBzbmRfcGNtX2xpYl9mcmVlX3BhZ2VzKHN1 YnN0cmVhbSk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgZHdfaGRtaV9od19wYXJhbXMo c3RydWN0IHNuZF9wY21fc3Vic3RyZWFtICpzdWJzdHJlYW0sCj4gPiAgCXN0cnVjdCBzbmRfcGNt X2h3X3BhcmFtcyAqcGFyYW1zKQo+ID4gIHsKPiA+ICAJLyogQWxsb2NhdGUgdGhlIFBDTSBydW50 aW1lIGJ1ZmZlciwgd2hpY2ggaXMgZXhwb3NlZCB0byB1c2Vyc3BhY2UuICovCj4gPiAtCXJldHVy biBzbmRfcGNtX2xpYl9hbGxvY192bWFsbG9jX2J1ZmZlcihzdWJzdHJlYW0sCj4gPiAtCQkJCQkJ cGFyYW1zX2J1ZmZlcl9ieXRlcyhwYXJhbXMpKTsKPiA+ICsJcmV0dXJuIHNuZF9wY21fbGliX21h bGxvY19wYWdlcyhzdWJzdHJlYW0sIHBhcmFtc19idWZmZXJfYnl0ZXMocGFyYW1zKSk7Cj4gPiAg fQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgZHdfaGRtaV9wcmVwYXJlKHN0cnVjdCBzbmRfcGNtX3N1 YnN0cmVhbSAqc3Vic3RyZWFtKQo+ID4gQEAgLTUxMSw3ICs1MTAsNiBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IHNuZF9wY21fb3BzIHNuZF9kd19oZG1pX29wcyA9IHsKPiA+ICAJLnByZXBhcmUgPSBk d19oZG1pX3ByZXBhcmUsCj4gPiAgCS50cmlnZ2VyID0gZHdfaGRtaV90cmlnZ2VyLAo+ID4gIAku cG9pbnRlciA9IGR3X2hkbWlfcG9pbnRlciwKPiA+IC0JLnBhZ2UgPSBzbmRfcGNtX2xpYl9nZXRf dm1hbGxvY19wYWdlLAo+ID4gIH07Cj4gPiAgCj4gPiAgc3RhdGljIGludCBzbmRfZHdfaGRtaV9w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gCj4gCj4gCgotLSAKUk1LJ3Mg UGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNo ZXMvCkZUVEMgYnJvYWRiYW5kIGZvciAwLjhtaWxlIGxpbmUgaW4gc3VidXJiaWE6IHN5bmMgYXQg MTIuMU1icHMgZG93biA2MjJrYnBzIHVwCkFjY29yZGluZyB0byBzcGVlZHRlc3QubmV0OiAxMS45 TWJwcyBkb3duIDUwMGticHMgdXAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs