From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Date: Tue, 5 Nov 2019 21:53:23 +0200 Message-ID: <20191105195323.GC4869@pendragon.ideasonboard.com> References: <20191014184320.GA161094@dtor-ws> <20191105004050.GU57214@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter Cc: Linus Walleij , Dmitry Torokhov , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , David Airlie , Heikki Krogerus , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org Hi Daniel, On Tue, Nov 05, 2019 at 04:41:41PM +0100, Daniel Vetter wrote: > On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij wrote: > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov wrote: > > > On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote: > > > > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but > > > > works with arbitrary firmware node. > > > > > > > > Reviewed-by: Laurent Pinchart > > > > Signed-off-by: Dmitry Torokhov > > > > --- > > > > > > > > Andrzej, Neil, > > > > > > > > This depends on the new code that can be bound in > > > > ib-fwnode-gpiod-get-index immutable branch of Linus' Walleij tree: > > > > > > > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git ib-fwnode-gpiod-get-index > > > > > > > > I hope that it would be possible to pull in this immutable branch and > > > > not wait until after 5.5 merge window, or, alternatively, merge through > > > > Linus Walleij's tree. > > > > > > Any chance this could be merged, please? > > > > I'm happy to merge it into the GPIO tree if some DRM maintainer can > > provide an ACK. > > Ack. > > > Getting ACK from DRM people is problematic and a bit of friction in the > > community, DVetter usually advice to seek mutual reviews etc, but IMO > > it would be better if some people felt more compelled to review stuff > > eventually. (And that has the problem that it doesn't scale.) > > This has a review already plus if you merge your implied review. > That's more than good enough imo, so not seeing the issue here? Isn't the issue that the patch should have been picked by someone for drm-misc ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5F7C47E49 for ; Tue, 5 Nov 2019 19:53:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14EDC21D6C for ; Tue, 5 Nov 2019 19:53:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14EDC21D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 874AF6E82E; Tue, 5 Nov 2019 19:53:36 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 848506E82E for ; Tue, 5 Nov 2019 19:53:35 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E3F9559; Tue, 5 Nov 2019 20:53:33 +0100 (CET) Date: Tue, 5 Nov 2019 21:53:23 +0200 From: Laurent Pinchart To: Daniel Vetter Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Message-ID: <20191105195323.GC4869@pendragon.ideasonboard.com> References: <20191014184320.GA161094@dtor-ws> <20191105004050.GU57214@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1572983614; bh=fcuygVB2SplZS3Dkx3i6Moc1rRXaeuVQvASKaqu5weI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CSiClPhOy6tIRIGYDNTwVfLRgW7hCJ0UlYOb3cMGsCef0GXSd+CDkKf32Ia/rS9t0 dahaFXWD+U+haYq/otzMkkenbLXXcnTkp2CCICtnxKPuu7dq3prkt0krg6hPaBWAwr /pFGt+CwP2k98+RuJZ7vLm3QfEoJTrBrmhlaTMfI= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Heikki Krogerus , Jonas Karlman , David Airlie , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , Neil Armstrong Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191105195323.FEp1_ih2QuOHUZmQtrGbNM4uoP6A9pcgbYn4d_vtIAE@z> SGkgRGFuaWVsLAoKT24gVHVlLCBOb3YgMDUsIDIwMTkgYXQgMDQ6NDE6NDFQTSArMDEwMCwgRGFu aWVsIFZldHRlciB3cm90ZToKPiBPbiBUdWUsIE5vdiA1LCAyMDE5IGF0IDQ6MjkgUE0gTGludXMg V2FsbGVpaiB3cm90ZToKPiA+IE9uIFR1ZSwgTm92IDUsIDIwMTkgYXQgMTo0MCBBTSBEbWl0cnkg VG9yb2tob3Ygd3JvdGU6Cj4gPiA+IE9uIE1vbiwgT2N0IDE0LCAyMDE5IGF0IDExOjQzOjIwQU0g LTA3MDAsIERtaXRyeSBUb3Jva2hvdiB3cm90ZToKPiA+Cj4gPiA+ID4gSW5zdGVhZCBvZiBmd25v ZGVfZ2V0X25hbWVkX2dwaW9kKCkgdGhhdCBJIHBsYW4gdG8gaGlkZSBhd2F5LCBsZXQncyB1c2UK PiA+ID4gPiB0aGUgbmV3IGZ3bm9kZV9ncGlvZF9nZXRfaW5kZXgoKSB0aGF0IG1pbWljcyBncGlv ZF9nZXRfaW5kZXgoKSwgYnV0Cj4gPiA+ID4gd29ya3Mgd2l0aCBhcmJpdHJhcnkgZmlybXdhcmUg bm9kZS4KPiA+ID4gPgo+ID4gPiA+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRG1p dHJ5IFRvcm9raG92IDxkbWl0cnkudG9yb2tob3ZAZ21haWwuY29tPgo+ID4gPiA+IC0tLQo+ID4g PiA+Cj4gPiA+ID4gQW5kcnplaiwgTmVpbCwKPiA+ID4gPgo+ID4gPiA+IFRoaXMgZGVwZW5kcyBv biB0aGUgbmV3IGNvZGUgdGhhdCBjYW4gYmUgYm91bmQgaW4KPiA+ID4gPiBpYi1md25vZGUtZ3Bp b2QtZ2V0LWluZGV4IGltbXV0YWJsZSBicmFuY2ggb2YgTGludXMnIFdhbGxlaWogdHJlZToKPiA+ ID4gPgo+ID4gPiA+ICAgICAgICAgZ2l0IHB1bGwgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3Nj bS9saW51eC9rZXJuZWwvZ2l0L2xpbnVzdy9saW51eC1ncGlvLmdpdCBpYi1md25vZGUtZ3Bpb2Qt Z2V0LWluZGV4Cj4gPiA+ID4KPiA+ID4gPiBJIGhvcGUgdGhhdCBpdCB3b3VsZCBiZSBwb3NzaWJs ZSB0byBwdWxsIGluIHRoaXMgaW1tdXRhYmxlIGJyYW5jaCBhbmQKPiA+ID4gPiBub3Qgd2FpdCB1 bnRpbCBhZnRlciA1LjUgbWVyZ2Ugd2luZG93LCBvciwgYWx0ZXJuYXRpdmVseSwgbWVyZ2UgdGhy b3VnaAo+ID4gPiA+IExpbnVzIFdhbGxlaWoncyB0cmVlLgo+ID4gPgo+ID4gPiBBbnkgY2hhbmNl IHRoaXMgY291bGQgYmUgbWVyZ2VkLCBwbGVhc2U/Cj4gPgo+ID4gSSdtIGhhcHB5IHRvIG1lcmdl IGl0IGludG8gdGhlIEdQSU8gdHJlZSBpZiBzb21lIERSTSBtYWludGFpbmVyIGNhbgo+ID4gcHJv dmlkZSBhbiBBQ0suCj4gCj4gQWNrLgo+IAo+ID4gR2V0dGluZyBBQ0sgZnJvbSBEUk0gcGVvcGxl IGlzIHByb2JsZW1hdGljIGFuZCBhIGJpdCBvZiBmcmljdGlvbiBpbiB0aGUKPiA+IGNvbW11bml0 eSwgRFZldHRlciB1c3VhbGx5IGFkdmljZSB0byBzZWVrIG11dHVhbCByZXZpZXdzIGV0YywgYnV0 IElNTwo+ID4gaXQgd291bGQgYmUgYmV0dGVyIGlmIHNvbWUgcGVvcGxlIGZlbHQgbW9yZSBjb21w ZWxsZWQgdG8gcmV2aWV3IHN0dWZmCj4gPiBldmVudHVhbGx5LiAoQW5kIHRoYXQgaGFzIHRoZSBw cm9ibGVtIHRoYXQgaXQgZG9lc24ndCBzY2FsZS4pCj4gCj4gVGhpcyBoYXMgYSByZXZpZXcgYWxy ZWFkeSBwbHVzIGlmIHlvdSBtZXJnZSB5b3VyIGltcGxpZWQgcmV2aWV3Lgo+IFRoYXQncyBtb3Jl IHRoYW4gZ29vZCBlbm91Z2ggaW1vLCBzbyBub3Qgc2VlaW5nIHRoZSBpc3N1ZSBoZXJlPwoKSXNu J3QgdGhlIGlzc3VlIHRoYXQgdGhlIHBhdGNoIHNob3VsZCBoYXZlIGJlZW4gcGlja2VkIGJ5IHNv bWVvbmUgZm9yCmRybS1taXNjID8KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=