From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v4 13/14] drm/mxsfb: Add support for horizontal stride
Date: Wed, 6 Nov 2019 00:12:30 +0200
Message-ID: <20191105221230.GI4869@pendragon.ideasonboard.com>
References: <1567078215-31601-1-git-send-email-robert.chiras@nxp.com>
 <1567078215-31601-14-git-send-email-robert.chiras@nxp.com>
 <3f346b1f809e77d343117dabc00c0402@agner.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <3f346b1f809e77d343117dabc00c0402@agner.ch>
Sender: linux-kernel-owner@vger.kernel.org
To: Stefan Agner <stefan@agner.ch>
Cc: Robert Chiras <robert.chiras@nxp.com>, Marek Vasut <marex@denx.de>, Mark Rutland <mark.rutland@arm.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, Guido =?utf-8?Q?G=C3=BCnther?= <agx@sigxcpu.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, linux-arm-kernel@lists.infradead.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, Oct 14, 2019 at 02:40:55PM +0200, Stefan Agner wrote:
> Hi Robert,
> 
> Sorry it took me so long to have a closer look at this patchset.
> 
> I will definitely merge part of it, but this particular patch actually
> breaks i.MX 7. I have vertical stripes on my display with this patch
> applied (using Weston with DRM backend). Not sure why this exactly
> happens, from what I understand this should only affect IP Version 4.

The code tests for ipversion >= 4, which should match the i.MX7.

> Some notes below:
> 
> On 2019-08-29 13:30, Robert Chiras wrote:
> > Besides the eLCDIF block, there is another IP block, used in the past
> > for EPDC panels. Since the iMX.8mq doesn't have an EPDC connector, this
> > block is not documented, but we can use it to do additional operations
> > on the frame buffer.
> 
> Hm, but this block is part of the ELCDIF block, in terms of clock, power
> domain etc?

On i.MX7 the EPDC IP core is present as the SoC has an EPDC output. Can
the EPDC be used to control LCDIF stride on the i.MX7 too ?

> > In this case, we can use the pigeon registers from this IP block in
> > order to do horizontal crop on the frame buffer processed by the eLCDIF
> > block.
> > 
> > Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
> > Tested-by: Guido Günther <agx@sigxcpu.org>
> > ---
> >  drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 ++++++++++++++++++++++++++++++++++++--
> >  drivers/gpu/drm/mxsfb/mxsfb_drv.c  |  1 +
> >  drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16 ++++++++
> >  3 files changed, 92 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > index a12f53d..317575e 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > @@ -15,6 +15,7 @@
> >  
> >  #include <video/videomode.h>
> >  
> > +#include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> >  #include <drm/drm_crtc.h>
> >  #include <drm/drm_fb_cma_helper.h>
> > @@ -435,13 +436,66 @@ void mxsfb_crtc_disable(struct mxsfb_drm_private *mxsfb)
> >  	clk_disable_unprepare(mxsfb->clk_axi);
> >  }
> >  
> > +void mxsfb_set_fb_hcrop(struct mxsfb_drm_private *mxsfb, u32 src_w, u32 fb_w)
> > +{
> > +	u32 mask_cnt, htotal, hcount;
> > +	u32 vdctrl2, vdctrl3, vdctrl4, transfer_count;
> > +	u32 pigeon_12_0, pigeon_12_1, pigeon_12_2;
> > +
> > +	if (src_w == fb_w) {
> > +		writel(0x0, mxsfb->base + HW_EPDC_PIGEON_12_0);
> > +		writel(0x0, mxsfb->base + HW_EPDC_PIGEON_12_1);
> > +
> > +		return;
> > +	}
> > +
> > +	transfer_count = readl(mxsfb->base + LCDC_V4_TRANSFER_COUNT);
> > +	hcount = TRANSFER_COUNT_GET_HCOUNT(transfer_count);
> > +
> > +	transfer_count &= ~TRANSFER_COUNT_SET_HCOUNT(0xffff);
> > +	transfer_count |= TRANSFER_COUNT_SET_HCOUNT(fb_w);
> > +	writel(transfer_count, mxsfb->base + LCDC_V4_TRANSFER_COUNT);
> > +
> > +	vdctrl2 = readl(mxsfb->base + LCDC_VDCTRL2);
> > +	htotal  = VDCTRL2_GET_HSYNC_PERIOD(vdctrl2);
> > +	htotal  += fb_w - hcount;
> > +	vdctrl2 &= ~VDCTRL2_SET_HSYNC_PERIOD(0x3ffff);
> > +	vdctrl2 |= VDCTRL2_SET_HSYNC_PERIOD(htotal);
> > +	writel(vdctrl2, mxsfb->base + LCDC_VDCTRL2);
> > +
> > +	vdctrl4 = readl(mxsfb->base + LCDC_VDCTRL4);
> > +	vdctrl4 &= ~SET_DOTCLK_H_VALID_DATA_CNT(0x3ffff);
> > +	vdctrl4 |= SET_DOTCLK_H_VALID_DATA_CNT(fb_w);
> > +	writel(vdctrl4, mxsfb->base + LCDC_VDCTRL4);
> > +
> > +	/* configure related pigeon registers */
> > +	vdctrl3  = readl(mxsfb->base + LCDC_VDCTRL3);
> > +	mask_cnt = GET_HOR_WAIT_CNT(vdctrl3) - 5;
> > +
> > +	pigeon_12_0 = PIGEON_12_0_SET_STATE_MASK(0x24)		|
> > +		      PIGEON_12_0_SET_MASK_CNT(mask_cnt)	|
> > +		      PIGEON_12_0_SET_MASK_CNT_SEL(0x6)		|
> > +		      PIGEON_12_0_POL_ACTIVE_LOW		|
> > +		      PIGEON_12_0_EN;
> > +	writel(pigeon_12_0, mxsfb->base + HW_EPDC_PIGEON_12_0);
> > +
> > +	pigeon_12_1 = PIGEON_12_1_SET_CLR_CNT(src_w) |
> > +		      PIGEON_12_1_SET_SET_CNT(0x0);
> > +	writel(pigeon_12_1, mxsfb->base + HW_EPDC_PIGEON_12_1);
> > +
> > +	pigeon_12_2 = 0x0;
> > +	writel(pigeon_12_2, mxsfb->base + HW_EPDC_PIGEON_12_2);
> > +}
> > +
> >  void mxsfb_plane_atomic_update(struct mxsfb_drm_private *mxsfb,
> >  			       struct drm_plane_state *state)
> >  {
> >  	struct drm_simple_display_pipe *pipe = &mxsfb->pipe;
> >  	struct drm_crtc *crtc = &pipe->crtc;
> > +	struct drm_plane_state *new_state = pipe->plane.state;
> > +	struct drm_framebuffer *fb = pipe->plane.state->fb;
> >  	struct drm_pending_vblank_event *event;
> > -	dma_addr_t paddr;
> > +	u32 fb_addr, src_off, src_w, stride, cpp = 0;
> 
> dma_addr_t seems to be the better type here, why change?
> 
> >  
> >  	spin_lock_irq(&crtc->dev->event_lock);
> >  	event = crtc->state->event;
> > @@ -456,10 +510,27 @@ void mxsfb_plane_atomic_update(struct
> > mxsfb_drm_private *mxsfb,
> >  	}
> >  	spin_unlock_irq(&crtc->dev->event_lock);
> >  
> > -	paddr = mxsfb_get_fb_paddr(mxsfb);
> > -	if (paddr) {
> > +	if (!fb)
> > +		return;
> > +
> > +	fb_addr = mxsfb_get_fb_paddr(mxsfb);
> > +	if (mxsfb->devdata->ipversion >= 4) {
> > +		cpp = fb->format->cpp[0];
> > +		src_off = (new_state->src_y >> 16) * fb->pitches[0] +
> > +			  (new_state->src_x >> 16) * cpp;
> > +		fb_addr += fb->offsets[0] + src_off;
> > +	}
> > +
> > +	if (fb_addr) {
> >  		clk_prepare_enable(mxsfb->clk_axi);
> > -		writel(paddr, mxsfb->base + mxsfb->devdata->next_buf);
> > +		writel(fb_addr, mxsfb->base + mxsfb->devdata->next_buf);
> >  		clk_disable_unprepare(mxsfb->clk_axi);
> >  	}
> > +
> > +	if (mxsfb->devdata->ipversion >= 4 &&
> > +	    unlikely(drm_atomic_crtc_needs_modeset(new_state->crtc->state))) {
> > +		stride = DIV_ROUND_UP(fb->pitches[0], cpp);
> > +		src_w = new_state->src_w >> 16;
> > +		mxsfb_set_fb_hcrop(mxsfb, src_w, stride);
> > +	}

I doubt userspace will appreciate the stride being ignored on older
SoCs.

> >  }
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > index 888b520..06d3bf0 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > @@ -133,6 +133,7 @@ static int mxsfb_atomic_helper_check(struct drm_device *dev,
> >  		if (old_bpp != new_bpp)
> >  			new_state->mode_changed = true;
> >  	}
> > +
> 
> Can you also drop this unrelated change?
> 
> >  	return ret;
> >  }
> >  
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_regs.h
> > b/drivers/gpu/drm/mxsfb/mxsfb_regs.h
> > index 0f63ba1..df3279b 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_regs.h
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_regs.h
> > @@ -145,6 +145,22 @@
> >  #define DEBUG0_HSYNC			BIT(26)
> >  #define DEBUG0_VSYNC			BIT(25)
> >  
> > +/* pigeon registers for crop */
> > +#define HW_EPDC_PIGEON_12_0		0xb00
> > +#define HW_EPDC_PIGEON_12_1		0xb10
> > +#define HW_EPDC_PIGEON_12_2		0xb20
> > +
> > +#define PIGEON_12_0_SET_STATE_MASK(x)	REG_PUT((x), 31, 24)
> > +#define PIGEON_12_0_SET_MASK_CNT(x)	REG_PUT((x), 23, 12)
> > +#define PIGEON_12_0_SET_MASK_CNT_SEL(x)	REG_PUT((x), 11,  8)
> > +#define PIGEON_12_0_SET_OFFSET(x)	REG_PUT((x),  7,  4)
> > +#define PIGEON_12_0_SET_INC_SEL(x)	REG_PUT((x),  3,  2)
> > +#define PIGEON_12_0_POL_ACTIVE_LOW	BIT(1)
> > +#define PIGEON_12_0_EN			BIT(0)
> > +
> > +#define PIGEON_12_1_SET_CLR_CNT(x)	REG_PUT((x), 31, 16)
> > +#define PIGEON_12_1_SET_SET_CNT(x)	REG_PUT((x), 15,  0)
> > +
> >  #define MXSFB_MIN_XRES			120
> >  #define MXSFB_MIN_YRES			120
> >  #define MXSFB_MAX_XRES			0xffff

-- 
Regards,

Laurent Pinchart

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=rB/g=Y5=lists.freedesktop.org=dri-devel-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1075AC47E49
	for <dri-devel@archiver.kernel.org>; Tue,  5 Nov 2019 22:12:43 +0000 (UTC)
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id D3CD421929
	for <dri-devel@archiver.kernel.org>; Tue,  5 Nov 2019 22:12:42 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3CD421929
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3A5926E15C;
	Tue,  5 Nov 2019 22:12:42 +0000 (UTC)
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
 [213.167.242.64])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AAB8D6E15C
 for <dri-devel@lists.freedesktop.org>; Tue,  5 Nov 2019 22:12:40 +0000 (UTC)
Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi
 [81.175.216.236])
 by perceval.ideasonboard.com (Postfix) with ESMTPSA id DDF24559;
 Tue,  5 Nov 2019 23:12:38 +0100 (CET)
Date: Wed, 6 Nov 2019 00:12:30 +0200
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stefan Agner <stefan@agner.ch>
Subject: Re: [PATCH v4 13/14] drm/mxsfb: Add support for horizontal stride
Message-ID: <20191105221230.GI4869@pendragon.ideasonboard.com>
References: <1567078215-31601-1-git-send-email-robert.chiras@nxp.com>
 <1567078215-31601-14-git-send-email-robert.chiras@nxp.com>
 <3f346b1f809e77d343117dabc00c0402@agner.ch>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <3f346b1f809e77d343117dabc00c0402@agner.ch>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=ideasonboard.com; s=mail; t=1572991959;
 bh=l6tO4H9CE+rZr6x6HqO9Q+l13cU4DGErjjFmjqJ0BLw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=kxdSiyxH9GCuLmW8Fn6JxZ69vA/vPqlAv+IuJndPuUHnDfPgU6Pd6guisvGqUiomx
 pnPIvCyFHHrIhezrgXcwhC7x71S6mTm4LSw8O8ddpXHubUb581OINI1n72G0s/deRE
 pVuGWIUeqQAeYQKHFlL/dLo+t+0gQYosjCvjj4Iw=
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
 <dri-devel.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Cc: Marek Vasut <marex@denx.de>, Mark Rutland <mark.rutland@arm.com>,
 devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
 Guido =?utf-8?Q?G=C3=BCnther?= <agx@sigxcpu.org>, linux-kernel@vger.kernel.org,
 dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
 NXP Linux Team <linux-imx@nxp.com>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Robert Chiras <robert.chiras@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
 Sascha Hauer <s.hauer@pengutronix.de>, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Message-ID: <20191105221230.sE2okOUuU-dS9TGrsQmShUHdcS6eUhtaYR5uP4ibKtI@z>

T24gTW9uLCBPY3QgMTQsIDIwMTkgYXQgMDI6NDA6NTVQTSArMDIwMCwgU3RlZmFuIEFnbmVyIHdy
b3RlOgo+IEhpIFJvYmVydCwKPiAKPiBTb3JyeSBpdCB0b29rIG1lIHNvIGxvbmcgdG8gaGF2ZSBh
IGNsb3NlciBsb29rIGF0IHRoaXMgcGF0Y2hzZXQuCj4gCj4gSSB3aWxsIGRlZmluaXRlbHkgbWVy
Z2UgcGFydCBvZiBpdCwgYnV0IHRoaXMgcGFydGljdWxhciBwYXRjaCBhY3R1YWxseQo+IGJyZWFr
cyBpLk1YIDcuIEkgaGF2ZSB2ZXJ0aWNhbCBzdHJpcGVzIG9uIG15IGRpc3BsYXkgd2l0aCB0aGlz
IHBhdGNoCj4gYXBwbGllZCAodXNpbmcgV2VzdG9uIHdpdGggRFJNIGJhY2tlbmQpLiBOb3Qgc3Vy
ZSB3aHkgdGhpcyBleGFjdGx5Cj4gaGFwcGVucywgZnJvbSB3aGF0IEkgdW5kZXJzdGFuZCB0aGlz
IHNob3VsZCBvbmx5IGFmZmVjdCBJUCBWZXJzaW9uIDQuCgpUaGUgY29kZSB0ZXN0cyBmb3IgaXB2
ZXJzaW9uID49IDQsIHdoaWNoIHNob3VsZCBtYXRjaCB0aGUgaS5NWDcuCgo+IFNvbWUgbm90ZXMg
YmVsb3c6Cj4gCj4gT24gMjAxOS0wOC0yOSAxMzozMCwgUm9iZXJ0IENoaXJhcyB3cm90ZToKPiA+
IEJlc2lkZXMgdGhlIGVMQ0RJRiBibG9jaywgdGhlcmUgaXMgYW5vdGhlciBJUCBibG9jaywgdXNl
ZCBpbiB0aGUgcGFzdAo+ID4gZm9yIEVQREMgcGFuZWxzLiBTaW5jZSB0aGUgaU1YLjhtcSBkb2Vz
bid0IGhhdmUgYW4gRVBEQyBjb25uZWN0b3IsIHRoaXMKPiA+IGJsb2NrIGlzIG5vdCBkb2N1bWVu
dGVkLCBidXQgd2UgY2FuIHVzZSBpdCB0byBkbyBhZGRpdGlvbmFsIG9wZXJhdGlvbnMKPiA+IG9u
IHRoZSBmcmFtZSBidWZmZXIuCj4gCj4gSG0sIGJ1dCB0aGlzIGJsb2NrIGlzIHBhcnQgb2YgdGhl
IEVMQ0RJRiBibG9jaywgaW4gdGVybXMgb2YgY2xvY2ssIHBvd2VyCj4gZG9tYWluIGV0Yz8KCk9u
IGkuTVg3IHRoZSBFUERDIElQIGNvcmUgaXMgcHJlc2VudCBhcyB0aGUgU29DIGhhcyBhbiBFUERD
IG91dHB1dC4gQ2FuCnRoZSBFUERDIGJlIHVzZWQgdG8gY29udHJvbCBMQ0RJRiBzdHJpZGUgb24g
dGhlIGkuTVg3IHRvbyA/Cgo+ID4gSW4gdGhpcyBjYXNlLCB3ZSBjYW4gdXNlIHRoZSBwaWdlb24g
cmVnaXN0ZXJzIGZyb20gdGhpcyBJUCBibG9jayBpbgo+ID4gb3JkZXIgdG8gZG8gaG9yaXpvbnRh
bCBjcm9wIG9uIHRoZSBmcmFtZSBidWZmZXIgcHJvY2Vzc2VkIGJ5IHRoZSBlTENESUYKPiA+IGJs
b2NrLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBSb2JlcnQgQ2hpcmFzIDxyb2JlcnQuY2hpcmFz
QG54cC5jb20+Cj4gPiBUZXN0ZWQtYnk6IEd1aWRvIEfDvG50aGVyIDxhZ3hAc2lneGNwdS5vcmc+
Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbXhzZmIvbXhzZmJfY3J0Yy5jIHwgNzkgKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v
bXhzZmIvbXhzZmJfZHJ2LmMgIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNm
Yl9yZWdzLmggfCAxNiArKysrKysrKwo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgOTIgaW5zZXJ0aW9u
cygrKSwgNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9teHNmYi9teHNmYl9jcnRjLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2Ny
dGMuYwo+ID4gaW5kZXggYTEyZjUzZC4uMzE3NTc1ZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9teHNmYi9teHNmYl9jcnRjLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9teHNm
Yi9teHNmYl9jcnRjLmMKPiA+IEBAIC0xNSw2ICsxNSw3IEBACj4gPiAgCj4gPiAgI2luY2x1ZGUg
PHZpZGVvL3ZpZGVvbW9kZS5oPgo+ID4gIAo+ID4gKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pYy5o
Pgo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiA+ICAjaW5jbHVkZSA8
ZHJtL2RybV9jcnRjLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZmJfY21hX2hlbHBlci5oPgo+
ID4gQEAgLTQzNSwxMyArNDM2LDY2IEBAIHZvaWQgbXhzZmJfY3J0Y19kaXNhYmxlKHN0cnVjdCBt
eHNmYl9kcm1fcHJpdmF0ZSAqbXhzZmIpCj4gPiAgCWNsa19kaXNhYmxlX3VucHJlcGFyZShteHNm
Yi0+Y2xrX2F4aSk7Cj4gPiAgfQo+ID4gIAo+ID4gK3ZvaWQgbXhzZmJfc2V0X2ZiX2hjcm9wKHN0
cnVjdCBteHNmYl9kcm1fcHJpdmF0ZSAqbXhzZmIsIHUzMiBzcmNfdywgdTMyIGZiX3cpCj4gPiAr
ewo+ID4gKwl1MzIgbWFza19jbnQsIGh0b3RhbCwgaGNvdW50Owo+ID4gKwl1MzIgdmRjdHJsMiwg
dmRjdHJsMywgdmRjdHJsNCwgdHJhbnNmZXJfY291bnQ7Cj4gPiArCXUzMiBwaWdlb25fMTJfMCwg
cGlnZW9uXzEyXzEsIHBpZ2Vvbl8xMl8yOwo+ID4gKwo+ID4gKwlpZiAoc3JjX3cgPT0gZmJfdykg
ewo+ID4gKwkJd3JpdGVsKDB4MCwgbXhzZmItPmJhc2UgKyBIV19FUERDX1BJR0VPTl8xMl8wKTsK
PiA+ICsJCXdyaXRlbCgweDAsIG14c2ZiLT5iYXNlICsgSFdfRVBEQ19QSUdFT05fMTJfMSk7Cj4g
PiArCj4gPiArCQlyZXR1cm47Cj4gPiArCX0KPiA+ICsKPiA+ICsJdHJhbnNmZXJfY291bnQgPSBy
ZWFkbChteHNmYi0+YmFzZSArIExDRENfVjRfVFJBTlNGRVJfQ09VTlQpOwo+ID4gKwloY291bnQg
PSBUUkFOU0ZFUl9DT1VOVF9HRVRfSENPVU5UKHRyYW5zZmVyX2NvdW50KTsKPiA+ICsKPiA+ICsJ
dHJhbnNmZXJfY291bnQgJj0gflRSQU5TRkVSX0NPVU5UX1NFVF9IQ09VTlQoMHhmZmZmKTsKPiA+
ICsJdHJhbnNmZXJfY291bnQgfD0gVFJBTlNGRVJfQ09VTlRfU0VUX0hDT1VOVChmYl93KTsKPiA+
ICsJd3JpdGVsKHRyYW5zZmVyX2NvdW50LCBteHNmYi0+YmFzZSArIExDRENfVjRfVFJBTlNGRVJf
Q09VTlQpOwo+ID4gKwo+ID4gKwl2ZGN0cmwyID0gcmVhZGwobXhzZmItPmJhc2UgKyBMQ0RDX1ZE
Q1RSTDIpOwo+ID4gKwlodG90YWwgID0gVkRDVFJMMl9HRVRfSFNZTkNfUEVSSU9EKHZkY3RybDIp
Owo+ID4gKwlodG90YWwgICs9IGZiX3cgLSBoY291bnQ7Cj4gPiArCXZkY3RybDIgJj0gflZEQ1RS
TDJfU0VUX0hTWU5DX1BFUklPRCgweDNmZmZmKTsKPiA+ICsJdmRjdHJsMiB8PSBWRENUUkwyX1NF
VF9IU1lOQ19QRVJJT0QoaHRvdGFsKTsKPiA+ICsJd3JpdGVsKHZkY3RybDIsIG14c2ZiLT5iYXNl
ICsgTENEQ19WRENUUkwyKTsKPiA+ICsKPiA+ICsJdmRjdHJsNCA9IHJlYWRsKG14c2ZiLT5iYXNl
ICsgTENEQ19WRENUUkw0KTsKPiA+ICsJdmRjdHJsNCAmPSB+U0VUX0RPVENMS19IX1ZBTElEX0RB
VEFfQ05UKDB4M2ZmZmYpOwo+ID4gKwl2ZGN0cmw0IHw9IFNFVF9ET1RDTEtfSF9WQUxJRF9EQVRB
X0NOVChmYl93KTsKPiA+ICsJd3JpdGVsKHZkY3RybDQsIG14c2ZiLT5iYXNlICsgTENEQ19WRENU
Ukw0KTsKPiA+ICsKPiA+ICsJLyogY29uZmlndXJlIHJlbGF0ZWQgcGlnZW9uIHJlZ2lzdGVycyAq
Lwo+ID4gKwl2ZGN0cmwzICA9IHJlYWRsKG14c2ZiLT5iYXNlICsgTENEQ19WRENUUkwzKTsKPiA+
ICsJbWFza19jbnQgPSBHRVRfSE9SX1dBSVRfQ05UKHZkY3RybDMpIC0gNTsKPiA+ICsKPiA+ICsJ
cGlnZW9uXzEyXzAgPSBQSUdFT05fMTJfMF9TRVRfU1RBVEVfTUFTSygweDI0KQkJfAo+ID4gKwkJ
ICAgICAgUElHRU9OXzEyXzBfU0VUX01BU0tfQ05UKG1hc2tfY250KQl8Cj4gPiArCQkgICAgICBQ
SUdFT05fMTJfMF9TRVRfTUFTS19DTlRfU0VMKDB4NikJCXwKPiA+ICsJCSAgICAgIFBJR0VPTl8x
Ml8wX1BPTF9BQ1RJVkVfTE9XCQl8Cj4gPiArCQkgICAgICBQSUdFT05fMTJfMF9FTjsKPiA+ICsJ
d3JpdGVsKHBpZ2Vvbl8xMl8wLCBteHNmYi0+YmFzZSArIEhXX0VQRENfUElHRU9OXzEyXzApOwo+
ID4gKwo+ID4gKwlwaWdlb25fMTJfMSA9IFBJR0VPTl8xMl8xX1NFVF9DTFJfQ05UKHNyY193KSB8
Cj4gPiArCQkgICAgICBQSUdFT05fMTJfMV9TRVRfU0VUX0NOVCgweDApOwo+ID4gKwl3cml0ZWwo
cGlnZW9uXzEyXzEsIG14c2ZiLT5iYXNlICsgSFdfRVBEQ19QSUdFT05fMTJfMSk7Cj4gPiArCj4g
PiArCXBpZ2Vvbl8xMl8yID0gMHgwOwo+ID4gKwl3cml0ZWwocGlnZW9uXzEyXzIsIG14c2ZiLT5i
YXNlICsgSFdfRVBEQ19QSUdFT05fMTJfMik7Cj4gPiArfQo+ID4gKwo+ID4gIHZvaWQgbXhzZmJf
cGxhbmVfYXRvbWljX3VwZGF0ZShzdHJ1Y3QgbXhzZmJfZHJtX3ByaXZhdGUgKm14c2ZiLAo+ID4g
IAkJCSAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+ICB7Cj4gPiAgCXN0
cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZSA9ICZteHNmYi0+cGlwZTsKPiA+ICAJ
c3RydWN0IGRybV9jcnRjICpjcnRjID0gJnBpcGUtPmNydGM7Cj4gPiArCXN0cnVjdCBkcm1fcGxh
bmVfc3RhdGUgKm5ld19zdGF0ZSA9IHBpcGUtPnBsYW5lLnN0YXRlOwo+ID4gKwlzdHJ1Y3QgZHJt
X2ZyYW1lYnVmZmVyICpmYiA9IHBpcGUtPnBsYW5lLnN0YXRlLT5mYjsKPiA+ICAJc3RydWN0IGRy
bV9wZW5kaW5nX3ZibGFua19ldmVudCAqZXZlbnQ7Cj4gPiAtCWRtYV9hZGRyX3QgcGFkZHI7Cj4g
PiArCXUzMiBmYl9hZGRyLCBzcmNfb2ZmLCBzcmNfdywgc3RyaWRlLCBjcHAgPSAwOwo+IAo+IGRt
YV9hZGRyX3Qgc2VlbXMgdG8gYmUgdGhlIGJldHRlciB0eXBlIGhlcmUsIHdoeSBjaGFuZ2U/Cj4g
Cj4gPiAgCj4gPiAgCXNwaW5fbG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7Cj4gPiAg
CWV2ZW50ID0gY3J0Yy0+c3RhdGUtPmV2ZW50Owo+ID4gQEAgLTQ1NiwxMCArNTEwLDI3IEBAIHZv
aWQgbXhzZmJfcGxhbmVfYXRvbWljX3VwZGF0ZShzdHJ1Y3QKPiA+IG14c2ZiX2RybV9wcml2YXRl
ICpteHNmYiwKPiA+ICAJfQo+ID4gIAlzcGluX3VubG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRf
bG9jayk7Cj4gPiAgCj4gPiAtCXBhZGRyID0gbXhzZmJfZ2V0X2ZiX3BhZGRyKG14c2ZiKTsKPiA+
IC0JaWYgKHBhZGRyKSB7Cj4gPiArCWlmICghZmIpCj4gPiArCQlyZXR1cm47Cj4gPiArCj4gPiAr
CWZiX2FkZHIgPSBteHNmYl9nZXRfZmJfcGFkZHIobXhzZmIpOwo+ID4gKwlpZiAobXhzZmItPmRl
dmRhdGEtPmlwdmVyc2lvbiA+PSA0KSB7Cj4gPiArCQljcHAgPSBmYi0+Zm9ybWF0LT5jcHBbMF07
Cj4gPiArCQlzcmNfb2ZmID0gKG5ld19zdGF0ZS0+c3JjX3kgPj4gMTYpICogZmItPnBpdGNoZXNb
MF0gKwo+ID4gKwkJCSAgKG5ld19zdGF0ZS0+c3JjX3ggPj4gMTYpICogY3BwOwo+ID4gKwkJZmJf
YWRkciArPSBmYi0+b2Zmc2V0c1swXSArIHNyY19vZmY7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaWYg
KGZiX2FkZHIpIHsKPiA+ICAJCWNsa19wcmVwYXJlX2VuYWJsZShteHNmYi0+Y2xrX2F4aSk7Cj4g
PiAtCQl3cml0ZWwocGFkZHIsIG14c2ZiLT5iYXNlICsgbXhzZmItPmRldmRhdGEtPm5leHRfYnVm
KTsKPiA+ICsJCXdyaXRlbChmYl9hZGRyLCBteHNmYi0+YmFzZSArIG14c2ZiLT5kZXZkYXRhLT5u
ZXh0X2J1Zik7Cj4gPiAgCQljbGtfZGlzYWJsZV91bnByZXBhcmUobXhzZmItPmNsa19heGkpOwo+
ID4gIAl9Cj4gPiArCj4gPiArCWlmIChteHNmYi0+ZGV2ZGF0YS0+aXB2ZXJzaW9uID49IDQgJiYK
PiA+ICsJICAgIHVubGlrZWx5KGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KG5ld19zdGF0
ZS0+Y3J0Yy0+c3RhdGUpKSkgewo+ID4gKwkJc3RyaWRlID0gRElWX1JPVU5EX1VQKGZiLT5waXRj
aGVzWzBdLCBjcHApOwo+ID4gKwkJc3JjX3cgPSBuZXdfc3RhdGUtPnNyY193ID4+IDE2Owo+ID4g
KwkJbXhzZmJfc2V0X2ZiX2hjcm9wKG14c2ZiLCBzcmNfdywgc3RyaWRlKTsKPiA+ICsJfQoKSSBk
b3VidCB1c2Vyc3BhY2Ugd2lsbCBhcHByZWNpYXRlIHRoZSBzdHJpZGUgYmVpbmcgaWdub3JlZCBv
biBvbGRlcgpTb0NzLgoKPiA+ICB9Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL214
c2ZiL214c2ZiX2Rydi5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9kcnYuYwo+
ID4gaW5kZXggODg4YjUyMC4uMDZkM2JmMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9teHNmYi9teHNmYl9kcnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2Zi
X2Rydi5jCj4gPiBAQCAtMTMzLDYgKzEzMyw3IEBAIHN0YXRpYyBpbnQgbXhzZmJfYXRvbWljX2hl
bHBlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAkJaWYgKG9sZF9icHAgIT0g
bmV3X2JwcCkKPiA+ICAJCQluZXdfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4gPiAgCX0K
PiA+ICsKPiAKPiBDYW4geW91IGFsc28gZHJvcCB0aGlzIHVucmVsYXRlZCBjaGFuZ2U/Cj4gCj4g
PiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9teHNmYi9teHNmYl9yZWdzLmgKPiA+IGIvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2Zi
X3JlZ3MuaAo+ID4gaW5kZXggMGY2M2JhMS4uZGYzMjc5YiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9teHNmYi9teHNmYl9yZWdzLmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9t
eHNmYi9teHNmYl9yZWdzLmgKPiA+IEBAIC0xNDUsNiArMTQ1LDIyIEBACj4gPiAgI2RlZmluZSBE
RUJVRzBfSFNZTkMJCQlCSVQoMjYpCj4gPiAgI2RlZmluZSBERUJVRzBfVlNZTkMJCQlCSVQoMjUp
Cj4gPiAgCj4gPiArLyogcGlnZW9uIHJlZ2lzdGVycyBmb3IgY3JvcCAqLwo+ID4gKyNkZWZpbmUg
SFdfRVBEQ19QSUdFT05fMTJfMAkJMHhiMDAKPiA+ICsjZGVmaW5lIEhXX0VQRENfUElHRU9OXzEy
XzEJCTB4YjEwCj4gPiArI2RlZmluZSBIV19FUERDX1BJR0VPTl8xMl8yCQkweGIyMAo+ID4gKwo+
ID4gKyNkZWZpbmUgUElHRU9OXzEyXzBfU0VUX1NUQVRFX01BU0soeCkJUkVHX1BVVCgoeCksIDMx
LCAyNCkKPiA+ICsjZGVmaW5lIFBJR0VPTl8xMl8wX1NFVF9NQVNLX0NOVCh4KQlSRUdfUFVUKCh4
KSwgMjMsIDEyKQo+ID4gKyNkZWZpbmUgUElHRU9OXzEyXzBfU0VUX01BU0tfQ05UX1NFTCh4KQlS
RUdfUFVUKCh4KSwgMTEsICA4KQo+ID4gKyNkZWZpbmUgUElHRU9OXzEyXzBfU0VUX09GRlNFVCh4
KQlSRUdfUFVUKCh4KSwgIDcsICA0KQo+ID4gKyNkZWZpbmUgUElHRU9OXzEyXzBfU0VUX0lOQ19T
RUwoeCkJUkVHX1BVVCgoeCksICAzLCAgMikKPiA+ICsjZGVmaW5lIFBJR0VPTl8xMl8wX1BPTF9B
Q1RJVkVfTE9XCUJJVCgxKQo+ID4gKyNkZWZpbmUgUElHRU9OXzEyXzBfRU4JCQlCSVQoMCkKPiA+
ICsKPiA+ICsjZGVmaW5lIFBJR0VPTl8xMl8xX1NFVF9DTFJfQ05UKHgpCVJFR19QVVQoKHgpLCAz
MSwgMTYpCj4gPiArI2RlZmluZSBQSUdFT05fMTJfMV9TRVRfU0VUX0NOVCh4KQlSRUdfUFVUKCh4
KSwgMTUsICAwKQo+ID4gKwo+ID4gICNkZWZpbmUgTVhTRkJfTUlOX1hSRVMJCQkxMjAKPiA+ICAj
ZGVmaW5lIE1YU0ZCX01JTl9ZUkVTCQkJMTIwCj4gPiAgI2RlZmluZSBNWFNGQl9NQVhfWFJFUwkJ
CTB4ZmZmZgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp
LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==