From: Sean Paul <sean@poorly.run>
To: Rob Herring <robh@kernel.org>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/shmem: Add docbook comments for drm_gem_shmem_object madvise fields
Date: Wed, 6 Nov 2019 12:50:05 -0500 [thread overview]
Message-ID: <20191106175005.GC63329@art_vandelay> (raw)
In-Reply-To: <20191101153754.22803-1-robh@kernel.org>
On Fri, Nov 01, 2019 at 10:37:54AM -0500, Rob Herring wrote:
> Add missing docbook comments to madvise fields in struct
> drm_gem_shmem_object which fixes these warnings:
>
> include/drm/drm_gem_shmem_helper.h:87: warning: Function parameter or member 'madv' not described in 'drm_gem_shmem_object'
> include/drm/drm_gem_shmem_helper.h:87: warning: Function parameter or member 'madv_list' not described in 'drm_gem_shmem_object'
>
> Fixes: 17acb9f35ed7 ("drm/shmem: Add madvise state and purge helpers")
> Reported-by: Sean Paul <sean@poorly.run>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Sean Paul <sean@poorly.run>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> include/drm/drm_gem_shmem_helper.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/drm/drm_gem_shmem_helper.h b/include/drm/drm_gem_shmem_helper.h
> index e2e9947b4770..901eafb09209 100644
> --- a/include/drm/drm_gem_shmem_helper.h
> +++ b/include/drm/drm_gem_shmem_helper.h
> @@ -44,7 +44,20 @@ struct drm_gem_shmem_object {
> */
> unsigned int pages_use_count;
>
> + /**
> + * @madv: State for madvise
> + *
> + * 0 is active/inuse.
> + * A negative value is the object is purged.
> + * Positive values are driver specific and not used by the helpers.
> + */
> int madv;
> +
> + /**
> + * @madv_list: List entry for madvise tracking
> + *
> + * Typically used by drivers to track purgeable objects
> + */
> struct list_head madv_list;
>
> /**
> --
> 2.20.1
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-06 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 15:37 [PATCH] drm/shmem: Add docbook comments for drm_gem_shmem_object madvise fields Rob Herring
2019-11-06 17:50 ` Sean Paul [this message]
2019-11-21 21:26 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106175005.GC63329@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox