dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: display: renesas: du: Add vendor prefix to vsps property
Date: Thu, 7 Nov 2019 04:29:29 +0200	[thread overview]
Message-ID: <20191107022929.GK4878@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191105183504.21447-2-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Tue, Nov 05, 2019 at 07:35:02PM +0100, Geert Uytterhoeven wrote:
> The Renesas-specific "vsps" property lacks a vendor prefix.
> Add a "renesas," prefix to comply with DT best practises.
> 
> Move "renesas,vsps" below "renesas,cmms" to preserve alphabetical sort
> order.
> 
> Fixes: 06711e6385a4ab4c ("drm: rcar-du: Document the vsps property in the DT bindings")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> ---
>  .../devicetree/bindings/display/renesas,du.txt       | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index f6fdaa67c257a046..eb4ae41fe41f83c7 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -41,15 +41,15 @@ Required Properties:
>        supplied they must be named "dclkin.x" with "x" being the input clock
>        numerical index.
>  
> -  - vsps: A list of phandle and channel index tuples to the VSPs that handle
> -    the memory interfaces for the DU channels. The phandle identifies the VSP
> -    instance that serves the DU channel, and the channel index identifies the
> -    LIF instance in that VSP.
> -
>    - renesas,cmms: A list of phandles to the CMM instances present in the SoC,
>      one for each available DU channel. The property shall not be specified for
>      SoCs that do not provide any CMM (such as V3M and V3H).
>  
> +  - renesas,vsps: A list of phandle and channel index tuples to the VSPs that
> +    handle the memory interfaces for the DU channels. The phandle identifies the
> +    VSP instance that serves the DU channel, and the channel index identifies
> +    the LIF instance in that VSP.
> +
>  Required nodes:
>  
>  The connections to the DU output video ports are modeled using the OF graph
> @@ -96,8 +96,8 @@ Example: R8A7795 (R-Car H3) ES2.0 DU
>  			 <&cpg CPG_MOD 722>,
>  			 <&cpg CPG_MOD 721>;
>  		clock-names = "du.0", "du.1", "du.2", "du.3";
> -		vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
>  		renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>;
> +		renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
>  
>  		ports {
>  			#address-cells = <1>;

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-07  2:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 18:35 [PATCH 0/3] dt-bindings: display: renesas: du: Add vendor prefix to vsps property Geert Uytterhoeven
2019-11-05 18:35 ` [PATCH 1/3] " Geert Uytterhoeven
2019-11-07  0:44   ` Rob Herring
2019-11-07  0:44     ` Rob Herring
2019-11-07  2:29   ` Laurent Pinchart [this message]
2019-11-05 18:35 ` [PATCH 2/3] drm: rcar-du: Recognize "renesas, vsps" in addition to "vsps" Geert Uytterhoeven
2019-11-07  2:31   ` [PATCH 2/3] drm: rcar-du: Recognize "renesas,vsps" " Laurent Pinchart
2019-11-05 18:35 ` [PATCH 3/3] arm64: dts: renesas: rcar-gen3: Replace "vsps" by "renesas, vsps" Geert Uytterhoeven
2019-11-07  2:28   ` [PATCH 3/3] arm64: dts: renesas: rcar-gen3: Replace "vsps" by "renesas,vsps" Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107022929.GK4878@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox