From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Date: Tue, 12 Nov 2019 10:32:46 +0100 Message-ID: <20191112093246.GD23790@phenom.ffwll.local> References: <20191024191859.31700-1-robh@kernel.org> <20191025073042.GL11828@phenom.ffwll.local> <20191108162759.GY23790@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AA646EAB1 for ; Tue, 12 Nov 2019 09:32:50 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 8so2165064wmo.0 for ; Tue, 12 Nov 2019 01:32:50 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, Gerd Hoffmann , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMTIsIDIwMTkgYXQgMTA6MjY6NDRBTSArMDEwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gSGkKPiAKPiBBbSAwOC4xMS4xOSB1bSAxNzoyNyBzY2hyaWViIERhbmllbCBW ZXR0ZXI6Cj4gPiBPbiBGcmksIE9jdCAyNSwgMjAxOSBhdCAwOTozMDo0MkFNICswMjAwLCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+ID4+IE9uIFRodSwgT2N0IDI0LCAyMDE5IGF0IDAyOjE4OjU5UE0g LTA1MDAsIFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4+PiBDb21taXQgYzQwMDY5Y2I3YmQ2ICgiZHJt OiBhZGQgbW1hcCgpIHRvIGRybV9nZW1fb2JqZWN0X2Z1bmNzIikKPiA+Pj4gaW50cm9kdWNlZCBh IEdFTSBvYmplY3QgbW1hcCgpIGhvb2sgd2hpY2ggaXMgZXhwZWN0ZWQgdG8gc3VidHJhY3QgdGhl Cj4gPj4+IGZha2Ugb2Zmc2V0IGZyb20gdm1fcGdvZmYuIEhvd2V2ZXIsIGZvciBtbWFwKCkgb24g ZG1hYnVmcywgdGhlcmUgaXMgbm90Cj4gPj4+IGEgZmFrZSBvZmZzZXQuCj4gPj4+Cj4gPj4+IFRv IGZpeCB0aGlzLCBsZXQncyBhbHdheXMgY2FsbCBtbWFwKCkgb2JqZWN0IGNhbGxiYWNrIHdpdGgg YW4gb2Zmc2V0IG9mIDAsCj4gPj4+IGFuZCBsZWF2ZSBpdCB1cCB0byBkcm1fZ2VtX21tYXBfb2Jq KCkgdG8gcmVtb3ZlIHRoZSBmYWtlIG9mZnNldC4KPiA+Pj4KPiA+Pj4gVFRNIHN0aWxsIG5lZWRz IHRoZSBmYWtlIG9mZnNldCwgc28gd2UgaGF2ZSB0byBhZGQgaXQgYmFjayB1bnRpbCB0aGF0J3MK PiA+Pj4gZml4ZWQuCj4gPj4+Cj4gPj4+IEZpeGVzOiBjNDAwNjljYjdiZDYgKCJkcm06IGFkZCBt bWFwKCkgdG8gZHJtX2dlbV9vYmplY3RfZnVuY3MiKQo+ID4+PiBDYzogR2VyZCBIb2ZmbWFubiA8 a3JheGVsQHJlZGhhdC5jb20+Cj4gPj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwu b3JnPgo+ID4+PiAtLS0KPiA+Pj4gdjI6Cj4gPj4+IC0gTW92ZSBzdWJ0cmFjdGluZyB0aGUgZmFr ZSBvZmZzZXQgb3V0IG9mIG1tYXAoKSBvYmogY2FsbGJhY2tzLgo+ID4+Pgo+ID4+PiBJJ3ZlIHRl c3RlZCBzaG1lbSwgYnV0IG5vdCB0dG0uIEhvcGVmdWxseSwgSSB1bmRlcnN0b29kIHdoYXQncyBu ZWVkZWQgCj4gPj4+IGZvciBUVE0uCj4gPiAKPiA+IFNvIHVuZm9ydHVuYXRlbHkgSSdtIGFscmVh ZHkgaGF2aW5nIHJlZ3JldHMgb24gdGhpcy4gV2UgbWlnaHQgZXZlbiBoYXZlCj4gPiBicm9rZW4g c29tZSBvZiB0aGUgdHRtIGRyaXZlcnMgaGVyZS4KPiA+IAo+ID4gVHJvdWJsZSBpcywgaWYgeW91 IG5lZWQgdG8gc2hvb3QgZG93biB1c2Vyc3BhY2UgcHRlcyBvZiBhIGJvIChiZWNhdXNlIGl0J3MK PiA+IGdldHRpbmcgbW92ZWQgb3Igd2hhdGV2ZXIpLCB0aGVuIHdlIGRvIHRoYXQgd2l0aCB1bm1h cF9tYXBwaW5nX3JhbmdlLgo+ID4gV2hpY2ggbWVhbnMgZWFjaCBibyBuZWVkcyB0byBiZSBtYXBw aW5nIHdpdGggYSB1bmlxdWUgKG9mZnNldCwKPiA+IGFkcmVzc19zcGFjZSksIG9yIGl0IHdvbid0 IHdvcmsuIEJ5IHJlbWFwcGluZyBhbGwgdGhlIGJvIHRvIDAgd2UndmUgYnJva2VuCj4gPiB0aGlz LiBXZSd2ZSBhbHNvIGhhZCB0aGlzIGJyb2tlbiB0aGlzIGZvciBhIHdoaWxlIGZvciB0aGUgc2lt cGxpc3RpYwo+ID4gZG1hLWJ1ZiBtbWFwLCBzaW5jZSB3aXRob3V0IGFueSBmdXJ0aGVyIGFjdGlv biB3ZSdsbCByZXVzZSB0aGUgYWRkcmVzcwo+ID4gc3BhY2Ugb2YgdGhlIGRtYS1idWYgaW5vZGUs IG5vdCBvZiB0aGUgZHJtX2RldmljZS4KPiA+IAo+ID4gU3RyYW5nZWx5IGJvdGggZXRuYXZpdiBh bmQgbXNtIGhhdmUgYSBjb21tZW50IHRvIHRoYXQgZWZmZWN0IC0gZ3JlcCBmb3IKPiA+IHVubWFw X21hcHBpbmdfcmFuZ2UuIEJ1dCBuZWl0aGVyIGFjdHVhbGx5IHVzZXMgaXQuCj4gPiAKPiA+IE5v dCBleGFjdGx5IHN1cmUgd2hhdCdzIHRoZSBiZXN0IGNvdXJzZSBvZiBhY3Rpb24gaGVyZSBub3cu Cj4gPiAKPiA+IEFsc28gYWRkaW5nIFRob21hcyBaaW1tZXJtYW5uLCB3aG8ncyB3b3JrZWQgb24g YWxsIHRoZSB2cmFtIGhlbHBlcnMuCj4gCj4gVlJBTSBoZWxwZXJzIHVzZSBkcm1fZ2VtX3R0bV9t bWFwKCksIHdoaWNoIHdyYXBzIHR0bV9ib19tbWFwX29iaigpLgo+IFRoZXNlIGNoYW5nZXMgc2hv dWxkIGJlIHRyYW5zcGFyZW50LgoKVGhlcmUncyBzdGlsbCB0aGUgaXNzdWUgdGhhdCBmb3IgZG1h LWJ1ZiBtbWFwIHZzIGRybSBtbWFwIHlvdSB1c2UKZGlmZmVyZW50IGZfbWFwcGluZywgd2hpY2gg bWVhbnMgdHRtJ3MgcHRlIHNob290ZG93biB3b24ndCB3b3JrIGNvcnJlY3RseQpmb3IgZG1hLWJ1 ZiBtbWFwcy4gQnV0IHllYWggbm9ybWFsIG9wZXJhdGlvbiBmb3IgdHRtL3ZyYW0gaGVscGVycyBz aG91bGQKYmUgZmluZS4KLURhbmllbAoKPiAKPiBCZXN0IHJlZ2FyZHMKPiBUaG9tYXMKPiAKPiA+ IC1EYW5pZWwKPiA+IAo+ID4+Pgo+ID4+PiBSb2IKPiA+Pj4KPiA+Pj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fZ2VtLmMgICAgICAgICAgICAgIHwgMyArKysKPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3NobWVtX2hlbHBlci5jIHwgMyAtLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS90dG0v dHRtX2JvX3ZtLmMgICAgICAgIHwgNyArKysrKysrCj4gPj4+ICBpbmNsdWRlL2RybS9kcm1fZ2Vt LmggICAgICAgICAgICAgICAgICB8IDQgKysrLQo+ID4+PiAgNCBmaWxlcyBjaGFuZ2VkLCAxMyBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Pgo+ID4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+Pj4g aW5kZXggNTZmNDJlMGYyNTg0Li4yZjJiODg5MDk2YjAgMTAwNjQ0Cj4gPj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0u Ywo+ID4+PiBAQCAtMTEwNiw2ICsxMTA2LDkgQEAgaW50IGRybV9nZW1fbW1hcF9vYmooc3RydWN0 IGRybV9nZW1fb2JqZWN0ICpvYmosIHVuc2lnbmVkIGxvbmcgb2JqX3NpemUsCj4gPj4+ICAJCXJl dHVybiAtRUlOVkFMOwo+ID4+PiAgCj4gPj4+ICAJaWYgKG9iai0+ZnVuY3MgJiYgb2JqLT5mdW5j cy0+bW1hcCkgewo+ID4+PiArCQkvKiBSZW1vdmUgdGhlIGZha2Ugb2Zmc2V0ICovCj4gPj4+ICsJ CXZtYS0+dm1fcGdvZmYgLT0gZHJtX3ZtYV9ub2RlX3N0YXJ0KCZvYmotPnZtYV9ub2RlKTsKPiA+ Pj4gKwo+ID4+PiAgCQlyZXQgPSBvYmotPmZ1bmNzLT5tbWFwKG9iaiwgdm1hKTsKPiA+Pj4gIAkJ aWYgKHJldCkKPiA+Pj4gIAkJCXJldHVybiByZXQ7Cj4gPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2Vt X3NobWVtX2hlbHBlci5jCj4gPj4+IGluZGV4IGE4NzhjNzg3Yjg2Ny4uZTgwNjFjNjRjNDgwIDEw MDY0NAo+ID4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYwo+ ID4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYwo+ID4+PiBA QCAtNTQyLDkgKzU0Miw2IEBAIGludCBkcm1fZ2VtX3NobWVtX21tYXAoc3RydWN0IGRybV9nZW1f b2JqZWN0ICpvYmosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hKQo+ID4+PiAgCXZtYS0+dm1f cGFnZV9wcm90ID0gcGdwcm90X2RlY3J5cHRlZCh2bWEtPnZtX3BhZ2VfcHJvdCk7Cj4gPj4+ICAJ dm1hLT52bV9vcHMgPSAmZHJtX2dlbV9zaG1lbV92bV9vcHM7Cj4gPj4+ICAKPiA+Pj4gLQkvKiBS ZW1vdmUgdGhlIGZha2Ugb2Zmc2V0ICovCj4gPj4+IC0Jdm1hLT52bV9wZ29mZiAtPSBkcm1fdm1h X25vZGVfc3RhcnQoJnNobWVtLT5iYXNlLnZtYV9ub2RlKTsKPiA+Pj4gLQo+ID4+PiAgCXJldHVy biAwOwo+ID4+PiAgfQo+ID4+PiAgRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2dlbV9zaG1lbV9tbWFw KTsKPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMgYi9k cml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib192bS5jCj4gPj4+IGluZGV4IDFhOWRiNjkxZjk1NC4u MDg5MDJjNzI5MGE1IDEwMDY0NAo+ID4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9i b192bS5jCj4gPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvX3ZtLmMKPiA+Pj4g QEAgLTQ4Miw2ICs0ODIsMTMgQEAgRVhQT1JUX1NZTUJPTCh0dG1fYm9fbW1hcCk7Cj4gPj4+ICBp bnQgdHRtX2JvX21tYXBfb2JqKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLCBzdHJ1Y3QgdHRt X2J1ZmZlcl9vYmplY3QgKmJvKQo+ID4+PiAgewo+ID4+PiAgCXR0bV9ib19nZXQoYm8pOwo+ID4+ PiArCj4gPj4+ICsJLyoKPiA+Pj4gKwkgKiBGSVhNRTogJmRybV9nZW1fb2JqZWN0X2Z1bmNzLm1t YXAgaXMgY2FsbGVkIHdpdGggdGhlIGZha2Ugb2Zmc2V0Cj4gPj4+ICsJICogcmVtb3ZlZC4gQWRk IGl0IGJhY2sgaGVyZSB1bnRpbCB0aGUgcmVzdCBvZiBUVE0gd29ya3Mgd2l0aG91dCBpdC4KPiA+ Pj4gKwkgKi8KPiA+Pj4gKwl2bWEtPnZtX3Bnb2ZmICs9IGRybV92bWFfbm9kZV9zdGFydCgmYm8t PmJhc2Uudm1hX25vZGUpOwo+ID4+PiArCj4gPj4+ICAJdHRtX2JvX21tYXBfdm1hX3NldHVwKGJv LCB2bWEpOwo+ID4+PiAgCXJldHVybiAwOwo+ID4+PiAgfQo+ID4+PiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX2dlbS5oIGIvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4gPj4+IGluZGV4IGU3 MWY3NWEyYWI1Ny4uYzU2Y2JiMzUwOWUwIDEwMDY0NAo+ID4+PiAtLS0gYS9pbmNsdWRlL2RybS9k cm1fZ2VtLmgKPiA+Pj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2dlbS5oCj4gPj4+IEBAIC0xNTks NyArMTU5LDkgQEAgc3RydWN0IGRybV9nZW1fb2JqZWN0X2Z1bmNzIHsKPiA+Pj4gIAkgKgo+ID4+ PiAgCSAqIFRoZSBjYWxsYmFjayBpcyB1c2VkIGJ5IGJ5IGJvdGggZHJtX2dlbV9tbWFwX29iaigp IGFuZAo+ID4+PiAgCSAqIGRybV9nZW1fcHJpbWVfbW1hcCgpLiAgV2hlbiBAbW1hcCBpcyBwcmVz ZW50IEB2bV9vcHMgaXMgbm90Cj4gPj4+IC0JICogdXNlZCwgdGhlIEBtbWFwIGNhbGxiYWNrIG11 c3Qgc2V0IHZtYS0+dm1fb3BzIGluc3RlYWQuCj4gPj4+ICsJICogdXNlZCwgdGhlIEBtbWFwIGNh bGxiYWNrIG11c3Qgc2V0IHZtYS0+dm1fb3BzIGluc3RlYWQuIFRoZSBAbW1hcAo+ID4+PiArCSAq IGNhbGxiYWNrIGlzIGFsd2F5cyBjYWxsZWQgd2l0aCBhIDAgb2Zmc2V0LiBUaGUgY2FsbGVyIHdp bGwgcmVtb3ZlCj4gPj4+ICsJICogdGhlIGZha2Ugb2Zmc2V0IGFzIG5lY2Vzc2FyeS4KPiA+Pj4g IAkgKgo+ID4+Cj4gPj4gTWF5YmUgcmVtb3ZlIHRoaXMgZW1wdHkgY29tbWVudCBsaW5lIGhlcmUg d2hpbGUgYXQgaXQuIFdpdGggdGhhdAo+ID4+Cj4gPj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0 ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPj4KPiA+PiBJIHRoaW5rIEknbGwgZm9sbG93 IHVwIHdpdGggYSBwYXRjaCB0byBhbm5vdGF0ZSBkcm1fZ2VtX21tYXBfb2JqIGFzCj4gPj4gZGVw cmVjYXRlZCBhbmQgdGhhdCBpbnN0ZWFkIHRoaXMgaGVyZSBzaG91bGQgYmUgdXNlZC4KPiA+PiAt RGFuaWVsCj4gPj4KPiA+Pj4gIAkgKi8KPiA+Pj4gIAlpbnQgKCptbWFwKShzdHJ1Y3QgZHJtX2dl bV9vYmplY3QgKm9iaiwgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpOwo+ID4+PiAtLSAKPiA+ Pj4gMi4yMC4xCj4gPj4+Cj4gPj4KPiA+PiAtLSAKPiA+PiBEYW5pZWwgVmV0dGVyCj4gPj4gU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gPj4gaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKPiA+IAo+IAo+IC0tIAo+IFRob21hcyBaaW1tZXJtYW5uCj4gR3JhcGhpY3MgRHJpdmVyIERl dmVsb3Blcgo+IFNVU0UgU29mdHdhcmUgU29sdXRpb25zIEdlcm1hbnkgR21iSAo+IE1heGZlbGRz dHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQo+IChIUkIgMzY4MDksIEFHIE7DvHJuYmVy ZykKPiBHZXNjaMOkZnRzZsO8aHJlcjogRmVsaXggSW1lbmTDtnJmZmVyCj4gCgoKCgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs