Re: [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti,ds90c185.txt

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Biju Das <biju.das@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti,ds90c185.txt
Date: Tue, 19 Nov 2019 01:56:59 +0200	[thread overview]
Message-ID: <20191118235659.GC5171@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1573660292-10629-4-git-send-email-fabrizio.castro@bp.renesas.com>

Hi Fabrizio,

Thank you for the patch.

On Wed, Nov 13, 2019 at 03:51:22PM +0000, Fabrizio Castro wrote:
> ti,ds90c185.txt documents LVDS encoders using the same driver
> as the one documented by lvds-transmitter.yaml.
> Since the properties listed in ti,ds90c185.txt are the same
> as the ones listed in lvds-transmitter.yaml, absorb the dt-binding
> into lvds-transmitter.yaml.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v3->v4:
> * New patch
> ---
>  .../bindings/display/bridge/lvds-transmitter.yaml  | 14 +++---
>  .../bindings/display/bridge/ti,ds90c185.txt        | 55 ----------------------
>  2 files changed, 8 insertions(+), 61 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml
> index 2484737..a8326ce 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml
> @@ -31,11 +31,13 @@ description: |
>  properties:
>    compatible:
>      description: |
> -      Any encoder compatible with this generic binding, but with additional
> -      properties not listed here, must define its own binding and list a device
> -      specific compatible first followed by the generic compatible.
> -    enum:
> -      - lvds-encoder
> +      Must list the device specific compatible string first, followed by the
> +      generic compatible string.
> +    items:
> +      - enum:
> +        - ti,ds90c185       # For the TI DS90C185 FPD-Link Serializer
> +        - ti,ds90c187       # For the TI DS90C187 FPD-Link Serializer
> +      - const: lvds-encoder # Generic LVDS encoder compatible fallback
>  
>    ports:
>      type: object
> @@ -69,7 +71,7 @@ required:
>  examples:
>    - |
>      lvds-encoder {
> -      compatible = "lvds-encoder";
> +      compatible = "ti,ds90c185", "lvds-encoder";
>  
>        ports {
>          #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> deleted file mode 100644
> index e575f99..0000000
> --- a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
> +++ /dev/null
> @@ -1,55 +0,0 @@
> -Texas Instruments FPD-Link (LVDS) Serializer
> ---------------------------------------------
> -
> -The DS90C185 and DS90C187 are low-power serializers for portable
> -battery-powered applications that reduces the size of the RGB
> -interface between the host GPU and the display.
> -
> -Required properties:
> -
> -- compatible: Should be
> -  "ti,ds90c185", "lvds-encoder"  for the TI DS90C185 FPD-Link Serializer
> -  "ti,ds90c187", "lvds-encoder"  for the TI DS90C187 FPD-Link Serializer
> -
> -Optional properties:
> -
> -- powerdown-gpios: Power down control GPIO (the PDB pin, active-low)
> -
> -Required nodes:
> -
> -The devices have two video ports. Their connections are modeled using the OF
> -graph bindings specified in Documentation/devicetree/bindings/graph.txt.
> -
> -- Video port 0 for parallel input
> -- Video port 1 for LVDS output
> -
> -
> -Example
> --------
> -
> -lvds-encoder {
> -	compatible = "ti,ds90c185", "lvds-encoder";
> -
> -	powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
> -
> -	ports {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		port@0 {
> -			reg = <0>;
> -
> -			lvds_enc_in: endpoint {
> -				remote-endpoint = <&lcdc_out_rgb>;
> -			};
> -		};
> -
> -		port@1 {
> -			reg = <1>;
> -
> -			lvds_enc_out: endpoint {
> -				remote-endpoint = <&lvds_panel_in>;
> -			};
> -		};
> -	};
> -};
> -- 
> 2.7.4
> 

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel